netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: "Asbjørn Sloth Tønnesen" <ast@fiberby.net>
Cc: "Jason A. Donenfeld" <Jason@zx2c4.com>,
	Donald Hunter <donald.hunter@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
	Jacob Keller <jacob.e.keller@intel.com>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	wireguard@lists.zx2c4.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, Jordan Rife <jordan@jrife.io>
Subject: Re: [PATCH net-next v3 04/11] netlink: specs: add specification for wireguard
Date: Wed, 19 Nov 2025 18:27:27 -0800	[thread overview]
Message-ID: <20251119182727.612321f8@kernel.org> (raw)
In-Reply-To: <f4d147da-3299-4ae7-b11e-b4309625e2c9@fiberby.net>

On Wed, 19 Nov 2025 19:19:28 +0000 Asbjørn Sloth Tønnesen wrote:
> >> Also fine with me. I'd just like consistent function naming, one way or
> >> another.  
> > 
> > IIUC we're talking about the prefix for the kernel C codegen?
> > Feels a bit like a one-off feature to me, but if we care deeply about
> > it let's add it as a CLI param to the codegen. I don't think it's
> > necessary to include this in the YAML spec.  
> 
> IIUC then adding it as a CLI param is more work, and just moves family details
> to ynl-regen, might as well skip the CLI param then and hack it in the codegen.
> 
> Before posting any new patches, I would like to get consensus on this.

The reason other C naming tunables exist (for legacy families!)
is because we need to give enough hints to C code gen to be able
to use existing kernel uAPI headers.

Random "naming preferences" do not belong in the spec. The spec 
is primarily for user space, and it's used by 4 languages already.

  parent reply	other threads:[~2025-11-20  2:27 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-05 18:32 [PATCH net-next v3 00/11] wireguard: netlink: ynl conversion Asbjørn Sloth Tønnesen
2025-11-05 18:32 ` [PATCH net-next v3 01/11] wireguard: netlink: validate nested arrays in policy Asbjørn Sloth Tønnesen
2025-11-05 18:32 ` [PATCH net-next v3 02/11] wireguard: netlink: use WG_KEY_LEN in policies Asbjørn Sloth Tønnesen
2025-11-05 18:32 ` [PATCH net-next v3 03/11] wireguard: netlink: enable strict genetlink validation Asbjørn Sloth Tønnesen
2025-11-18 15:15   ` Jason A. Donenfeld
2025-11-18 17:10   ` Jason A. Donenfeld
2025-11-26 16:24     ` Asbjørn Sloth Tønnesen
2025-11-26 16:26       ` Jason A. Donenfeld
2025-11-05 18:32 ` [PATCH net-next v3 04/11] netlink: specs: add specification for wireguard Asbjørn Sloth Tønnesen
2025-11-18  2:15   ` Jason A. Donenfeld
2025-11-18 12:08     ` Asbjørn Sloth Tønnesen
2025-11-18 15:07       ` Jason A. Donenfeld
2025-11-18 21:59         ` Asbjørn Sloth Tønnesen
2025-11-18 22:52           ` Jason A. Donenfeld
2025-11-19  0:50             ` Jakub Kicinski
2025-11-19 19:19               ` Asbjørn Sloth Tønnesen
2025-11-19 19:22                 ` Jason A. Donenfeld
2025-11-19 19:47                   ` Asbjørn Sloth Tønnesen
2025-11-19 20:01                     ` Jason A. Donenfeld
2025-11-20  2:27                 ` Jakub Kicinski [this message]
2025-11-05 18:32 ` [PATCH net-next v3 05/11] uapi: wireguard: move enum wg_cmd Asbjørn Sloth Tønnesen
2025-11-05 18:32 ` [PATCH net-next v3 06/11] uapi: wireguard: move flag enums Asbjørn Sloth Tønnesen
2025-11-18 15:10   ` Jason A. Donenfeld
2025-11-05 18:32 ` [PATCH net-next v3 07/11] uapi: wireguard: generate header with ynl-gen Asbjørn Sloth Tønnesen
2025-11-18 15:17   ` Jason A. Donenfeld
2025-11-19  0:53     ` Jakub Kicinski
2025-11-20  0:55       ` Jason A. Donenfeld
2025-11-05 18:32 ` [PATCH net-next v3 08/11] tools: ynl: add sample for wireguard Asbjørn Sloth Tønnesen
2025-11-18 15:20   ` Jason A. Donenfeld
2025-11-18 17:16     ` Asbjørn Sloth Tønnesen
2025-11-18 17:17       ` Jason A. Donenfeld
2025-11-05 18:32 ` [PATCH net-next v3 09/11] wireguard: netlink: convert to split ops Asbjørn Sloth Tønnesen
2025-11-05 18:32 ` [PATCH net-next v3 10/11] wireguard: netlink: rename netlink handlers Asbjørn Sloth Tønnesen
2025-11-05 18:32 ` [PATCH net-next v3 11/11] wireguard: netlink: generate netlink code Asbjørn Sloth Tønnesen
2025-11-18 15:15   ` Jason A. Donenfeld
2025-11-18 16:57     ` Jason A. Donenfeld
2025-11-18 22:23     ` Asbjørn Sloth Tønnesen
2025-11-18 22:51       ` Jason A. Donenfeld
2025-11-19  1:00         ` Jakub Kicinski
2025-11-20  0:54           ` Jason A. Donenfeld
2025-11-20  2:44             ` Jakub Kicinski
2025-11-20  2:46               ` Jason A. Donenfeld
2025-11-20  3:19                 ` Jakub Kicinski
2025-11-20 19:49             ` Asbjørn Sloth Tønnesen
2025-11-11  2:07 ` [PATCH net-next v3 00/11] wireguard: netlink: ynl conversion Jakub Kicinski
2025-11-12  3:59   ` Jason A. Donenfeld
2025-11-18  0:14     ` Jakub Kicinski
2025-11-18  0:43       ` Jason A. Donenfeld
2025-11-18  0:56         ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251119182727.612321f8@kernel.org \
    --to=kuba@kernel.org \
    --cc=Jason@zx2c4.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=ast@fiberby.net \
    --cc=davem@davemloft.net \
    --cc=donald.hunter@gmail.com \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=jacob.e.keller@intel.com \
    --cc=jordan@jrife.io \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=wireguard@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).