From: Jakub Kicinski <kuba@kernel.org>
To: I Viswanath <viswanathiyyappan@gmail.com>
Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, horms@kernel.org, mst@redhat.com,
jasowang@redhat.com, xuanzhuo@linux.alibaba.com,
eperezma@redhat.com, sdf@fomichev.me, kuniyu@google.com,
skhawaja@google.com, aleksander.lobakin@intel.com,
virtualization@lists.linux.dev, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-kernel-mentees@lists.linux.dev
Subject: Re: [RFT net-next v4 0/2] net: Split ndo_set_rx_mode into snapshot and deferred write
Date: Wed, 19 Nov 2025 18:51:35 -0800 [thread overview]
Message-ID: <20251119185135.433c9bea@kernel.org> (raw)
In-Reply-To: <CAPrAcgOBa5Q3k5r=G4qixzWRuvK+PEinj9sGVf-nxWYon4BkpA@mail.gmail.com>
On Wed, 19 Nov 2025 09:27:58 +0530 I Viswanath wrote:
> > Also I'm not sure what you mean by RFT, doubt anyone will test this
> > for you, and you're modifying virtio which you should be able to test
> > yourself.. RFC or PATCH is the choice.
>
> Just to be clear, would testing packet flow with all the possible mode
> combinations
> under heavy traffic be sufficient and exhaustive? I think this should
> be PATCH once I sort everything out
I don't think traffic matters all that much, we're talking about control
path change. It's more important to exercise all the address lists
(l2 unicast, multicast) and rx modes (promisc, allmulti) etc.
Then whatever other paths may load to touching the relevant state in
the driver (eg virtnet_freeze_down(), not triggers that, suspend?,
migration?).
In terms of traffic simple ping or a few UDP packets would be enough,
mostly to confirm the filtering is working as expected.
prev parent reply other threads:[~2025-11-20 2:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-18 16:43 [RFT net-next v4 0/2] net: Split ndo_set_rx_mode into snapshot and deferred write I Viswanath
2025-11-18 16:43 ` [RFT net-next v4] net: refactor set_rx_mode into snapshot and deferred I/O I Viswanath
2025-11-18 16:43 ` [RFT net-next v4 2/2] virtio-net: Implement ndO_write_rx_mode callback I Viswanath
2025-11-18 16:56 ` [RFT net-next v4 0/2] net: Split ndo_set_rx_mode into snapshot and deferred write I Viswanath
2025-11-18 18:50 ` Jakub Kicinski
2025-11-19 3:57 ` I Viswanath
2025-11-20 2:51 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251119185135.433c9bea@kernel.org \
--to=kuba@kernel.org \
--cc=aleksander.lobakin@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eperezma@redhat.com \
--cc=horms@kernel.org \
--cc=jasowang@redhat.com \
--cc=kuniyu@google.com \
--cc=linux-kernel-mentees@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
--cc=skhawaja@google.com \
--cc=virtualization@lists.linux.dev \
--cc=viswanathiyyappan@gmail.com \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).