From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2E4D92848AD; Thu, 20 Nov 2025 02:10:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763604646; cv=none; b=WWJZr6diVYKeDAtoclEZaz8sjNks2bHTFqchzsOmT9vU7pY6o9/EKOKEL+93iUvFszlmazDpVairgX7yuI9PRNmWwnR/ndhapGMfSWsJfS6ndLvjYmx8TRh5HF+ZqFG8kAQQVxgloN5q2rDuW7gTshZBmMAyebqtECzF+8oDW7Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763604646; c=relaxed/simple; bh=IUcPeWNZljsHa8gGGb0dD6naYcxNa7iPqeGWfBZwufs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=j4gfJ4mh4x0e63x0KMK/cfbkO90EFQz3h8w2RFnr/YeHFub7lPHbj8Vu8SalS8IJ4iZAZqYxNjPVe1yiUbCZpyltAl3C2eY9U/LhGSUtfSnSd6qD5Zb9xt+QzEEl8bJZZrguIiXHkwjijABCv0mZ80f/0p3WThD0/CU99wEYMEU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=DkwoLF5/; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="DkwoLF5/" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1405DC2BC86; Thu, 20 Nov 2025 02:10:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1763604645; bh=IUcPeWNZljsHa8gGGb0dD6naYcxNa7iPqeGWfBZwufs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=DkwoLF5/SGuxzwTVS6fUiq/UoElTjYZV7EwRrK1ZWuadGG/1mYoF9FtZhsleRxzBR 6VX2dG1XptoTe4MfZ7UYddELbMNX224M+vUmauxwYAvI5rmGvdOwiK4kBjgTMpSrMs 0Xqy+gfk3in60LY77353KGg6eoG2qWUF5xqFPTEO0BJNEvuitUEvqHZSUBFlQgWQoJ 297AhtnF1ovhsXfmmciJWghoMfYoG3BSBmN+x4wAaXAnahnwYa+9WolRDPhH/zwTtl Q4qSZTPZPG7V6Ec23k0cxfHhVQmzsodRJekYJie21n8H9maZWYfhNTUxu/JPvITAoZ zcbyAOvh42cCA== From: Jakub Kicinski To: davem@davemloft.net Cc: netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org, willemdebruijn.kernel@gmail.com, shuah@kernel.org, sdf@fomichev.me, krakauer@google.com, linux-kselftest@vger.kernel.org, petrm@nvidia.com, matttbe@kernel.org, Jakub Kicinski , Willem de Bruijn , leitao@debian.org Subject: [PATCH net-next v3 06/12] selftests: net: py: support ksft ready without wait Date: Wed, 19 Nov 2025 18:10:18 -0800 Message-ID: <20251120021024.2944527-7-kuba@kernel.org> X-Mailer: git-send-email 2.51.1 In-Reply-To: <20251120021024.2944527-1-kuba@kernel.org> References: <20251120021024.2944527-1-kuba@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit There's a common synchronization problem when a script (Python test) uses a C program to set up some state (usually start a receiving process for traffic). The script needs to know when the process has fully initialized. The inverse of the problem exists for shutting the process down - we need a reliable way to tell the process to exit. We added helpers to do this safely in commit 71477137994f ("selftests: drv-net: add a way to wait for a local process") unfortunately the two operations (wait for init, and shutdown) are controlled by a single parameter (ksft_wait). Add support for using ksft_ready without using the second fd for exit. This is useful for programs which wait for a specific number of packets to rx so exit_wait is a good match, but we still need to wait for init. Reviewed-by: Petr Machata Reviewed-by: Willem de Bruijn Signed-off-by: Jakub Kicinski --- cc: leitao@debian.org --- tools/testing/selftests/net/lib/py/utils.py | 20 ++++++++++++-------- 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/tools/testing/selftests/net/lib/py/utils.py b/tools/testing/selftests/net/lib/py/utils.py index cb40ecef9456..106ee1f2df86 100644 --- a/tools/testing/selftests/net/lib/py/utils.py +++ b/tools/testing/selftests/net/lib/py/utils.py @@ -32,7 +32,7 @@ import time Use bkg() instead to run a command in the background. """ def __init__(self, comm, shell=None, fail=True, ns=None, background=False, - host=None, timeout=5, ksft_wait=None): + host=None, timeout=5, ksft_ready=None, ksft_wait=None): if ns: comm = f'ip netns exec {ns} ' + comm @@ -52,21 +52,25 @@ import time # ksft_wait lets us wait for the background process to fully start, # we pass an FD to the child process, and wait for it to write back. # Similarly term_fd tells child it's time to exit. - pass_fds = () + pass_fds = [] env = os.environ.copy() if ksft_wait is not None: - rfd, ready_fd = os.pipe() wait_fd, self.ksft_term_fd = os.pipe() - pass_fds = (ready_fd, wait_fd, ) - env["KSFT_READY_FD"] = str(ready_fd) + pass_fds.append(wait_fd) env["KSFT_WAIT_FD"] = str(wait_fd) + ksft_ready = True # ksft_wait implies ready + if ksft_ready is not None: + rfd, ready_fd = os.pipe() + pass_fds.append(ready_fd) + env["KSFT_READY_FD"] = str(ready_fd) self.proc = subprocess.Popen(comm, shell=shell, stdout=subprocess.PIPE, stderr=subprocess.PIPE, pass_fds=pass_fds, env=env) if ksft_wait is not None: - os.close(ready_fd) os.close(wait_fd) + if ksft_ready is not None: + os.close(ready_fd) msg = fd_read_timeout(rfd, ksft_wait) os.close(rfd) if not msg: @@ -116,10 +120,10 @@ import time with bkg("my_binary", ksft_wait=5): """ def __init__(self, comm, shell=None, fail=None, ns=None, host=None, - exit_wait=False, ksft_wait=None): + exit_wait=False, ksft_ready=None, ksft_wait=None): super().__init__(comm, background=True, shell=shell, fail=fail, ns=ns, host=host, - ksft_wait=ksft_wait) + ksft_ready=ksft_ready, ksft_wait=ksft_wait) self.terminate = not exit_wait and not ksft_wait self._exit_wait = exit_wait self.check_fail = fail -- 2.51.1