[PATCH net-next] selftests: netconsole: ensure required log level is set on netcons_basic

[PATCH net-next] selftests: netconsole: ensure required log level is set on netcons_basic

[Andre Carvalho]

This commit ensures that the required log level is set at the start of
the test iteration.

Part of the cleanup performed at the end of each test iteration resets
the log level (do_cleanup in lib_netcons.sh) to the values defined at the
time test script started. This may cause further test iterations to fail
if the default values are not sufficient.

Signed-off-by: Andre Carvalho <asantostc@gmail.com>
---
 tools/testing/selftests/drivers/net/netcons_basic.sh | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/tools/testing/selftests/drivers/net/netcons_basic.sh b/tools/testing/selftests/drivers/net/netcons_basic.sh
index a3446b569976..2022f3061738 100755
--- a/tools/testing/selftests/drivers/net/netcons_basic.sh
+++ b/tools/testing/selftests/drivers/net/netcons_basic.sh
@@ -28,8 +28,6 @@ OUTPUT_FILE="/tmp/${TARGET}"
 
 # Check for basic system dependency and exit if not found
 check_for_dependencies
-# Set current loglevel to KERN_INFO(6), and default to KERN_NOTICE(5)
-echo "6 5" > /proc/sys/kernel/printk
 # Remove the namespace, interfaces and netconsole target on exit
 trap cleanup EXIT
 
@@ -39,6 +37,9 @@ do
 	for IP_VERSION in "ipv6" "ipv4"
 	do
 		echo "Running with target mode: ${FORMAT} (${IP_VERSION})"
+		# Set current loglevel to KERN_INFO(6), and default to
+		# KERN_NOTICE(5)
+		echo "6 5" > /proc/sys/kernel/printk
 		# Create one namespace and two interfaces
 		set_network "${IP_VERSION}"
 		# Create a dynamic target for netconsole

---
base-commit: e2c20036a8879476c88002730d8a27f4e3c32d4b
change-id: 20251121-netcons-basic-loglevel-69e2715c1029

Best regards,
-- 
Andre Carvalho <asantostc@gmail.com>

Re: [PATCH net-next] selftests: netconsole: ensure required log level is set on netcons_basic

[Breno Leitao]

On Fri, Nov 21, 2025 at 03:00:22PM +0000, Andre Carvalho wrote:
> This commit ensures that the required log level is set at the start of
> the test iteration.
> 
> Part of the cleanup performed at the end of each test iteration resets
> the log level (do_cleanup in lib_netcons.sh) to the values defined at the
> time test script started. This may cause further test iterations to fail
> if the default values are not sufficient.
> 
> Signed-off-by: Andre Carvalho <asantostc@gmail.com>

Reviewed-by: Breno Leitao <leitao@debian.org>

Re: [PATCH net-next] selftests: netconsole: ensure required log level is set on netcons_basic

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Fri, 21 Nov 2025 15:00:22 +0000 you wrote:
> This commit ensures that the required log level is set at the start of
> the test iteration.
> 
> Part of the cleanup performed at the end of each test iteration resets
> the log level (do_cleanup in lib_netcons.sh) to the values defined at the
> time test script started. This may cause further test iterations to fail
> if the default values are not sufficient.
> 
> [...]

Here is the summary with links:
  - [net-next] selftests: netconsole: ensure required log level is set on netcons_basic
    https://git.kernel.org/netdev/net-next/c/00f3b3251814

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html