Re: [PATCH net-next 03/11] net: dsa: Kconfig: Expand config description to cover RZ/T2H and RZ/N2H ETHSW

Lad, Prabhakar
2025-11-21T20:59:23Z

Hi Vladimir,

Thank you for the review.

On Fri, Nov 21, 2025 at 7:30 PM Vladimir Oltean <olteanv@gmail.com> wrote:
>
> On Fri, Nov 21, 2025 at 11:35:29AM +0000, Prabhakar wrote:
> > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> >
> > Update the Kconfig entry for the RZN1 A5PSW tag driver to reflect that
> > the same tagging format is also used by the ETHSW blocks found in Renesas
> > RZ/T2H and RZ/N2H SoCs.
> >
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > ---
> > net/dsa/Kconfig | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/net/dsa/Kconfig b/net/dsa/Kconfig
> > index f86b30742122..a00eb3bdcd0f 100644
> > --- a/net/dsa/Kconfig
> > +++ b/net/dsa/Kconfig
> > @@ -159,11 +159,11 @@ config NET_DSA_TAG_RTL8_4
> > switches with 8 byte protocol 4 tags, such as the Realtek RTL8365MB-VC.
> >
> > config NET_DSA_TAG_RZN1_A5PSW
> > - tristate "Tag driver for Renesas RZ/N1 A5PSW switch"
> > + tristate "Tag driver for Renesas RZ/N1 A5PSW and RZ/{T2H,N2H} ETHSW switches"
> > help
> > Say Y or M if you want to enable support for tagging frames for
> > - Renesas RZ/N1 embedded switch that uses an 8 byte tag located after
> > - destination MAC address.
> > + Renesas RZ/N1 A5PSW and RZ/{T2H,N2H} ETHSW embedded switches that use
> > + an 8-byte tag located after the destination MAC address.
>
> I think the device names are sufficiently strange with that forward
> slash in them, that you shouldn't make them worse with the {}, at least
> not in the full help text, and spell them out instead. It's hard for an
> unfamiliar reader to know which punctuation marks to take literally and
> which not to... (plus it makes it more difficult to find through grep)
>
Agreed, I will add the full device names.

Cheers,
Prabhakar