From: Jakub Kicinski <kuba@kernel.org>
To: David Wei <dw@davidwei.uk>
Cc: netdev@vger.kernel.org, Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Daniel Borkmann <daniel@iogearbox.net>
Subject: Re: [PATCH net-next v2 3/5] selftests/net: add LOCAL_PREFIX_V{4,6} env to HW selftests
Date: Mon, 24 Nov 2025 09:32:41 -0800 [thread overview]
Message-ID: <20251124093241.555d7d21@kernel.org> (raw)
In-Reply-To: <20251123005108.3694230-4-dw@davidwei.uk>
On Sat, 22 Nov 2025 16:51:06 -0800 David Wei wrote:
> diff --git a/tools/testing/selftests/drivers/net/lib/py/env.py b/tools/testing/selftests/drivers/net/lib/py/env.py
> index 8b644fd84ff2..4004d1a3c82e 100644
> --- a/tools/testing/selftests/drivers/net/lib/py/env.py
> +++ b/tools/testing/selftests/drivers/net/lib/py/env.py
> @@ -196,6 +196,7 @@ class NetDrvEpEnv(NetDrvEnvBase):
> def _check_env(self):
> vars_needed = [
> ["LOCAL_V4", "LOCAL_V6"],
> + ["LOCAL_PREFIX_V4", "LOCAL_PREFIX_V6"],
> ["REMOTE_V4", "REMOTE_V6"],
> ["REMOTE_TYPE"],
> ["REMOTE_ARGS"]
The DrvEpEnv does not need the local_prefix vars.
Only NetDrvContEnv should require those.
--
pw-bot: cr
next prev parent reply other threads:[~2025-11-24 17:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-23 0:51 [PATCH net-next v2 0/5] selftests/net: add container ping test David Wei
2025-11-23 0:51 ` [PATCH net-next v2 1/5] selftests/net: parametrise iou-zcrx.py with ksft_variants David Wei
2025-11-23 0:51 ` [PATCH net-next v2 2/5] selftests/net: add bpf skb forwarding program David Wei
2025-11-23 0:51 ` [PATCH net-next v2 3/5] selftests/net: add LOCAL_PREFIX_V{4,6} env to HW selftests David Wei
2025-11-24 17:32 ` Jakub Kicinski [this message]
2025-11-24 18:06 ` David Wei
2025-11-23 0:51 ` [PATCH net-next v2 4/5] selftests/net: add env for container based tests David Wei
2025-11-23 0:51 ` [PATCH net-next v2 5/5] selftests/net: add a netkit netns ping test David Wei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251124093241.555d7d21@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dw@davidwei.uk \
--cc=edumazet@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).