From: Jakub Kicinski <kuba@kernel.org>
To: Jiri Pirko <jiri@resnulli.us>
Cc: Parav Pandit <parav@nvidia.com>, Jiri Pirko <jiri@nvidia.com>,
netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, horms@kernel.org
Subject: Re: [PATCH net-next v1] devlink: Notify eswitch mode changes to devlink monitor
Date: Mon, 24 Nov 2025 20:27:48 -0800 [thread overview]
Message-ID: <20251124202748.1816f4a0@kernel.org> (raw)
In-Reply-To: <fiiqvm3to3rq6yzdvj2uybfqtolrlep63ttjtpa2p7x2p2y6xb@3wh3ya5ujeud>
On Sat, 22 Nov 2025 10:14:35 +0100 Jiri Pirko wrote:
> >> For the sake of consistency, shouldn't the name be ESWITCH_NEW?
> >
> >No preference on the naming, we can go with _NEW, tho, as I think Parav
> >is alluding to, we don't send _NEW when device is created (which would
> >be the natural fit for _NEW). Perhaps we should?
>
> devlink_notify(devlink, DEVLINK_CMD_NEW); - is this what you mean by
> "when device is created"?
>
> If you mean DEVLINK_CMD_ESWITCH_NEW, then I believe we should send it
> both when
> 1) device is registered, right after we send devlink_notify(devlink, DEVLINK_CMD_NEW);
> in devlink_notify_register()
> 2) when eswitch config is changed in devlink_nl_eswitch_set_doit()
>
> And for the sake of completeness, we should also send
> DEVLINK_CMD_ESWITCH_DEL from devlink_notify_unregister().
Sounds right!
prev parent reply other threads:[~2025-11-25 4:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-19 16:59 [PATCH net-next v1] devlink: Notify eswitch mode changes to devlink monitor Parav Pandit
2025-11-20 1:56 ` Jakub Kicinski
2025-11-20 12:09 ` Jiri Pirko
2025-11-20 14:52 ` Jakub Kicinski
2025-11-20 14:56 ` Parav Pandit
2025-11-21 8:35 ` Jiri Pirko
2025-11-21 8:51 ` Parav Pandit
2025-11-21 14:48 ` Jakub Kicinski
2025-11-22 9:14 ` Jiri Pirko
2025-11-25 4:27 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251124202748.1816f4a0@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jiri@nvidia.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=parav@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).