From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3104B3191CE; Tue, 25 Nov 2025 11:21:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764069678; cv=none; b=GDiAOKo/mZ1lh4NDBNrIrhcyoIgHcURCdnj6Rg4cdMV0wgvPKok9XFegcj37pU2FBR74Xoma3fZ/LV4lvS+CQoNdIHAx7S0g5s8Ssn1bEnrZnCZXNtST0jgTQqFK0a+06KAUTLlRuXwqZIU77wXcvVhIqfeUJxvhzOTpnhh+MQ0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764069678; c=relaxed/simple; bh=ojQbZhl9/UoLYyTWiR/Xt8gUrD7F0HYxv+2c5BQm2qk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=IAG1RU0UGyPX5YIVLtOnNdiHQKknVKNGZMt2qB5mWqxHj4R5ii24Id2gaNtvG0gZTptA70UEAwT00kEKnczS7bqs5+f0sYcmPWKJGvprn2t4Cxr1ow94HURGTxTV4uun2vBoIyMIFO0XzIPp4jm+fbxUYKMoQxlpqePa0dA5MlQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de Received: by verein.lst.de (Postfix, from userid 2407) id 3BF8468B05; Tue, 25 Nov 2025 12:21:11 +0100 (CET) Date: Tue, 25 Nov 2025 12:21:11 +0100 From: "hch@lst.de" To: Nilay Shroff Cc: Chaitanya Kulkarni , Christoph Hellwig , Chaitanya Kulkarni , "kbusch@kernel.org" , "hch@lst.de" , "hare@suse.de" , "sagi@grimberg.me" , "axboe@kernel.dk" , "dlemoal@kernel.org" , "wagi@kernel.org" , "mpatocka@redhat.com" , "yukuai3@huawei.com" , "xni@redhat.com" , "linan122@huawei.com" , "bmarzins@redhat.com" , "john.g.garry@oracle.com" , "edumazet@google.com" , "ncardwell@google.com" , "kuniyu@google.com" , "davem@davemloft.net" , "dsahern@kernel.org" , "kuba@kernel.org" , "pabeni@redhat.com" , "horms@kernel.org" , "netdev@vger.kernel.org" , "linux-nvme@lists.infradead.org" , "linux-block@vger.kernel.org" Subject: Re: [RFC blktests fix PATCH] tcp: use GFP_ATOMIC in tcp_disconnect Message-ID: <20251125112111.GA22545@lst.de> References: <20251125061142.18094-1-ckulkarnilinux@gmail.com> <0caa9d00-3f69-4ade-b93b-eea307fe6f72@linux.ibm.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0caa9d00-3f69-4ade-b93b-eea307fe6f72@linux.ibm.com> User-Agent: Mutt/1.5.17 (2007-11-01) On Tue, Nov 25, 2025 at 04:43:25PM +0530, Nilay Shroff wrote: > The memalloc_noreclaim_save() above shall already prevent filesystem > reclaim, memalloc_noreclaim_save is oddly misnamed, as it sets the PF_MEMALLOC, which does not cause any gfp_t flag adjustments, but instead avoid direct reclaim. Thinking of it I have no idea why it is even used here.