From: Christoph Hellwig <hch@lst.de>
To: Nilay Shroff <nilay@linux.ibm.com>
Cc: Chaitanya Kulkarni <chaitanyak@nvidia.com>,
Chaitanya Kulkarni <ckulkarnilinux@gmail.com>,
"kbusch@kernel.org" <kbusch@kernel.org>,
"hare@suse.de" <hare@suse.de>,
"sagi@grimberg.me" <sagi@grimberg.me>,
"axboe@kernel.dk" <axboe@kernel.dk>,
"dlemoal@kernel.org" <dlemoal@kernel.org>,
"wagi@kernel.org" <wagi@kernel.org>,
"mpatocka@redhat.com" <mpatocka@redhat.com>,
"yukuai3@huawei.com" <yukuai3@huawei.com>,
"xni@redhat.com" <xni@redhat.com>,
"linan122@huawei.com" <linan122@huawei.com>,
"bmarzins@redhat.com" <bmarzins@redhat.com>,
"john.g.garry@oracle.com" <john.g.garry@oracle.com>,
"edumazet@google.com" <edumazet@google.com>,
"ncardwell@google.com" <ncardwell@google.com>,
"kuniyu@google.com" <kuniyu@google.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"dsahern@kernel.org" <dsahern@kernel.org>,
"kuba@kernel.org" <kuba@kernel.org>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"horms@kernel.org" <horms@kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>
Subject: Re: [RFC blktests fix PATCH] tcp: use GFP_ATOMIC in tcp_disconnect
Date: Tue, 25 Nov 2025 12:30:09 +0100 [thread overview]
Message-ID: <20251125113009.GA22874@lst.de> (raw)
In-Reply-To: <234bab6c-6d31-4c93-8a69-5b3687ba9b85@linux.ibm.com>
On Tue, Nov 25, 2025 at 04:58:32PM +0530, Nilay Shroff wrote:
> >From git history, I see that was added to avoid memory reclaim to avoid
> possible circular locking dependency. This commit 83e1226b0ee2 ("nvme-tcp:
> fix possible circular locking when deleting a controller under memory
> pressure") adds it.
I suspect this was intended to be noio, and we should just switch to
that.
next prev parent reply other threads:[~2025-11-25 11:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-25 6:11 [RFC blktests fix PATCH] tcp: use GFP_ATOMIC in tcp_disconnect Chaitanya Kulkarni
2025-11-25 6:27 ` Christoph Hellwig
2025-11-25 7:28 ` Chaitanya Kulkarni
2025-11-25 11:08 ` hch
2025-11-25 11:13 ` Nilay Shroff
2025-11-25 11:21 ` hch
2025-11-25 11:28 ` Nilay Shroff
2025-11-25 11:30 ` Christoph Hellwig [this message]
2025-11-25 11:54 ` Nilay Shroff
2025-11-25 12:33 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251125113009.GA22874@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=bmarzins@redhat.com \
--cc=chaitanyak@nvidia.com \
--cc=ckulkarnilinux@gmail.com \
--cc=davem@davemloft.net \
--cc=dlemoal@kernel.org \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=hare@suse.de \
--cc=horms@kernel.org \
--cc=john.g.garry@oracle.com \
--cc=kbusch@kernel.org \
--cc=kuba@kernel.org \
--cc=kuniyu@google.com \
--cc=linan122@huawei.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=mpatocka@redhat.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=nilay@linux.ibm.com \
--cc=pabeni@redhat.com \
--cc=sagi@grimberg.me \
--cc=wagi@kernel.org \
--cc=xni@redhat.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).