From: Vladimir Oltean <olteanv@gmail.com>
To: David Yang <mmyangfl@gmail.com>
Cc: netdev@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
Russell King <linux@armlinux.org.uk>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v3 3/4] net: dsa: yt921x: Add HSR offloading support
Date: Wed, 26 Nov 2025 18:26:54 +0200 [thread overview]
Message-ID: <20251126162654.ajcwikzh4vijspxf@skbuf> (raw)
In-Reply-To: <20251126093240.2853294-4-mmyangfl@gmail.com>
On Wed, Nov 26, 2025 at 05:32:36PM +0800, David Yang wrote:
> Add offloading for packet duplication supported by the YT921x switches.
>
> Signed-off-by: David Yang <mmyangfl@gmail.com>
> ---
I like the idea behind this patch from a purely technical perspective,
but there's an important question. Do you, or people you know or have
interacted with, use HSR/PRP on the YT921x switches, in order to find
this change useful?
If NETIF_F_HW_HSR_DUP is the only offload that the switch supports, then
one can hardly say that the switch was designed to be an HSR accelerator.
I'm working on some patches to make this feature generically available
to most DSA switch drivers, rather than being arbitrarily implemented
here and there. The usefulness of having this single offload generally
available is where I am lacking some data points.
next prev parent reply other threads:[~2025-11-26 16:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-26 9:32 [PATCH net-next v3 0/4] net: dsa: yt921x: Add STP/MST/HSR/LAG support David Yang
2025-11-26 9:32 ` [PATCH net-next v3 1/4] net: dsa: yt921x: Use *_ULL bitfield macros for VLAN_CTRL David Yang
2025-11-28 1:58 ` Jakub Kicinski
2025-11-28 10:51 ` david laight
2025-11-28 11:43 ` Russell King (Oracle)
2025-11-28 19:25 ` david laight
2025-11-26 9:32 ` [PATCH net-next v3 2/4] net: dsa: yt921x: Add STP/MST support David Yang
2025-11-26 9:32 ` [PATCH net-next v3 3/4] net: dsa: yt921x: Add HSR offloading support David Yang
2025-11-26 16:26 ` Vladimir Oltean [this message]
2025-11-26 9:32 ` [PATCH net-next v3 4/4] net: dsa: yt921x: Add LAG " David Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251126162654.ajcwikzh4vijspxf@skbuf \
--to=olteanv@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mmyangfl@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox