From: Jakub Kicinski <kuba@kernel.org>
To: Wen Gu <guwen@linux.alibaba.com>
Cc: richardcochran@gmail.com, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
xuanzhuo@linux.alibaba.com, dust.li@linux.alibaba.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v5 1/2] ptp: introduce Alibaba CIPU PHC driver
Date: Thu, 27 Nov 2025 08:36:10 -0800 [thread overview]
Message-ID: <20251127083610.6b66a728@kernel.org> (raw)
In-Reply-To: <34b30157-6d67-46ec-abde-da9087fbf318@linux.alibaba.com>
On Thu, 27 Nov 2025 13:48:47 +0800 Wen Gu wrote:
> > We can't delete existing drivers. It used to be far less annoying
> > until every cloud vendor under the sun decided to hack up their own
> > implementation of something as simple as the clock.
>
> So what kind of drivers do you think are qualified to be placed in the
> drivers/ptp? I checked some docs, e.g.[1], and codes in drivers/ptp,
> but I am not sure what the deciding factor is, assuming that exposing
> a PTP character device is not sufficient.
>
> [1] https://docs.kernel.org/driver-api/ptp.html
Networking ones? I don't have a great answer. My point is basically
that we are networking maintainers. I have a good understanding of PTP
(the actual protocol) and TSN as these are networking technologies.
But I don't feel qualified to review purely time / clock related code.
I don't even know the UNIX/Linux clock API very well.
Sorry to put you in this position but the VM clocks should have some
other tree. Or at the very least some clock expert needs to review them.
Could you go complain to clock people? Or virtualization people?
next prev parent reply other threads:[~2025-11-27 16:36 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-30 12:13 [PATCH net-next v5 0/2] ptp: Alibaba CIPU PTP clock driver Wen Gu
2025-10-30 12:13 ` [PATCH net-next v5 1/2] ptp: introduce Alibaba CIPU PHC driver Wen Gu
2025-10-31 23:58 ` Jakub Kicinski
2025-11-05 10:22 ` Wen Gu
2025-11-06 0:24 ` Jakub Kicinski
2025-11-27 5:48 ` Wen Gu
2025-11-27 16:36 ` Jakub Kicinski [this message]
2025-11-28 6:22 ` Wen Gu
2025-11-28 18:24 ` Jakub Kicinski
2025-12-01 6:04 ` Wen Gu
2025-12-12 6:50 ` Wen Gu
2025-12-12 22:50 ` Jakub Kicinski
2025-12-14 14:03 ` Wen Gu
2025-12-16 21:58 ` Jakub Kicinski
2025-12-17 12:40 ` Wen Gu
2025-12-22 7:18 ` Wen Gu
2025-12-18 12:28 ` David Woodhouse
2025-12-22 12:44 ` Wen Gu
2025-10-30 12:13 ` [PATCH net-next v5 2/2] ptp: add sysfs documentation for " Wen Gu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251127083610.6b66a728@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=dust.li@linux.alibaba.com \
--cc=edumazet@google.com \
--cc=guwen@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).