From: Jakub Kicinski <kuba@kernel.org>
To: Andre Carvalho <asantostc@gmail.com>
Cc: Breno Leitao <leitao@debian.org>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Shuah Khan <shuah@kernel.org>,
Simon Horman <horms@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net-next v7 0/5] netconsole: support automatic target recovery
Date: Thu, 27 Nov 2025 16:47:48 -0800 [thread overview]
Message-ID: <20251127164748.4db1e1fe@kernel.org> (raw)
In-Reply-To: <v44skio47zulg6jok5wq7w2ylw4abk7dxtjarlgnuz7hukvbts@7clzpd7cqc5u>
On Thu, 27 Nov 2025 23:07:02 +0000 Andre Carvalho wrote:
> > Should we not be listening for the REGISTER event then? On boot
> > we force UP the device if we find it, theoretically there may
> > be a case where user space is not configured to UP the device,
> > and then we'd never resume the target?
>
> This is indeed a limitation on the current implementation. Based on
> your feedback, I'm working on a new version of this series handling REGISTER
> instead of UP and ensuring we force UP the device.
> This will make it consistent with the boot behavior you described.
>
> Based on my tests, I can't force the device UP while handling the REGISTER event.
> I believe this is due to dev_open attempting to lock the device which is already held.
> For this reason, I'm resorting to defering this to a workqueue, similar to my approach
> on v1 [1] (but correctly handling target_list lock).
>
> Let me know if this approach makes sense or if I'm missing something.
SG, that's probably the most resilient solution.
prev parent reply other threads:[~2025-11-28 0:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-26 20:22 [PATCH net-next v7 0/5] netconsole: support automatic target recovery Andre Carvalho
2025-11-26 20:22 ` [PATCH net-next v7 1/5] netconsole: add target_state enum Andre Carvalho
2025-11-26 20:22 ` [PATCH net-next v7 2/5] netconsole: convert 'enabled' flag to enum for clearer state management Andre Carvalho
2025-11-26 20:22 ` [PATCH net-next v7 3/5] netconsole: add STATE_DEACTIVATED to track targets disabled by low level Andre Carvalho
2025-11-26 20:22 ` [PATCH net-next v7 4/5] netconsole: resume previously deactivated target Andre Carvalho
2025-11-26 20:22 ` [PATCH net-next v7 5/5] selftests: netconsole: validate target resume Andre Carvalho
2025-11-27 1:36 ` [PATCH net-next v7 0/5] netconsole: support automatic target recovery Jakub Kicinski
2025-11-27 23:07 ` Andre Carvalho
2025-11-28 0:47 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251127164748.4db1e1fe@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=asantostc@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).