From: Jakub Kicinski <kuba@kernel.org>
To: "Russell King (Oracle)" <linux@armlinux.org.uk>
Cc: Andrew Lunn <andrew@lunn.ch>,
Oleksij Rempel <o.rempel@pengutronix.de>,
Vladimir Oltean <vladimir.oltean@nxp.com>,
Alexei Starovoitov <ast@kernel.org>,
Eric Dumazet <edumazet@google.com>, Rob Herring <robh@kernel.org>,
Florian Fainelli <f.fainelli@gmail.com>,
Donald Hunter <donald.hunter@gmail.com>,
Daniel Borkmann <daniel@iogearbox.net>,
Jonathan Corbet <corbet@lwn.net>,
John Fastabend <john.fastabend@gmail.com>,
Lukasz Majewski <lukma@denx.de>,
Maxime Chevallier <maxime.chevallier@bootlin.com>,
Stanislav Fomichev <sdf@fomichev.me>,
Paolo Abeni <pabeni@redhat.com>, Jiri Pirko <jiri@resnulli.us>,
Jesper Dangaard Brouer <hawk@kernel.org>,
Divya.Koppera@microchip.com,
Kory Maincent <kory.maincent@bootlin.com>,
Vadim Fedorenko <vadim.fedorenko@linux.dev>,
netdev@vger.kernel.org, Sabrina Dubroca <sd@queasysnail.net>,
linux-kernel@vger.kernel.org, kernel@pengutronix.de,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Heiner Kallweit <hkallweit1@gmail.com>
Subject: Re: [PATCH net-next v8 1/1] Documentation: net: add flow control guide and document ethtool API
Date: Thu, 27 Nov 2025 17:21:39 -0800 [thread overview]
Message-ID: <20251127172139.5b4c34d0@kernel.org> (raw)
In-Reply-To: <aSh411Hogj3O4VT5@shell.armlinux.org.uk>
On Thu, 27 Nov 2025 16:14:15 +0000 Russell King (Oracle) wrote:
> > > * **Constraint Checking:**
> > > * Drivers should reject a non-zero setting of @autoneg when
> > > * autonegotiation is disabled (or not supported) for the link.
> > > * Drivers should reject unsupported rx/tx combinations with -EINVAL.
>
> Definitely not. Drivers should accept autoneg=1 because that is the
> user stating "my desire is to use the result of autonegotiation when
> it becomes available". Just because autoneg may be disabled doesn't
> mean it will remain disabled, and having to issue ethtool commands
> in the right sequence leads to poor user experiences.
It's an existing recommendation, coming from 6a7a1081cebacc4.
I thought it's just because of the ambiguity what the settings mean
with autoneg on or off. But looks like Ben has been trying to push
people towards link mode bits 11 years ago already :(
next prev parent reply other threads:[~2025-11-28 1:21 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-19 14:03 [PATCH net-next v8 1/1] Documentation: net: add flow control guide and document ethtool API Oleksij Rempel
2025-11-26 2:19 ` Jakub Kicinski
2025-11-26 8:36 ` Oleksij Rempel
2025-11-26 22:42 ` Jakub Kicinski
2025-11-27 9:20 ` Oleksij Rempel
2025-11-27 15:07 ` Andrew Lunn
2025-11-27 15:31 ` Maxime Chevallier
2025-11-27 15:48 ` Andrew Lunn
2025-11-27 16:18 ` Russell King (Oracle)
2025-11-27 16:14 ` Russell King (Oracle)
2025-11-28 1:21 ` Jakub Kicinski [this message]
2025-11-27 16:10 ` Russell King (Oracle)
2025-11-28 1:27 ` Russell King (Oracle)
2025-11-28 1:47 ` Russell King (Oracle)
2025-11-28 8:55 ` Oleksij Rempel
2025-11-28 9:35 ` Russell King (Oracle)
2025-11-28 18:32 ` Jakub Kicinski
2025-11-28 20:16 ` Andrew Lunn
2025-11-28 20:38 ` Russell King (Oracle)
2025-11-28 22:17 ` Jakub Kicinski
2025-12-01 9:49 ` Oleksij Rempel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251127172139.5b4c34d0@kernel.org \
--to=kuba@kernel.org \
--cc=Divya.Koppera@microchip.com \
--cc=andrew@lunn.ch \
--cc=ast@kernel.org \
--cc=corbet@lwn.net \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=hawk@kernel.org \
--cc=hkallweit1@gmail.com \
--cc=jiri@resnulli.us \
--cc=john.fastabend@gmail.com \
--cc=kernel@pengutronix.de \
--cc=kory.maincent@bootlin.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lukma@denx.de \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
--cc=sd@queasysnail.net \
--cc=sdf@fomichev.me \
--cc=vadim.fedorenko@linux.dev \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).