netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Simon Horman <horms@kernel.org>
To: Carolina Jubran <cjubran@nvidia.com>
Cc: Jakub Kicinski <kuba@kernel.org>, Shuah Khan <shuah@kernel.org>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S . Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Paolo Abeni <pabeni@redhat.com>, Gal Pressman <gal@nvidia.com>,
	Tariq Toukan <tariqt@nvidia.com>,
	Cosmin Ratiu <cratiu@nvidia.com>, Nimrod Oren <noren@nvidia.com>,
	Mark Bloch <mbloch@nvidia.com>,
	linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
	netdev@vger.kernel.org
Subject: Re: [PATCH net-next V2 0/6] selftests: drv-net: Fix issues in devlink_rate_tc_bw.py
Date: Thu, 27 Nov 2025 20:06:31 +0000	[thread overview]
Message-ID: <20251127200631.GA737230@horms.kernel.org> (raw)
In-Reply-To: <d81820e1-21e0-4c59-8532-ba55ac47c6fd@nvidia.com>

On Wed, Nov 26, 2025 at 10:06:18AM +0200, Carolina Jubran wrote:
> 
> On 25/11/2025 5:10, Jakub Kicinski wrote:
> > On Sun, 23 Nov 2025 19:10:09 +0200 Carolina Jubran wrote:
> > > This series fixes issues in the devlink_rate_tc_bw.py selftest and
> > > introduces a new Iperf3Runner that helps with measurement handling.
> > Sorry to report but patch 2 doesn't apply cleanly.
> 
> 
> I am based on top of net-next, and I do not see any issues applying the
> series. I rebased on top of commit ab084f0b8d6d2ee4b1c6a28f39a2a7430bdfa7f0
> and patch 2 still applies cleanly for me.
> 
> I’ll prepare a v3 to fix the new pylint warnings in load.py while I’m at
> it.
> 
> If you are applying it on a different base, please let me know which
> one.

Hi Carolina,

FWIIW, I do see that b4 shazam (which I assume runs git am) is unable to
apply this series cleanly to ab084f0b8d6d2ee4b1c6a28f39a2a7430bdfa7f0 due
to some fuzz when applying the first patch: Hunk #1 of
tools/testing/selftests/drivers/net/hw/lib/py/__init__.py

And I expect that a rebase figures this out, which is why you
aren't seeing it.

      reply	other threads:[~2025-11-27 20:06 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-23 17:10 [PATCH net-next V2 0/6] selftests: drv-net: Fix issues in devlink_rate_tc_bw.py Carolina Jubran
2025-11-23 17:10 ` [PATCH net-next V2 1/6] selftests: drv-net: Add devlink_rate_tc_bw.py to TEST_PROGS Carolina Jubran
2025-11-23 17:10 ` [PATCH net-next V2 2/6] selftests: drv-net: introduce Iperf3Runner for measurement use cases Carolina Jubran
2025-11-23 17:10 ` [PATCH net-next V2 3/6] selftests: drv-net: Use Iperf3Runner in devlink_rate_tc_bw.py Carolina Jubran
2025-11-23 17:10 ` [PATCH net-next V2 4/6] selftests: drv-net: Set shell=True for sysfs writes " Carolina Jubran
2025-11-23 17:10 ` [PATCH net-next V2 5/6] selftests: drv-net: Fix and clarify TC bandwidth split " Carolina Jubran
2025-11-23 17:10 ` [PATCH net-next V2 6/6] selftests: drv-net: Fix tolerance calculation " Carolina Jubran
2025-11-25  3:10 ` [PATCH net-next V2 0/6] selftests: drv-net: Fix issues " Jakub Kicinski
2025-11-26  8:06   ` Carolina Jubran
2025-11-27 20:06     ` Simon Horman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251127200631.GA737230@horms.kernel.org \
    --to=horms@kernel.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=cjubran@nvidia.com \
    --cc=cratiu@nvidia.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=gal@nvidia.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=mbloch@nvidia.com \
    --cc=netdev@vger.kernel.org \
    --cc=noren@nvidia.com \
    --cc=pabeni@redhat.com \
    --cc=shuah@kernel.org \
    --cc=tariqt@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).