From: Stephen Hemminger <stephen@networkplumber.org>
To: Vincent Mailhol <mailhol@kernel.org>
Cc: netdev@vger.kernel.org, Marc Kleine-Budde <mkl@pengutronix.de>,
Oliver Hartkopp <socketcan@hartkopp.net>,
David Ahern <dsahern@kernel.org>,
linux-kernel@vger.kernel.org, linux-can@vger.kernel.org
Subject: Re: [PATCH 4/7] iplink_can: add the "restricted" option
Date: Sat, 29 Nov 2025 09:03:20 -0800 [thread overview]
Message-ID: <20251129090320.594aa81a@phoenix.local> (raw)
In-Reply-To: <20251129-canxl-netlink-v1-4-96f2c0c54011@kernel.org>
On Sat, 29 Nov 2025 16:29:09 +0100
Vincent Mailhol <mailhol@kernel.org> wrote:
> @@ -257,6 +259,9 @@ static int can_parse_opt(struct link_util *lu, int argc, char **argv,
> invarg("\"tdc-mode\" must be either of \"auto\", \"manual\" or \"off\"",
> *argv);
> }
> + } else if (matches(*argv, "restricted") == 0) {
> + NEXT_ARG();
> + set_ctrlmode("restricted", *argv, &cm, CAN_CTRLMODE_RESTRICTED);
> } else if (matches(*argv, "restart") == 0) {
> __u32 val = 1;
Good example of iproute2 has banned use of matches. Because usage like the
(think of what happens when user was previously using 'r')
next prev parent reply other threads:[~2025-11-29 17:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-29 15:29 [PATCH 0/7] iplink_can: add CAN XL support Vincent Mailhol
2025-11-29 15:29 ` [PATCH 1/7] iplink_can: print_usage: fix the text indentation Vincent Mailhol
2025-11-29 15:29 ` [PATCH 2/7] iplink_can: print_usage: change unit for minimum time quanta to mtq Vincent Mailhol
2025-11-29 15:29 ` [PATCH 3/7] iplink_can: print_usage: describe the CAN bittiming units Vincent Mailhol
2025-11-29 15:29 ` [PATCH 4/7] iplink_can: add the "restricted" option Vincent Mailhol
2025-11-29 17:03 ` Stephen Hemminger [this message]
2025-11-29 15:29 ` [PATCH 5/7] iplink_can: add initial CAN XL support Vincent Mailhol
2025-11-29 17:04 ` Stephen Hemminger
2025-11-29 23:13 ` Vincent Mailhol
2025-11-29 15:29 ` [PATCH 6/7] iplink_can: add CAN XL's "tms" option Vincent Mailhol
2025-11-29 17:21 ` Oliver Hartkopp
2025-11-29 23:16 ` Vincent Mailhol
2025-11-29 15:29 ` [PATCH 7/7] iplink_can: add CAN XL's PWM interface Vincent Mailhol
2025-11-29 17:26 ` Oliver Hartkopp
2025-11-29 15:38 ` [PATCH 0/7] iplink_can: add CAN XL support Vincent Mailhol
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251129090320.594aa81a@phoenix.local \
--to=stephen@networkplumber.org \
--cc=dsahern@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mailhol@kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=socketcan@hartkopp.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).