From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: netdev@vger.kernel.org, Yehezkel Bernat <YehezkelShB@gmail.com>,
Ian MacDonald <ian@netstatz.com>,
Salvatore Bonaccorso <carnil@debian.org>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH net-next 3/3] net: thunderbolt: Allow reading link settings
Date: Mon, 1 Dec 2025 07:19:22 +0100 [thread overview]
Message-ID: <20251201061922.GC2580184@black.igk.intel.com> (raw)
In-Reply-To: <e4f3eefa-9a01-413d-9ba6-ec9ebc381061@lunn.ch>
On Fri, Nov 28, 2025 at 03:57:07PM +0100, Andrew Lunn wrote:
> > > Please add SPEED_80000.
> >
> > Sure. One additional question though. Comment on top of SPEED_ definitions
> > suggest changing __get_link_speed() of the bonding driver accordingly but
> > it basically converts from SPEED_ to AD_LINK_SPEED_ which I think we need
> > to add too. However, these are user-facing values so should I add the
> > AD_LINK_SPEED_80000 entry to the end of that enum to avoid any possible
> > breakage?
>
> Are they user facing? They should be define in include/uapi if they
> were. I would keep the list sorted, and Cc: the bonding driver
> Maintainer, Jay Vosburgh <jv@jvosburgh.net> (maintainer:BONDING DRIVER).
Indeed, they look like they are not. As you pointed out these are internals
of the drivers/net/bonding/bond_3ad.c and not exposed as is to the
userspace.
I'll add the 80G there for both of these in v2 and Cd Jay just in case.
Since merge window is open I'll send v2 after v6.19-rc1 is released.
prev parent reply other threads:[~2025-12-01 6:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-27 13:15 [PATCH net-next 0/3] net: thunderbolt: Various improvements Mika Westerberg
2025-11-27 13:15 ` [PATCH net-next 1/3] net: thunderbolt: Allow changing MAC address of the device Mika Westerberg
2025-11-27 13:15 ` [PATCH net-next 2/3] net: thunderbolt: Allow changing MTU " Mika Westerberg
2025-11-27 13:15 ` [PATCH net-next 3/3] net: thunderbolt: Allow reading link settings Mika Westerberg
2025-11-27 19:20 ` Andrew Lunn
2025-11-28 7:23 ` Mika Westerberg
2025-11-28 14:57 ` Andrew Lunn
2025-12-01 6:19 ` Mika Westerberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251201061922.GC2580184@black.igk.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=YehezkelShB@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=carnil@debian.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=ian@netstatz.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).