From: Christoph Hellwig <hch@lst.de>
To: alistair23@gmail.com
Cc: chuck.lever@oracle.com, hare@kernel.org,
kernel-tls-handshake@lists.linux.dev, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
linux-nvme@lists.infradead.org, linux-nfs@vger.kernel.org,
kbusch@kernel.org, axboe@kernel.dk, hch@lst.de, sagi@grimberg.me,
kch@nvidia.com, hare@suse.de,
Alistair Francis <alistair.francis@wdc.com>
Subject: Re: [PATCH v6 4/5] nvme-tcp: Support KeyUpdate
Date: Tue, 2 Dec 2025 07:02:26 +0100 [thread overview]
Message-ID: <20251202060226.GA16055@lst.de> (raw)
In-Reply-To: <20251202013429.1199659-5-alistair.francis@wdc.com>
On Tue, Dec 02, 2025 at 11:34:28AM +1000, alistair23@gmail.com wrote:
> + if (unlikely(ret < 0)) {
> + goto msg_control;
> }
This should drop the superfluous braces.
Otherwise looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2025-12-02 6:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-02 1:34 [PATCH v6 0/5] nvme-tcp: Support receiving KeyUpdate requests alistair23
2025-12-02 1:34 ` [PATCH v6 1/5] net/handshake: Store the key serial number on completion alistair23
2025-12-02 18:29 ` Jakub Kicinski
2025-12-02 1:34 ` [PATCH v6 2/5] net/handshake: Define handshake_req_keyupdate alistair23
2025-12-02 13:49 ` Chuck Lever
2025-12-02 15:34 ` Hannes Reinecke
2025-12-02 1:34 ` [PATCH v6 3/5] net/handshake: Support KeyUpdate message types alistair23
2025-12-02 1:34 ` [PATCH v6 4/5] nvme-tcp: Support KeyUpdate alistair23
2025-12-02 6:02 ` Christoph Hellwig [this message]
2025-12-02 1:34 ` [PATCH v6 5/5] nvmet-tcp: " alistair23
2025-12-02 6:02 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251202060226.GA16055@lst.de \
--to=hch@lst.de \
--cc=alistair.francis@wdc.com \
--cc=alistair23@gmail.com \
--cc=axboe@kernel.dk \
--cc=chuck.lever@oracle.com \
--cc=hare@kernel.org \
--cc=hare@suse.de \
--cc=kbusch@kernel.org \
--cc=kch@nvidia.com \
--cc=kernel-tls-handshake@lists.linux.dev \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).