netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Jiri Pirko <jiri@resnulli.us>
Cc: Tariq Toukan <tariqt@nvidia.com>,
	Eric Dumazet <edumazet@google.com>,
	Paolo Abeni <pabeni@redhat.com>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Donald Hunter <donald.hunter@gmail.com>,
	Jonathan Corbet <corbet@lwn.net>,
	Saeed Mahameed <saeedm@nvidia.com>,
	Leon Romanovsky <leon@kernel.org>, Mark Bloch <mbloch@nvidia.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-doc@vger.kernel.org, linux-rdma@vger.kernel.org,
	Gal Pressman <gal@nvidia.com>, Moshe Shemesh <moshe@nvidia.com>,
	Carolina Jubran <cjubran@nvidia.com>,
	Cosmin Ratiu <cratiu@nvidia.com>, Jiri Pirko <jiri@nvidia.com>,
	Randy Dunlap <rdunlap@infradead.org>
Subject: Re: [PATCH net-next V4 02/14] documentation: networking: add shared devlink documentation
Date: Tue, 2 Dec 2025 10:14:44 -0800	[thread overview]
Message-ID: <20251202101444.7f6d14a8@kernel.org> (raw)
In-Reply-To: <2lnqrb3fu7dukdkgfculj53q2vwb36nrz5copjfg3khlqnbmix@jbfmhnks7svq>

On Tue, 2 Dec 2025 08:43:49 +0100 Jiri Pirko wrote:
> Mon, Dec 01, 2025 at 10:49:54PM +0100, kuba@kernel.org wrote:
> >On Mon, 1 Dec 2025 11:50:08 +0100 Jiri Pirko wrote:  
> >> Correct. IFAIK there is one PF devlink instance per NUMA node.  
> >
> >You say "correct" and then disagree with what I'm saying. I said
> >ports because a port is a devlink object. Not a devlink instance.  
> 
> Okay, you mean devlink_port. You would like to see NUMA node leg as
> devlink_port? Having troubles to undestand exactly what you mean, lot of
> guessing on my side. Probably I'm slow, sorry.
> 
> But there is a PCI device per NUMA node leg. Not sure how to model it.
> Devink instances have 1:1 relationship with bus devices.
> 
> Care to draw a picture perhaps?
> 
> >> The shared instance on top would make sense to me. That was one of
> >> motivations to introduce it. Then this shared instance would hold
> >> netdev, vf representors etc.  
> >
> >I don't understand what the shared instance is representing and how
> >user is expect to find their way thru the maze of devlink instanced,
> >for real bus, aux bus, and now shared instanced.  
> 
> Well, I tried to desrtibe it in the documentation path, Not sure what is
> not clear :/
> 
> Nested devlinks expose the connections between devlink instances.

To be clear -- I understand how you're laying things out. My point is
not about that. My question is how can user make intuitive sense of this
mess of random object floating around. Every SW engineering problem can
be solved by another layer of abstraction, that's not the challenge. 
The challenge is to design those layers so that they make intuitive
sense (to people who don't spend their life programming against mlx FW
interfaces).

  reply	other threads:[~2025-12-02 18:14 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-25 20:05 [PATCH net-next V4 00/14] devlink and mlx5: Support cross-function rate scheduling Tariq Toukan
2025-11-25 20:06 ` [PATCH net-next V4 01/14] devlink: Reverse locking order for nested instances Tariq Toukan
2025-11-25 20:06 ` [PATCH net-next V4 02/14] documentation: networking: add shared devlink documentation Tariq Toukan
2025-11-28  4:16   ` Jakub Kicinski
2025-11-28 11:00     ` Jiri Pirko
2025-11-29  3:19       ` Jakub Kicinski
2025-12-01 10:50         ` Jiri Pirko
2025-12-01 21:49           ` Jakub Kicinski
2025-12-02  7:43             ` Jiri Pirko
2025-12-02 18:14               ` Jakub Kicinski [this message]
2025-12-03 10:36                 ` Jiri Pirko
2025-12-04 18:57                   ` Jakub Kicinski
2025-12-05  9:39                     ` Jiri Pirko
2025-11-25 20:06 ` [PATCH net-next V4 03/14] devlink: Add helpers to lock nested-in instances Tariq Toukan
2025-11-25 20:06 ` [PATCH net-next V4 04/14] devlink: Refactor devlink_rate_nodes_check Tariq Toukan
2025-11-25 20:06 ` [PATCH net-next V4 05/14] devlink: Decouple rate storage from associated devlink object Tariq Toukan
2025-11-25 20:06 ` [PATCH net-next V4 06/14] devlink: Add parent dev to devlink API Tariq Toukan
2025-11-27 15:28   ` Simon Horman
2025-11-27 19:18     ` Cosmin Ratiu
2025-11-25 20:06 ` [PATCH net-next V4 07/14] devlink: Allow parent dev for rate-set and rate-new Tariq Toukan
2025-11-25 20:06 ` [PATCH net-next V4 08/14] devlink: Allow rate node parents from other devlinks Tariq Toukan
2025-11-28  4:09   ` Jakub Kicinski
2025-11-28  9:57     ` Cosmin Ratiu
2025-11-25 20:06 ` [PATCH net-next V4 09/14] net/mlx5: Introduce shared devlink instance for PFs on same chip Tariq Toukan
2025-11-29 14:08   ` Krzysztof Kozlowski
2025-11-25 20:06 ` [PATCH net-next V4 10/14] net/mlx5: Expose a function to clear a vport's parent Tariq Toukan
2025-11-25 20:06 ` [PATCH net-next V4 11/14] net/mlx5: Store QoS sched nodes in the sh_devlink Tariq Toukan
2025-11-25 20:06 ` [PATCH net-next V4 12/14] net/mlx5: qos: Support cross-device tx scheduling Tariq Toukan
2025-11-25 20:06 ` [PATCH net-next V4 13/14] net/mlx5: qos: Enable cross-device scheduling Tariq Toukan
2025-11-25 20:06 ` [PATCH net-next V4 14/14] net/mlx5: Document devlink rates Tariq Toukan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251202101444.7f6d14a8@kernel.org \
    --to=kuba@kernel.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=cjubran@nvidia.com \
    --cc=corbet@lwn.net \
    --cc=cratiu@nvidia.com \
    --cc=davem@davemloft.net \
    --cc=donald.hunter@gmail.com \
    --cc=edumazet@google.com \
    --cc=gal@nvidia.com \
    --cc=jiri@nvidia.com \
    --cc=jiri@resnulli.us \
    --cc=leon@kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=mbloch@nvidia.com \
    --cc=moshe@nvidia.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=rdunlap@infradead.org \
    --cc=saeedm@nvidia.com \
    --cc=tariqt@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).