* Please apply 5b1e38c0792cc7a44997328de37d393f81b2501a to 5.15
@ 2025-12-04 0:25 Nathan Chancellor
2025-12-07 0:38 ` Sasha Levin
0 siblings, 1 reply; 2+ messages in thread
From: Nathan Chancellor @ 2025-12-04 0:25 UTC (permalink / raw)
To: Greg Kroah-Hartman, Sasha Levin; +Cc: stable, netdev, Ioana Ciornei
Hi stable folks,
Please apply commit 5b1e38c0792c ("dpaa2-mac: bail if the dpmacs fwnode
is not found") to 5.15, where it addresses an instance of
-Wsometimes-uninitialized with clang-21 and newer, introduced by commit
3264f599c1a8 ("net: dpaa2-mac: Add ACPI support for DPAA2 MAC driver")
in 5.14.
drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c:54:13: error: variable 'parent' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized]
54 | } else if (is_acpi_node(fwnode)) {
| ^~~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c:58:29: note: uninitialized use occurs here
58 | fwnode_for_each_child_node(parent, child) {
| ^~~~~~
drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c:54:9: note: remove the 'if' if its condition is always true
54 | } else if (is_acpi_node(fwnode)) {
| ^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c:43:39: note: initialize the variable 'parent' to silence this warning
43 | struct fwnode_handle *fwnode, *parent, *child = NULL;
| ^
| = NULL
It applies and builds cleanly for me. If there are any issues, please
let me know.
Cheers,
Nathan
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Please apply 5b1e38c0792cc7a44997328de37d393f81b2501a to 5.15
2025-12-04 0:25 Please apply 5b1e38c0792cc7a44997328de37d393f81b2501a to 5.15 Nathan Chancellor
@ 2025-12-07 0:38 ` Sasha Levin
0 siblings, 0 replies; 2+ messages in thread
From: Sasha Levin @ 2025-12-07 0:38 UTC (permalink / raw)
To: Nathan Chancellor; +Cc: Greg Kroah-Hartman, stable, netdev, Ioana Ciornei
On Wed, Dec 03, 2025 at 05:25:17PM -0700, Nathan Chancellor wrote:
>Hi stable folks,
>
>Please apply commit 5b1e38c0792c ("dpaa2-mac: bail if the dpmacs fwnode
>is not found") to 5.15, where it addresses an instance of
>-Wsometimes-uninitialized with clang-21 and newer, introduced by commit
>3264f599c1a8 ("net: dpaa2-mac: Add ACPI support for DPAA2 MAC driver")
>in 5.14.
>
> drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c:54:13: error: variable 'parent' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized]
> 54 | } else if (is_acpi_node(fwnode)) {
> | ^~~~~~~~~~~~~~~~~~~~
> drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c:58:29: note: uninitialized use occurs here
> 58 | fwnode_for_each_child_node(parent, child) {
> | ^~~~~~
> drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c:54:9: note: remove the 'if' if its condition is always true
> 54 | } else if (is_acpi_node(fwnode)) {
> | ^~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c:43:39: note: initialize the variable 'parent' to silence this warning
> 43 | struct fwnode_handle *fwnode, *parent, *child = NULL;
> | ^
> | = NULL
>
>It applies and builds cleanly for me. If there are any issues, please
>let me know.
Queued up, thanks.
--
Thanks,
Sasha
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-12-07 0:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-04 0:25 Please apply 5b1e38c0792cc7a44997328de37d393f81b2501a to 5.15 Nathan Chancellor
2025-12-07 0:38 ` Sasha Levin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).