From: Guenter Roeck <linux@roeck-us.net>
To: Shuah Khan <shuah@kernel.org>
Cc: Christian Brauner <brauner@kernel.org>,
Elizabeth Figura <zfigura@codeweavers.com>,
Thomas Gleixner <tglx@linutronix.de>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Kees Cook <kees@kernel.org>,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
wine-devel@winehq.org, netdev@vger.kernel.org,
bpf@vger.kernel.org, Guenter Roeck <linux@roeck-us.net>
Subject: [PATCH 08/13] selftests: net: netlink-dumps: Avoid uninitialized variable error
Date: Thu, 4 Dec 2025 08:17:22 -0800 [thread overview]
Message-ID: <20251204161729.2448052-9-linux@roeck-us.net> (raw)
In-Reply-To: <20251204161729.2448052-1-linux@roeck-us.net>
Building netlink-dumps with -Werror results in
netlink-dumps.c: In function ‘dump_extack’:
../kselftest_harness.h:788:35: error: ‘ret’ may be used uninitialized
Problem is that the loop which initializes 'ret' may exit early without
initializing the variable if recv() returns an error. Always initialize
'ret' to solve the problem.
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
tools/testing/selftests/net/netlink-dumps.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/net/netlink-dumps.c b/tools/testing/selftests/net/netlink-dumps.c
index 7618ebe528a4..f4fc0c9910f2 100644
--- a/tools/testing/selftests/net/netlink-dumps.c
+++ b/tools/testing/selftests/net/netlink-dumps.c
@@ -112,7 +112,7 @@ static const struct {
TEST(dump_extack)
{
int netlink_sock;
- int i, cnt, ret;
+ int i, cnt, ret = FOUND_ERR;
char buf[8192];
int one = 1;
ssize_t n;
--
2.43.0
next prev parent reply other threads:[~2025-12-04 16:17 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-04 16:17 [PATCH 00/13] selftests: Fix problems seen when building with -Werror Guenter Roeck
2025-12-04 16:17 ` [PATCH 01/13] clone3: clone3_cap_checkpoint_restore: Fix build errors seen " Guenter Roeck
2025-12-04 16:17 ` [PATCH 02/13] selftests: ntsync: Fix build errors -seen " Guenter Roeck
2025-12-04 16:17 ` [PATCH 03/13] selftests/filesystems: fclog: Fix build errors seen " Guenter Roeck
2025-12-04 16:17 ` [PATCH 04/13] selftests/filesystems: file_stressor: Fix build error " Guenter Roeck
2025-12-04 16:17 ` [PATCH 05/13] selftests/filesystems: anon_inode_test: " Guenter Roeck
2025-12-04 16:17 ` [PATCH 06/13] selftest: af_unix: Support compilers without flex-array-member-not-at-end support Guenter Roeck
2025-12-04 17:40 ` Jakub Kicinski
2025-12-04 17:58 ` Guenter Roeck
2025-12-04 16:17 ` [PATCH 07/13] selftest/futex: Comment out test_futex_mpol Guenter Roeck
2025-12-04 16:17 ` Guenter Roeck [this message]
2025-12-04 16:17 ` [PATCH 09/13] selftests/seccomp: Fix build error seen with -Werror Guenter Roeck
2025-12-04 16:17 ` [PATCH 10/13] selftests: net: Work around " Guenter Roeck
2025-12-04 16:30 ` Jakub Kicinski
2025-12-04 17:21 ` Guenter Roeck
2025-12-04 16:17 ` [PATCH 11/13] selftests/fs/mount-notify: Fix build failure " Guenter Roeck
2025-12-04 16:17 ` [PATCH 12/13] selftests/fs/mount-notify-ns: Fix build failures " Guenter Roeck
2025-12-04 16:17 ` [PATCH 13/13] selftests: net: tfo: Fix build error " Guenter Roeck
2025-12-04 16:27 ` [PATCH 00/13] selftests: Fix problems seen when building " Jakub Kicinski
2025-12-04 17:16 ` Guenter Roeck
2025-12-04 17:43 ` Jakub Kicinski
2025-12-04 17:56 ` Guenter Roeck
2025-12-04 20:03 ` Kees Cook
2025-12-04 20:07 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251204161729.2448052-9-linux@roeck-us.net \
--to=linux@roeck-us.net \
--cc=bpf@vger.kernel.org \
--cc=brauner@kernel.org \
--cc=edumazet@google.com \
--cc=kees@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=tglx@linutronix.de \
--cc=wine-devel@winehq.org \
--cc=zfigura@codeweavers.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).