From: Jakub Kicinski <kuba@kernel.org>
To: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Breno Leitao <leitao@debian.org>, Paolo Abeni <pabeni@redhat.com>,
leit@meta.com, open list <linux-kernel@vger.kernel.org>,
"open list:NETWORKING DRIVERS" <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next] net: veth: Disable netpoll support
Date: Thu, 4 Dec 2025 17:34:21 -0800 [thread overview]
Message-ID: <20251204173421.23841106@kernel.org> (raw)
In-Reply-To: <1764839728.p54aio6507.astroid@yuna.none>
On Thu, 04 Dec 2025 10:20:06 +0100 Fabian Grünbichler wrote:
> On August 5, 2024 11:40 am, Breno Leitao wrote:
> > The current implementation of netpoll in veth devices leads to
> > suboptimal behavior, as it triggers warnings due to the invocation of
> > __netif_rx() within a softirq context. This is not compliant with
> > expected practices, as __netif_rx() has the following statement:
> >
> > lockdep_assert_once(hardirq_count() | softirq_count());
> >
> > Given that veth devices typically do not benefit from the
> > functionalities provided by netpoll, Disable netpoll for veth
> > interfaces.
>
> this patch seems to have broken combining netconsole and bridges with
> veth ports:
>
> https://bugzilla.proxmox.com/show_bug.cgi?id=6873
>
> any chance this is solvable?
What's the reason to set up netcons over veth?
Note that unlike normal IP traffic netcons just blindly pipes out fully
baked skbs, it doesn't use the IP stack. So unlike normal IP traffic
I think you can still point it at the physical netdev, even if that
physical netdev is under a bridge.
next prev parent reply other threads:[~2025-12-05 1:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-05 9:40 [PATCH net-next] net: veth: Disable netpoll support Breno Leitao
2024-08-06 20:27 ` patchwork-bot+netdevbpf
2025-12-04 9:20 ` Fabian Grünbichler
2025-12-04 13:44 ` Breno Leitao
2025-12-05 1:34 ` Jakub Kicinski [this message]
2025-12-05 7:35 ` Fabian Grünbichler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251204173421.23841106@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.gruenbichler@proxmox.com \
--cc=leit@meta.com \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).