netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Shuah Khan <shuah@kernel.org>
Cc: Jakub Kicinski <kuba@kernel.org>,
	Christian Brauner <brauner@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Eric Dumazet <edumazet@google.com>, Kees Cook <kees@kernel.org>,
	linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
	wine-devel@winehq.org, netdev@vger.kernel.org,
	bpf@vger.kernel.org, Guenter Roeck <linux@roeck-us.net>
Subject: [PATCH v2 08/13] selftests: net: netlink-dumps: Avoid uninitialized variable warning
Date: Fri,  5 Dec 2025 09:10:02 -0800	[thread overview]
Message-ID: <20251205171010.515236-9-linux@roeck-us.net> (raw)
In-Reply-To: <20251205171010.515236-1-linux@roeck-us.net>

The following warning is seen when building netlink-dumps.

netlink-dumps.c: In function ‘dump_extack’:
../kselftest_harness.h:788:35: warning: ‘ret’ may be used uninitialized

Problem is that the loop which initializes 'ret' may exit early without
initializing the variable if recv() returns an error. Always initialize
'ret' to solve the problem.

Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
v2: Update subject and description to reflect that the patch fixes a build
    warning. 

 tools/testing/selftests/net/netlink-dumps.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/net/netlink-dumps.c b/tools/testing/selftests/net/netlink-dumps.c
index 679b6c77ace7..67bf3fc2d66b 100644
--- a/tools/testing/selftests/net/netlink-dumps.c
+++ b/tools/testing/selftests/net/netlink-dumps.c
@@ -112,7 +112,7 @@ static const struct {
 TEST(dump_extack)
 {
 	int netlink_sock;
-	int i, cnt, ret;
+	int i, cnt, ret = FOUND_ERR;
 	char buf[8192];
 	int one = 1;
 	ssize_t n;
-- 
2.45.2


  parent reply	other threads:[~2025-12-05 17:12 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-05 17:09 [PATCH v2 00/13] selftests: Fix build warnings and errors Guenter Roeck
2025-12-05 17:09 ` [PATCH v2 01/13] clone3: clone3_cap_checkpoint_restore: Fix build warnings Guenter Roeck
2025-12-05 17:09 ` [PATCH v2 02/13] selftests: ntsync: " Guenter Roeck
2025-12-08 19:27   ` Elizabeth Figura
2025-12-05 17:09 ` [PATCH v2 03/13] selftests/filesystems: fclog: Fix build warnings and errors Guenter Roeck
2025-12-05 17:09 ` [PATCH v2 04/13] selftests/filesystems: file_stressor: Fix build warning Guenter Roeck
2025-12-05 17:09 ` [PATCH v2 05/13] selftests/filesystems: anon_inode_test: " Guenter Roeck
2025-12-05 17:10 ` [PATCH v2 06/13] selftest: af_unix: Support compilers without flex-array-member-not-at-end support Guenter Roeck
2025-12-05 17:10 ` [PATCH v2 07/13] selftest/futex: Comment out test_futex_mpol Guenter Roeck
2025-12-05 17:10 ` Guenter Roeck [this message]
2025-12-10  9:13   ` [PATCH v2 08/13] selftests: net: netlink-dumps: Avoid uninitialized variable warning Jakub Kicinski
2025-12-10 19:09     ` Guenter Roeck
2025-12-05 17:10 ` [PATCH v2 09/13] selftests/seccomp: Fix build warning Guenter Roeck
2025-12-05 22:21   ` Kees Cook
2025-12-05 17:10 ` [PATCH v2 10/13] selftests: net: Fix build warnings Guenter Roeck
2025-12-05 17:10 ` [PATCH v2 11/13] selftests/fs/mount-notify: Fix build warning Guenter Roeck
2025-12-05 17:10 ` [PATCH v2 12/13] selftests/fs/mount-notify-ns: " Guenter Roeck
2025-12-05 17:31   ` Amir Goldstein
2025-12-05 18:26     ` Guenter Roeck
2025-12-05 17:10 ` [PATCH v2 13/13] selftests: net: tfo: " Guenter Roeck
2025-12-10  9:20 ` [PATCH v2 00/13] selftests: Fix build warnings and errors patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251205171010.515236-9-linux@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=bpf@vger.kernel.org \
    --cc=brauner@kernel.org \
    --cc=edumazet@google.com \
    --cc=kees@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=shuah@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=wine-devel@winehq.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).