From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: "Bjørn Mork" <bjorn@mork.no>
Cc: netdev@vger.kernel.org, "Lucien.Jheng" <lucienzx159@gmail.com>,
Daniel Golle <daniel@makrotopia.org>
Subject: Re: [RFC] net: phy: air_en8811h: add Airoha AN8811HB support
Date: Sat, 6 Dec 2025 10:41:04 +0200 [thread overview]
Message-ID: <20251206084104.prufjf2jbvtwctlg@skbuf> (raw)
In-Reply-To: <87sedq4pyk.fsf@miraculix.mork.no>
On Thu, Dec 04, 2025 at 09:21:39AM +0100, Bjørn Mork wrote:
> >> - pol = phy_get_rx_polarity(dev_fwnode(dev), phy_modes(phydev->interface),
> >> - PHY_POL_NORMAL | PHY_POL_INVERT, default_pol);
> >> - if (pol < 0)
> >> - return pol;
> >> - if (pol == PHY_POL_INVERT)
> >> - pbus_value |= EN8811H_POLARITY_RX_REVERSE;
> >> + return phy_get_rx_polarity(dev_fwnode(dev), phy_modes(phydev->interface),
> >> + PHY_POL_NORMAL | PHY_POL_INVERT, default_pol)
> >> + == PHY_POL_INVERT;
As I was writing a KUnit test for this API, I found another bug in my
submission which you also copied in yours, and I want to point it out
for when you resend.
The "supported" mask of polarities should be
BIT(PHY_POL_NORMAL) | BIT(PHY_POL_INVERT)
rather than
PHY_POL_NORMAL | PHY_POL_INVERT
prev parent reply other threads:[~2025-12-06 8:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-02 10:22 [RFC] net: phy: air_en8811h: add Airoha AN8811HB support Bjørn Mork
2025-12-02 16:12 ` Andrew Lunn
2025-12-03 12:21 ` Bjørn Mork
2025-12-03 23:24 ` Vladimir Oltean
2025-12-04 8:21 ` Bjørn Mork
2025-12-04 9:02 ` Vladimir Oltean
2025-12-06 8:41 ` Vladimir Oltean [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251206084104.prufjf2jbvtwctlg@skbuf \
--to=vladimir.oltean@nxp.com \
--cc=bjorn@mork.no \
--cc=daniel@makrotopia.org \
--cc=lucienzx159@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox