[PATCH net] tools: ynl: fix build on systems with old kernel headers

[PATCH net] tools: ynl: fix build on systems with old kernel headers

[Jakub Kicinski]

The wireguard YNL conversion was missing the customary .deps entry.
NIPA doesn't catch this but my CentOS 9 system complains:

 wireguard-user.c:72:10: error: ‘WGALLOWEDIP_A_FLAGS’ undeclared here
 wireguard-user.c:58:67: error: parameter 1 (‘value’) has incomplete type
 58 | const char *wireguard_wgallowedip_flags_str(enum wgallowedip_flag value)
    |                                             ~~~~~~~~~~~~~~~~~~~~~~^~~~~

And similarly does Ubuntu 22.04.

One extra complication here is that we renamed the header guard,
so we need to compat with both old and new guard define.

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
Found when syncing the "standalone" GitHub repo with ynl which
has a CI building on Ubuntu.

CC: donald.hunter@gmail.com
CC: ast@fiberby.net
CC: Jason@zx2c4.com
---
 tools/net/ynl/Makefile.deps | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tools/net/ynl/Makefile.deps b/tools/net/ynl/Makefile.deps
index 865fd2e8519e..08205f9fc525 100644
--- a/tools/net/ynl/Makefile.deps
+++ b/tools/net/ynl/Makefile.deps
@@ -13,6 +13,7 @@ UAPI_PATH:=../../../../include/uapi/
 # need the explicit -D matching what's in /usr, to avoid multiple definitions.
 
 get_hdr_inc=-D$(1) -include $(UAPI_PATH)/linux/$(2)
+get_hdr_inc2=-D$(1) -D$(2) -include $(UAPI_PATH)/linux/$(3)
 
 CFLAGS_devlink:=$(call get_hdr_inc,_LINUX_DEVLINK_H_,devlink.h)
 CFLAGS_dpll:=$(call get_hdr_inc,_LINUX_DPLL_H,dpll.h)
@@ -48,3 +49,4 @@ CFLAGS_tc:= $(call get_hdr_inc,__LINUX_RTNETLINK_H,rtnetlink.h) \
 	$(call get_hdr_inc,_TC_SKBEDIT_H,tc_act/tc_skbedit.h) \
 	$(call get_hdr_inc,_TC_TUNNEL_KEY_H,tc_act/tc_tunnel_key.h)
 CFLAGS_tcp_metrics:=$(call get_hdr_inc,_LINUX_TCP_METRICS_H,tcp_metrics.h)
+CFLAGS_wireguard:=$(call get_hdr_inc2,_LINUX_WIREGUARD_H,_WG_UAPI_WIREGUARD_H,wireguard.h)
-- 
2.52.0

Re: [PATCH net] tools: ynl: fix build on systems with old kernel headers

[Asbjørn Sloth Tønnesen]

On 12/7/25 1:38 AM, Jakub Kicinski wrote:
> The wireguard YNL conversion was missing the customary .deps entry.
> NIPA doesn't catch this but my CentOS 9 system complains:
> 
>   wireguard-user.c:72:10: error: ‘WGALLOWEDIP_A_FLAGS’ undeclared here
>   wireguard-user.c:58:67: error: parameter 1 (‘value’) has incomplete type
>   58 | const char *wireguard_wgallowedip_flags_str(enum wgallowedip_flag value)
>      |                                             ~~~~~~~~~~~~~~~~~~~~~~^~~~~
> 
> And similarly does Ubuntu 22.04.
> 
> One extra complication here is that we renamed the header guard,
> so we need to compat with both old and new guard define.
> 
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> Found when syncing the "standalone" GitHub repo with ynl which
> has a CI building on Ubuntu.

Thank you for catching this.

I had put it in the sample commit, which was postponed last-minute.
Next time I will include it in same commit as the spec.

Reviewed-by: Asbjørn Sloth Tønnesen <ast@fiberby.net>

Re: [PATCH net] tools: ynl: fix build on systems with old kernel headers

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Sat,  6 Dec 2025 17:38:48 -0800 you wrote:
> The wireguard YNL conversion was missing the customary .deps entry.
> NIPA doesn't catch this but my CentOS 9 system complains:
> 
>  wireguard-user.c:72:10: error: ‘WGALLOWEDIP_A_FLAGS’ undeclared here
>  wireguard-user.c:58:67: error: parameter 1 (‘value’) has incomplete type
>  58 | const char *wireguard_wgallowedip_flags_str(enum wgallowedip_flag value)
>     |                                             ~~~~~~~~~~~~~~~~~~~~~~^~~~~
> 
> [...]

Here is the summary with links:
  - [net] tools: ynl: fix build on systems with old kernel headers
    https://git.kernel.org/netdev/net/c/db6b35cffe59

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html