From: Jakub Kicinski <kuba@kernel.org>
To: Vivek Pernamitta <vivek.pernamitta@oss.qualcomm.com>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Manivannan Sadhasivam <mani@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
mhi@lists.linux.dev, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v6 2/2] bus: mhi: host: pci: Enable IP_SW1, IP_ETH0 and IP_ETH1 channels for QDU100
Date: Wed, 10 Dec 2025 18:39:46 +0900 [thread overview]
Message-ID: <20251210183946.3740a3b3@kernel.org> (raw)
In-Reply-To: <20251209-vdev_next-20251208_eth_v6-v6-2-80898204f5d8@quicinc.com>
On Tue, 09 Dec 2025 16:55:39 +0530 Vivek Pernamitta wrote:
> Enable IP_SW1, IP_ETH0 and IP_ETH1 channels for M-plane, NETCONF and
> S-plane interface for QDU100.
>
> Signed-off-by: Vivek Pernamitta <vivek.pernamitta@oss.qualcomm.com>
> ---
> drivers/bus/mhi/host/pci_generic.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_generic.c
> index e3bc737313a2f0658bc9b9c4f7d85258aec2474c..b64b155e4bd70326fed0aa86f32d8502da2f49d0 100644
> --- a/drivers/bus/mhi/host/pci_generic.c
> +++ b/drivers/bus/mhi/host/pci_generic.c
> @@ -269,6 +269,13 @@ static const struct mhi_channel_config mhi_qcom_qdu100_channels[] = {
> MHI_CHANNEL_CONFIG_DL(41, "MHI_PHC", 32, 4),
> MHI_CHANNEL_CONFIG_UL(46, "IP_SW0", 256, 5),
> MHI_CHANNEL_CONFIG_DL(47, "IP_SW0", 256, 5),
> + MHI_CHANNEL_CONFIG_UL(48, "IP_SW1", 256, 6),
> + MHI_CHANNEL_CONFIG_DL(49, "IP_SW1", 256, 6),
> + MHI_CHANNEL_CONFIG_UL(50, "IP_ETH0", 256, 7),
> + MHI_CHANNEL_CONFIG_DL(51, "IP_ETH0", 256, 7),
> + MHI_CHANNEL_CONFIG_UL(52, "IP_ETH1", 256, 8),
> + MHI_CHANNEL_CONFIG_DL(53, "IP_ETH1", 256, 8),
What is this CHANNEL_CONFIG thing and why is it part of the bus code
and not driver code? Having to modify the bus for driver changes
indicates the abstractions aren't used properly here..
next prev parent reply other threads:[~2025-12-10 9:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-09 11:25 [PATCH v6 0/2] net: mhi: Add support to enable ethernet interface Vivek Pernamitta
2025-12-09 11:25 ` [PATCH v6 1/2] net: mhi: Enable Ethernet interface support Vivek Pernamitta
2025-12-09 13:36 ` Andrew Lunn
2025-12-10 6:30 ` vivek pernamitta
[not found] ` <eaf79686-9fcb-4330-8017-83a4e4923985@oss.qualcomm.com>
2025-12-10 16:50 ` Andrew Lunn
2025-12-22 10:31 ` vivek pernamitta
2025-12-10 9:38 ` Jakub Kicinski
2025-12-22 10:43 ` vivek pernamitta
2025-12-24 6:08 ` Manivannan Sadhasivam
2025-12-09 11:25 ` [PATCH v6 2/2] bus: mhi: host: pci: Enable IP_SW1, IP_ETH0 and IP_ETH1 channels for QDU100 Vivek Pernamitta
2025-12-10 9:39 ` Jakub Kicinski [this message]
2025-12-22 10:34 ` vivek pernamitta
2025-12-24 6:03 ` [PATCH v6 0/2] net: mhi: Add support to enable ethernet interface Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251210183946.3740a3b3@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mani@kernel.org \
--cc=mhi@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vivek.pernamitta@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).