From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 750902BFC8F for ; Thu, 11 Dec 2025 07:50:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765439458; cv=none; b=AmiwmJtUr5GnC7H1HGNU7f4qlqmvV7/qnsZDbHDjF6bJk+0lPfw0fQ4gYDVwWV2fNT65U+XCCxOQeGpjt3DXZL4R+GgRg9Hi6cy5vK428MlwsngYyMry6MHCtT3NnDk36hMwxSE+sWaB2DEiivAl7zj6c6+5LVHSgYbFDv7AsB0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765439458; c=relaxed/simple; bh=Tdaj27oj3uUmgl9B6hjdaVnC0Z/17Xx96phCTkl90B0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=U2I8TaURvRauyhEuv1KuEd0ExtKYHgL9uaxxs6xHKyNOf+RdUZqivEBVLXw/aZBv6vGeZ4/an276r650N5x6yyd8OtIR/PGPIdad/lzLANQIf5zjtwBMZTp43nCI7RgoFSCbKxFbl3xGVz9hlEBLUDdMbHcg9f+FMzqkLyrLGdo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=U9q7g2YA; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=smI0YqLN; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="U9q7g2YA"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="smI0YqLN" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1765439456; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1julX6+lHM93SRmQtBaRqoKkJXlGzuQZ/nqcTrNS9W8=; b=U9q7g2YAb2LAPt3JhpwKkBikbLvRO6nJfTWUM8u1NyMoavDudRD+DE4DEKS6PtRSJb3edn Wfg3hUhN0M5h7aBXXaRJvWEPToyw49O2094hL92VydM0JXAx+LqIkG42xT1hgccMCXqHAH uCj99w4m3UbmeM0Dp8g/uDdNxu+eyPM= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-368-1bRyF0YrNw2ChnGtNaehng-1; Thu, 11 Dec 2025 02:50:53 -0500 X-MC-Unique: 1bRyF0YrNw2ChnGtNaehng-1 X-Mimecast-MFC-AGG-ID: 1bRyF0YrNw2ChnGtNaehng_1765439452 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-4779d8fd4ecso2789895e9.1 for ; Wed, 10 Dec 2025 23:50:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1765439452; x=1766044252; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=1julX6+lHM93SRmQtBaRqoKkJXlGzuQZ/nqcTrNS9W8=; b=smI0YqLN0caaqEi8xK7wSUiFiGk2rr/IGovPcOkVd9MuiGJCbEYiTlohjSNhhI1Nki bNs24xixCkHqeeHZL9hTzuaE1oS+pn92lek342phV8TnjQh1O6FIptxR8VpfmvB0Llmd i7kvl1S4Xbly2xrwXv8MPQNN/cAP1IZYhFnOhdlrJBc9syjktwXRJw8yRMULuvE9bCWN zGNAyO94iC30BeH2ggNmj5iVMdIqt155Uj4kw4AvxW45WWK7AGUTfXSDd37OoFdiC277 I0z1kguWE9x5jSl1QNgLKx4mUXGKTITEO2qj+Lq/Ca9GGA0qAu1RIkqMCWm+khPlrQxg IpBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765439452; x=1766044252; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1julX6+lHM93SRmQtBaRqoKkJXlGzuQZ/nqcTrNS9W8=; b=mV1F4FRlpCm1RDDMH31Rnn+YpX1rKUUT30OtgR8t+U88E+iLktL0/ukzrMOesqfFk7 hJ283T5c3eJn/DqumSsCnTgz2NHwgWAXpLjEcW55J5HZNNMkrsX0SDqxj0nhTYqhE7Ib /5LyuBN1g9mTYqDq0J3/ERHgRHRhQxM1YaGwHPzhO1hxivjZkr1TNuaigxCfitDh+foC N2Y0uh4APz5NjNsMRb5jJC/QYyOxzJRdF/bfSrNjROfTMydQ3NYA+fLLuixwWUUlbc2E +zjFuEKAx0BLpisn4IdsAwcSodRGgXFaMr3BLzPRyDD2S2HrKl89amKpfy6ddfce/cDU UREw== X-Forwarded-Encrypted: i=1; AJvYcCXpeSKLgPkkry7dil/3mCv64H2lLNUDdYq0D/KBX4YSAHOJL6JBcdmLngj73DQ7XdQ9DAYCvYo=@vger.kernel.org X-Gm-Message-State: AOJu0Yy+MAVWkrT6rES5Z/YSk6ZDICNouJzPPgiUDnRImC78A/nVY8q/ mLwXW7cylcCYzIU3Fbf3a05xmSAbH9ZSU+sbyrUsdGMcEqlTg4/OjbcgUaVkrRZ1i9Jn5cXU7my rqImy/2neIda7Qmnc/57VSe7tMELe9fFCKb//wDreKC/GwklTBix3rKlyew== X-Gm-Gg: AY/fxX6SS8A6XjFw6545K3UakVtQVw/jXULbYqlWfTLaHRKKxgqhpW/O9nmhZKtKW60 1KqxOa8dWB6P2jLTfngL+eQQOS3RJ19oN2MUDX3AxlkzgkY8OeBCt16iZ5eXb4RxrHB3bfHoSaI v7Ybvne0Kqfsk7ui3urBYPgz2Br548aJH11uBBAGKxhTT+7fHWJpki3KJ/bpM9q8TMt56rnwRRe WbOZ4PELhxbT1MDdyfdNnmvyCC8toWmDyCF0TwpvdqQuammT91GEQaYwUxT4B/k2qgqSBtWBtIu CYpmkvZ24ldDZIjNDxHWU+oyyyosDR9YVFa+RMg9WhmkNmxqDH0vN+HafNQEoGh1rjK9dup0C/G Ukb/KxiM10S0BP+pt3WpaQRc4iL63j4s= X-Received: by 2002:a05:600c:c101:b0:477:7588:c8cc with SMTP id 5b1f17b1804b1-47a89da461emr8884195e9.7.1765439452378; Wed, 10 Dec 2025 23:50:52 -0800 (PST) X-Google-Smtp-Source: AGHT+IEqSjcn3rTA9O8e0vbxus6mZdzQZ1RPlwK+jJom7NtOKCUAyJXsaTZy7V9armCUnMlhTK9Uqw== X-Received: by 2002:a05:600c:c101:b0:477:7588:c8cc with SMTP id 5b1f17b1804b1-47a89da461emr8883815e9.7.1765439451922; Wed, 10 Dec 2025 23:50:51 -0800 (PST) Received: from redhat.com (IGLD-80-230-32-59.inter.net.il. [80.230.32.59]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42fa8b96c70sm3927469f8f.37.2025.12.10.23.50.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Dec 2025 23:50:51 -0800 (PST) Date: Thu, 11 Dec 2025 02:50:48 -0500 From: "Michael S. Tsirkin" To: Dan Carpenter Cc: Stefano Garzarella , Jason Wang , Xuan Zhuo , Eugenio =?iso-8859-1?Q?P=E9rez?= , Stefan Hajnoczi , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , virtualization@lists.linux.dev, kvm@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH net] vsock/virtio: Fix error code in virtio_transport_recv_listen() Message-ID: <20251211025034-mutt-send-email-mst@kernel.org> References: Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Dec 11, 2025 at 10:45:47AM +0300, Dan Carpenter wrote: > Return a negative error code if the transport doesn't match. Don't > return success. > > Fixes: c0cfa2d8a788 ("vsock: add multi-transports support") > Cc: stable@vger.kernel.org > Signed-off-by: Dan Carpenter Acked-by: Michael S. Tsirkin > --- > >From static analysis. Not tested. > > net/vmw_vsock/virtio_transport_common.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/vmw_vsock/virtio_transport_common.c b/net/vmw_vsock/virtio_transport_common.c > index dcc8a1d5851e..77fbc6c541bf 100644 > --- a/net/vmw_vsock/virtio_transport_common.c > +++ b/net/vmw_vsock/virtio_transport_common.c > @@ -1550,7 +1550,7 @@ virtio_transport_recv_listen(struct sock *sk, struct sk_buff *skb, > release_sock(child); > virtio_transport_reset_no_sock(t, skb); > sock_put(child); > - return ret; > + return ret ?: -EINVAL; > } > > if (virtio_transport_space_update(child, skb)) > -- > 2.51.0