* [PATCH net] vsock/virtio: Fix error code in virtio_transport_recv_listen()
@ 2025-12-11 7:45 Dan Carpenter
2025-12-11 7:50 ` Michael S. Tsirkin
2025-12-11 8:30 ` Stefano Garzarella
0 siblings, 2 replies; 4+ messages in thread
From: Dan Carpenter @ 2025-12-11 7:45 UTC (permalink / raw)
To: Stefano Garzarella
Cc: Michael S. Tsirkin, Jason Wang, Xuan Zhuo, Eugenio Pérez,
Stefan Hajnoczi, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Simon Horman, virtualization, kvm, netdev,
linux-kernel, kernel-janitors
Return a negative error code if the transport doesn't match. Don't
return success.
Fixes: c0cfa2d8a788 ("vsock: add multi-transports support")
Cc: stable@vger.kernel.org
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
From static analysis. Not tested.
net/vmw_vsock/virtio_transport_common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/vmw_vsock/virtio_transport_common.c b/net/vmw_vsock/virtio_transport_common.c
index dcc8a1d5851e..77fbc6c541bf 100644
--- a/net/vmw_vsock/virtio_transport_common.c
+++ b/net/vmw_vsock/virtio_transport_common.c
@@ -1550,7 +1550,7 @@ virtio_transport_recv_listen(struct sock *sk, struct sk_buff *skb,
release_sock(child);
virtio_transport_reset_no_sock(t, skb);
sock_put(child);
- return ret;
+ return ret ?: -EINVAL;
}
if (virtio_transport_space_update(child, skb))
--
2.51.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH net] vsock/virtio: Fix error code in virtio_transport_recv_listen()
2025-12-11 7:45 [PATCH net] vsock/virtio: Fix error code in virtio_transport_recv_listen() Dan Carpenter
@ 2025-12-11 7:50 ` Michael S. Tsirkin
2025-12-11 8:30 ` Stefano Garzarella
1 sibling, 0 replies; 4+ messages in thread
From: Michael S. Tsirkin @ 2025-12-11 7:50 UTC (permalink / raw)
To: Dan Carpenter
Cc: Stefano Garzarella, Jason Wang, Xuan Zhuo, Eugenio Pérez,
Stefan Hajnoczi, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Simon Horman, virtualization, kvm, netdev,
linux-kernel, kernel-janitors
On Thu, Dec 11, 2025 at 10:45:47AM +0300, Dan Carpenter wrote:
> Return a negative error code if the transport doesn't match. Don't
> return success.
>
> Fixes: c0cfa2d8a788 ("vsock: add multi-transports support")
> Cc: stable@vger.kernel.org
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> >From static analysis. Not tested.
>
> net/vmw_vsock/virtio_transport_common.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/vmw_vsock/virtio_transport_common.c b/net/vmw_vsock/virtio_transport_common.c
> index dcc8a1d5851e..77fbc6c541bf 100644
> --- a/net/vmw_vsock/virtio_transport_common.c
> +++ b/net/vmw_vsock/virtio_transport_common.c
> @@ -1550,7 +1550,7 @@ virtio_transport_recv_listen(struct sock *sk, struct sk_buff *skb,
> release_sock(child);
> virtio_transport_reset_no_sock(t, skb);
> sock_put(child);
> - return ret;
> + return ret ?: -EINVAL;
> }
>
> if (virtio_transport_space_update(child, skb))
> --
> 2.51.0
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH net] vsock/virtio: Fix error code in virtio_transport_recv_listen()
2025-12-11 7:45 [PATCH net] vsock/virtio: Fix error code in virtio_transport_recv_listen() Dan Carpenter
2025-12-11 7:50 ` Michael S. Tsirkin
@ 2025-12-11 8:30 ` Stefano Garzarella
2025-12-11 8:38 ` Dan Carpenter
1 sibling, 1 reply; 4+ messages in thread
From: Stefano Garzarella @ 2025-12-11 8:30 UTC (permalink / raw)
To: Dan Carpenter
Cc: Michael S. Tsirkin, Jason Wang, Xuan Zhuo, Eugenio Pérez,
Stefan Hajnoczi, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Simon Horman, virtualization, kvm, netdev,
linux-kernel, kernel-janitors
On Thu, Dec 11, 2025 at 10:45:47AM +0300, Dan Carpenter wrote:
>Return a negative error code if the transport doesn't match. Don't
>return success.
>
>Fixes: c0cfa2d8a788 ("vsock: add multi-transports support")
>Cc: stable@vger.kernel.org
>Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
>---
>From static analysis. Not tested.
>
> net/vmw_vsock/virtio_transport_common.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/net/vmw_vsock/virtio_transport_common.c b/net/vmw_vsock/virtio_transport_common.c
>index dcc8a1d5851e..77fbc6c541bf 100644
>--- a/net/vmw_vsock/virtio_transport_common.c
>+++ b/net/vmw_vsock/virtio_transport_common.c
>@@ -1550,7 +1550,7 @@ virtio_transport_recv_listen(struct sock *sk, struct sk_buff *skb,
> release_sock(child);
> virtio_transport_reset_no_sock(t, skb);
> sock_put(child);
>- return ret;
>+ return ret ?: -EINVAL;
Thanks for this fix. I think we have a similar issue also in
net/vmw_vsock/vmci_transport.c introduced by the same commit.
In net/vmw_vsock/hyperv_transport.c we have a similar pattern, but the
calling function return void, so no issue there.
Do you mind to fix also that one?
Sending a v2 to fix both or another patch just for that it's fine by me,
so:
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH net] vsock/virtio: Fix error code in virtio_transport_recv_listen()
2025-12-11 8:30 ` Stefano Garzarella
@ 2025-12-11 8:38 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2025-12-11 8:38 UTC (permalink / raw)
To: Stefano Garzarella
Cc: Michael S. Tsirkin, Jason Wang, Xuan Zhuo, Eugenio Pérez,
Stefan Hajnoczi, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Simon Horman, virtualization, kvm, netdev,
linux-kernel, kernel-janitors
On Thu, Dec 11, 2025 at 09:30:06AM +0100, Stefano Garzarella wrote:
> On Thu, Dec 11, 2025 at 10:45:47AM +0300, Dan Carpenter wrote:
> > Return a negative error code if the transport doesn't match. Don't
> > return success.
> >
> > Fixes: c0cfa2d8a788 ("vsock: add multi-transports support")
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> > ---
> > From static analysis. Not tested.
> >
> > net/vmw_vsock/virtio_transport_common.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/net/vmw_vsock/virtio_transport_common.c b/net/vmw_vsock/virtio_transport_common.c
> > index dcc8a1d5851e..77fbc6c541bf 100644
> > --- a/net/vmw_vsock/virtio_transport_common.c
> > +++ b/net/vmw_vsock/virtio_transport_common.c
> > @@ -1550,7 +1550,7 @@ virtio_transport_recv_listen(struct sock *sk, struct sk_buff *skb,
> > release_sock(child);
> > virtio_transport_reset_no_sock(t, skb);
> > sock_put(child);
> > - return ret;
> > + return ret ?: -EINVAL;
>
> Thanks for this fix. I think we have a similar issue also in
> net/vmw_vsock/vmci_transport.c introduced by the same commit.
> In net/vmw_vsock/hyperv_transport.c we have a similar pattern, but the
> calling function return void, so no issue there.
>
> Do you mind to fix also that one?
Sure. I will resend a v2.
The check doesn't catch that one because the != comparison is
hidden inside the vmci_check_transport() call. So I would have missed
it. Thanks for catching it.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-12-11 8:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-11 7:45 [PATCH net] vsock/virtio: Fix error code in virtio_transport_recv_listen() Dan Carpenter
2025-12-11 7:50 ` Michael S. Tsirkin
2025-12-11 8:30 ` Stefano Garzarella
2025-12-11 8:38 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).