From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-183.mta0.migadu.com (out-183.mta0.migadu.com [91.218.175.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4F8F621CC49 for ; Sat, 13 Dec 2025 13:59:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.183 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765634366; cv=none; b=eL+Pfrzec8Zm2BBvRwRGhfjHImY9ku0h+J1wT3GWeyRuIHjXIgk+jX42qY6eNPAes2Cb59o47qXk+mxvgnEqaO3A0T820ww3Q1LHtXNSvjY8N1O0Z1fGEe6i1vKwthUQeLyhc1jkvQJq3q8Egma0IREIgtT7JxeWJQC6xmsb+94= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765634366; c=relaxed/simple; bh=6GmQ9dw5k4Z1UuU5aLrAqgri3WMihdT2oMSe0Wd7lZ8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=pFz43vhBymxerPrw1J5YNbwXs3TEo3CnjwovLGGZI+jD3JvTFCXFpyUYm4BcxTvA9IhEaKloaBPnjzpssO5TVL23FDvEmeJMhSmHjT3YybAiiuhKDKPtG4nQNjY1OxtA41KsxpRqsubFMwyc8MbjSXng9L2xPMPhuiCTVfRjT1Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=xXN0Z3Be; arc=none smtp.client-ip=91.218.175.183 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="xXN0Z3Be" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1765634362; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Mubqaua5faM5YPDocLFpJm5VffXtSPUH/a0eo2lXgSA=; b=xXN0Z3BeP6B/DMYH/q7YhDXn56rZKWL1V7+J3a8xP8pQ07IjchaCIsLt75BYpajNjHCaks z9khN4IPEtIBkpP67iv4q/BNhBhXLmzVhGmDx82cprG791xPeFMK/su/DxF1AjyfolHUW9 wJTsSpBB8k+Re3yrpEXspmFV4g50kDU= From: Vadim Fedorenko To: "David S. Miller" , David Ahern , Eric Dumazet , Paolo Abeni , Simon Horman , Willem de Bruijn , Jakub Kicinski Cc: Shuah Khan , Ido Schimmel , netdev@vger.kernel.org, Vadim Fedorenko Subject: [PATCH net 2/2] selftests: fib_nexthops: Add test case for ipv4 multi nexthops Date: Sat, 13 Dec 2025 13:58:49 +0000 Message-ID: <20251213135849.2054677-2-vadim.fedorenko@linux.dev> In-Reply-To: <20251213135849.2054677-1-vadim.fedorenko@linux.dev> References: <20251213135849.2054677-1-vadim.fedorenko@linux.dev> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT The test checks that with multi nexthops route the preferred route is the one which matches source ip. In case when source ip is on loopback, it checks that the routes are balanced. Signed-off-by: Vadim Fedorenko --- tools/testing/selftests/net/fib_nexthops.sh | 85 +++++++++++++++++++++ 1 file changed, 85 insertions(+) diff --git a/tools/testing/selftests/net/fib_nexthops.sh b/tools/testing/selftests/net/fib_nexthops.sh index 2b0a90581e2f..9d6f57399a73 100755 --- a/tools/testing/selftests/net/fib_nexthops.sh +++ b/tools/testing/selftests/net/fib_nexthops.sh @@ -31,6 +31,7 @@ IPV4_TESTS=" ipv4_compat_mode ipv4_fdb_grp_fcnal ipv4_mpath_select + ipv4_mpath_select_nogrp ipv4_torture ipv4_res_torture " @@ -375,6 +376,17 @@ check_large_res_grp() log_test $? 0 "Dump large (x$buckets) nexthop buckets" } +get_route_dev_src() +{ + local pfx="$1" + local src="$2" + local out + + if out=$($IP -j route get "$pfx" from "$src" | jq -re ".[0].dev"); then + echo "$out" + fi +} + get_route_dev() { local pfx="$1" @@ -641,6 +653,79 @@ ipv4_fdb_grp_fcnal() $IP link del dev vx10 } +ipv4_mpath_select_nogrp() +{ + local rc dev match h addr + + echo + echo "IPv4 multipath selection no group" + echo "------------------------" + if [ ! -x "$(command -v jq)" ]; then + echo "SKIP: Could not run test; need jq tool" + return $ksft_skip + fi + + IP="ip -netns $peer" + # Use status of existing neighbor entry when determining nexthop for + # multipath routes. + local -A gws + gws=([veth2]=172.16.1.1 [veth4]=172.16.2.1) + local -A other_dev + other_dev=([veth2]=veth4 [veth4]=veth2) + local -A local_ips + local_ips=([veth2]=172.16.1.2 [veth4]=172.16.2.2 [veth5]=172.16.100.1) + local -A route_devs + route_devs=([veth2]=0 [veth4]=0) + + run_cmd "$IP address add 172.16.100.1/32 dev lo" + run_cmd "$IP ro add 172.16.102.0/24 nexthop via ${gws['veth2']} dev veth2 nexthop via ${gws['veth4']} dev veth4" + rc=0 + for dev in veth2 veth4; do + match=0 + from_ip="${local_ips[$dev]}" + for h in {1..254}; do + addr="172.16.102.$h" + if [ "$(get_route_dev_src "$addr" "$from_ip")" = "$dev" ]; then + match=1 + break + fi + done + if (( match == 0 )); then + echo "SKIP: Did not find a route using device $dev" + return $ksft_skip + fi + run_cmd "$IP neigh add ${gws[$dev]} dev $dev nud failed" + if ! check_route_dev "$addr" "${other_dev[$dev]}"; then + rc=1 + break + fi + run_cmd "$IP neigh del ${gws[$dev]} dev $dev" + done + + log_test $rc 0 "Use valid neighbor during multipath selection" + + from_ip="${local_ips["veth5"]}" + for h in {1..254}; do + addr="172.16.102.$h" + route_dev=$(get_route_dev_src "$addr" "$from_ip") + route_devs[$route_dev]=1 + done + for dev in veth2 veth4; do + if [ ${route_devs[$dev]} -eq 0 ]; then + rc=1 + break; + fi + done + + log_test $rc 0 "Use both neighbors during multipath selection" + + run_cmd "$IP neigh add 172.16.1.2 dev veth1 nud incomplete" + run_cmd "$IP neigh add 172.16.2.2 dev veth3 nud incomplete" + run_cmd "$IP route get 172.16.101.1" + # if we did not crash, success + log_test $rc 0 "Multipath selection with no valid neighbor" +} + ipv4_mpath_select() { local rc dev match h addr -- 2.47.3