* [PATCH bpf-next v2 0/2] xsk: introduce pre-allocated memory per xsk CQ
@ 2025-12-16 5:26 Jason Xing
2025-12-16 5:26 ` [PATCH bpf-next v2 1/2] xsk: introduce local_cq for each af_xdp socket Jason Xing
2025-12-16 5:26 ` [PATCH bpf-next v2 2/2] xsk: introduce a dedicated local completion queue for each xsk Jason Xing
0 siblings, 2 replies; 5+ messages in thread
From: Jason Xing @ 2025-12-16 5:26 UTC (permalink / raw)
To: davem, edumazet, kuba, pabeni, bjorn, magnus.karlsson,
maciej.fijalkowski, jonathan.lemon, sdf, ast, daniel, hawk,
john.fastabend
Cc: bpf, netdev, Jason Xing
From: Jason Xing <kernelxing@tencent.com>
This series was made based on the previous work[1] to fix the issue
without causing too much performance impact through adding a
pre-allocated memory for each xsk.
[1]: commit 30f241fcf52a ("xsk: Fix immature cq descriptor production")
---
v2
link: https://lore.kernel.org/all/20251209085950.96231-1-kerneljasonxing@gmail.com/
1. add if condition to test if cq is NULL
2. initialize the prod of local_cq
Jason Xing (2):
xsk: introduce local_cq for each af_xdp socket
xsk: introduce a dedicated local completion queue for each xsk
include/net/xdp_sock.h | 8 ++
net/xdp/xsk.c | 208 ++++++++++++++++++++---------------------
2 files changed, 111 insertions(+), 105 deletions(-)
--
2.41.3
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH bpf-next v2 1/2] xsk: introduce local_cq for each af_xdp socket
2025-12-16 5:26 [PATCH bpf-next v2 0/2] xsk: introduce pre-allocated memory per xsk CQ Jason Xing
@ 2025-12-16 5:26 ` Jason Xing
2025-12-16 5:46 ` bot+bpf-ci
2025-12-16 5:26 ` [PATCH bpf-next v2 2/2] xsk: introduce a dedicated local completion queue for each xsk Jason Xing
1 sibling, 1 reply; 5+ messages in thread
From: Jason Xing @ 2025-12-16 5:26 UTC (permalink / raw)
To: davem, edumazet, kuba, pabeni, bjorn, magnus.karlsson,
maciej.fijalkowski, jonathan.lemon, sdf, ast, daniel, hawk,
john.fastabend
Cc: bpf, netdev, Jason Xing
From: Jason Xing <kernelxing@tencent.com>
This is a prep that will be used to store the addr(s) of descriptors so
that each skb going to the end of life can publish corresponding addr(s)
in its completion queue that can be read by userspace.
Signed-off-by: Jason Xing <kernelxing@tencent.com>
---
include/net/xdp_sock.h | 8 +++++++
net/xdp/xsk.c | 50 ++++++++++++++++++++++++++++++++++++++++++
2 files changed, 58 insertions(+)
diff --git a/include/net/xdp_sock.h b/include/net/xdp_sock.h
index 23e8861e8b25..c53ab2609d8c 100644
--- a/include/net/xdp_sock.h
+++ b/include/net/xdp_sock.h
@@ -45,6 +45,12 @@ struct xsk_map {
struct xdp_sock __rcu *xsk_map[];
};
+struct local_cq {
+ u32 prod ____cacheline_aligned_in_smp;
+ u32 ring_mask ____cacheline_aligned_in_smp;
+ u64 desc[] ____cacheline_aligned_in_smp;
+};
+
struct xdp_sock {
/* struct sock must be the first member of struct xdp_sock */
struct sock sk;
@@ -89,6 +95,8 @@ struct xdp_sock {
struct mutex mutex;
struct xsk_queue *fq_tmp; /* Only as tmp storage before bind */
struct xsk_queue *cq_tmp; /* Only as tmp storage before bind */
+ /* Maintain addr(s) of descriptors locally */
+ struct local_cq *lcq;
};
/*
diff --git a/net/xdp/xsk.c b/net/xdp/xsk.c
index f093c3453f64..9b637d5e4528 100644
--- a/net/xdp/xsk.c
+++ b/net/xdp/xsk.c
@@ -1212,6 +1212,30 @@ static void xsk_delete_from_maps(struct xdp_sock *xs)
}
}
+/* Initialize local compeletion queue for each xsk */
+static int xsk_init_local_cq(struct xdp_sock *xs)
+{
+ struct xsk_queue *cq = xs->pool->cq;
+ size_t size;
+
+ if (!cq || !cq->nentries)
+ return -EINVAL;
+
+ size = struct_size_t(struct local_cq, desc, cq->nentries);
+ xs->lcq = vmalloc(size);
+ if (!xs->lcq)
+ return -ENOMEM;
+ xs->lcq->ring_mask = cq->nentries - 1;
+ xs->lcq->prod = 0;
+
+ return 0;
+}
+
+static void xsk_clear_local_cq(struct xdp_sock *xs)
+{
+ vfree(xs->lcq);
+}
+
static int xsk_release(struct socket *sock)
{
struct sock *sk = sock->sk;
@@ -1241,6 +1265,7 @@ static int xsk_release(struct socket *sock)
xskq_destroy(xs->tx);
xskq_destroy(xs->fq_tmp);
xskq_destroy(xs->cq_tmp);
+ xsk_clear_local_cq(xs);
sock_orphan(sk);
sock->sk = NULL;
@@ -1360,9 +1385,18 @@ static int xsk_bind(struct socket *sock, struct sockaddr_unsized *addr, int addr
goto out_unlock;
}
+ err = xsk_init_local_cq(xs);
+ if (err) {
+ xp_destroy(xs->pool);
+ xs->pool = NULL;
+ sockfd_put(sock);
+ goto out_unlock;
+ }
+
err = xp_assign_dev_shared(xs->pool, umem_xs, dev,
qid);
if (err) {
+ xsk_clear_local_cq(xs);
xp_destroy(xs->pool);
xs->pool = NULL;
sockfd_put(sock);
@@ -1380,6 +1414,13 @@ static int xsk_bind(struct socket *sock, struct sockaddr_unsized *addr, int addr
xp_get_pool(umem_xs->pool);
xs->pool = umem_xs->pool;
+ err = xsk_init_local_cq(xs);
+ if (err) {
+ xp_put_pool(xs->pool);
+ xs->pool = NULL;
+ sockfd_put(sock);
+ goto out_unlock;
+ }
/* If underlying shared umem was created without Tx
* ring, allocate Tx descs array that Tx batching API
* utilizes
@@ -1387,6 +1428,7 @@ static int xsk_bind(struct socket *sock, struct sockaddr_unsized *addr, int addr
if (xs->tx && !xs->pool->tx_descs) {
err = xp_alloc_tx_descs(xs->pool, xs);
if (err) {
+ xsk_clear_local_cq(xs);
xp_put_pool(xs->pool);
xs->pool = NULL;
sockfd_put(sock);
@@ -1409,8 +1451,16 @@ static int xsk_bind(struct socket *sock, struct sockaddr_unsized *addr, int addr
goto out_unlock;
}
+ err = xsk_init_local_cq(xs);
+ if (err) {
+ xp_destroy(xs->pool);
+ xs->pool = NULL;
+ goto out_unlock;
+ }
+
err = xp_assign_dev(xs->pool, dev, qid, flags);
if (err) {
+ xsk_clear_local_cq(xs);
xp_destroy(xs->pool);
xs->pool = NULL;
goto out_unlock;
--
2.41.3
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH bpf-next v2 2/2] xsk: introduce a dedicated local completion queue for each xsk
2025-12-16 5:26 [PATCH bpf-next v2 0/2] xsk: introduce pre-allocated memory per xsk CQ Jason Xing
2025-12-16 5:26 ` [PATCH bpf-next v2 1/2] xsk: introduce local_cq for each af_xdp socket Jason Xing
@ 2025-12-16 5:26 ` Jason Xing
1 sibling, 0 replies; 5+ messages in thread
From: Jason Xing @ 2025-12-16 5:26 UTC (permalink / raw)
To: davem, edumazet, kuba, pabeni, bjorn, magnus.karlsson,
maciej.fijalkowski, jonathan.lemon, sdf, ast, daniel, hawk,
john.fastabend
Cc: bpf, netdev, Jason Xing
From: Jason Xing <kernelxing@tencent.com>
Before the commit 30f241fcf52a ("xsk: Fix immature cq descriptor
production"), there is one issue[1] which causes the wrong publish
of descriptors in race condidtion. The above commit fixes the issue
but adds more memory operations in the xmit hot path and interrupt
context, which can cause side effect in performance.
Based on the existing infrastructure, this patch tries to propose
a new solution to fix the problem by using a pre-allocated memory
that is local completion queue to avoid frequently performing memory
functions. The benefit comes from replacing xsk_tx_generic_cache with
local cq.
The core logics are as show below:
1. allocate a new local completion queue when setting the real queue.
2. write the descriptors into the local cq in the xmit path. And
record the prod as @start_pos that reflects the start position of
skb in this queue so that later the skb can easily write the desc
addr(s) from local cq to cq addrs in the destruction phase.
3. initialize the upper 24 bits of destructor_arg to store @start_pos
in xsk_skb_init_misc().
4. Initialize the lower 8 bits of destructor_arg to store how many
descriptors the skb owns in xsk_inc_num_desc().
5. write the desc addr(s) from the @start_addr from the local cq
one by one into the real cq in xsk_destruct_skb(). In turn sync
the global state of the cq as before.
The format of destructor_arg is designed as:
------------------------ --------
| start_pos | num |
------------------------ --------
Using upper 24 bits is enough to keep the temporary descriptors. And
it's also enough to use lower 8 bits to show the number of descriptors
that one skb owns.
[1]: https://lore.kernel.org/all/20250530095957.43248-1-e.kubanski@partner.samsung.com/
Signed-off-by: Jason Xing <kernelxing@tencent.com>
---
net/xdp/xsk.c | 158 +++++++++++++++++---------------------------------
1 file changed, 53 insertions(+), 105 deletions(-)
diff --git a/net/xdp/xsk.c b/net/xdp/xsk.c
index 9b637d5e4528..3b8720f64eb5 100644
--- a/net/xdp/xsk.c
+++ b/net/xdp/xsk.c
@@ -41,8 +41,6 @@ struct xsk_addrs {
u64 addrs[MAX_SKB_FRAGS + 1];
};
-static struct kmem_cache *xsk_tx_generic_cache;
-
void xsk_set_rx_need_wakeup(struct xsk_buff_pool *pool)
{
if (pool->cached_need_wakeup & XDP_WAKEUP_RX)
@@ -539,81 +537,87 @@ static int xsk_wakeup(struct xdp_sock *xs, u8 flags)
return dev->netdev_ops->ndo_xsk_wakeup(dev, xs->queue_id, flags);
}
-static int xsk_cq_reserve_locked(struct xsk_buff_pool *pool)
+static int xsk_cq_reserve_addr_locked(struct xdp_sock *xs, u64 addr)
{
+ struct xsk_buff_pool *pool = xs->pool;
+ struct local_cq *lcq = xs->lcq;
int ret;
spin_lock(&pool->cq_cached_prod_lock);
ret = xskq_prod_reserve(pool->cq);
spin_unlock(&pool->cq_cached_prod_lock);
+ if (!ret)
+ lcq->desc[lcq->prod++ & lcq->ring_mask] = addr;
return ret;
}
-static bool xsk_skb_destructor_is_addr(struct sk_buff *skb)
+#define XSK_DESTRUCTOR_DESCS_SHIFT 8
+#define XSK_DESTRUCTOR_DESCS_MASK \
+ ((1ULL << XSK_DESTRUCTOR_DESCS_SHIFT) - 1)
+
+static long xsk_get_destructor_arg(struct sk_buff *skb)
{
- return (uintptr_t)skb_shinfo(skb)->destructor_arg & 0x1UL;
+ return (long)skb_shinfo(skb)->destructor_arg;
}
-static u64 xsk_skb_destructor_get_addr(struct sk_buff *skb)
+static u8 xsk_get_num_desc(struct sk_buff *skb)
{
- return (u64)((uintptr_t)skb_shinfo(skb)->destructor_arg & ~0x1UL);
+ long val = xsk_get_destructor_arg(skb);
+
+ return (u8)val & XSK_DESTRUCTOR_DESCS_MASK;
}
-static void xsk_skb_destructor_set_addr(struct sk_buff *skb, u64 addr)
+/* Record the position of first desc in local cq */
+static void xsk_skb_destructor_set_addr(struct sk_buff *skb,
+ struct xdp_sock *xs)
{
- skb_shinfo(skb)->destructor_arg = (void *)((uintptr_t)addr | 0x1UL);
+ long val;
+
+ val = ((xs->lcq->prod - 1) & xs->lcq->ring_mask) << XSK_DESTRUCTOR_DESCS_SHIFT;
+ skb_shinfo(skb)->destructor_arg = (void *)val;
}
+/* Only update the lower bits to adjust number of descriptors the skb
+ * carries. We have enough bits to increase the value of number of
+ * descriptors that should be within MAX_SKB_FRAGS, so increase it by
+ * one directly.
+ */
static void xsk_inc_num_desc(struct sk_buff *skb)
{
- struct xsk_addrs *xsk_addr;
+ long val = xsk_get_destructor_arg(skb) + 1;
- if (!xsk_skb_destructor_is_addr(skb)) {
- xsk_addr = (struct xsk_addrs *)skb_shinfo(skb)->destructor_arg;
- xsk_addr->num_descs++;
- }
+ skb_shinfo(skb)->destructor_arg = (void *)val;
}
-static u32 xsk_get_num_desc(struct sk_buff *skb)
+static u32 xsk_get_start_addr(struct sk_buff *skb)
{
- struct xsk_addrs *xsk_addr;
+ long val = xsk_get_destructor_arg(skb);
- if (xsk_skb_destructor_is_addr(skb))
- return 1;
+ return val >> XSK_DESTRUCTOR_DESCS_SHIFT;
+}
- xsk_addr = (struct xsk_addrs *)skb_shinfo(skb)->destructor_arg;
+static void xsk_cq_write_addr(struct sk_buff *skb, u32 desc_processed)
+{
+ struct xsk_buff_pool *pool = xdp_sk(skb->sk)->pool;
+ u32 idx, addr, pos = xsk_get_start_addr(skb);
+ struct xdp_sock *xs = xdp_sk(skb->sk);
- return xsk_addr->num_descs;
+ idx = xskq_get_prod(pool->cq) + desc_processed;
+ addr = xs->lcq->desc[(pos + desc_processed) & xs->lcq->ring_mask];
+ xskq_prod_write_addr(pool->cq, idx, addr);
}
-static void xsk_cq_submit_addr_locked(struct xsk_buff_pool *pool,
- struct sk_buff *skb)
+static void xsk_cq_submit_addr_locked(struct sk_buff *skb)
{
- u32 num_descs = xsk_get_num_desc(skb);
- struct xsk_addrs *xsk_addr;
- u32 descs_processed = 0;
+ struct xsk_buff_pool *pool = xdp_sk(skb->sk)->pool;
+ u8 i, num = xsk_get_num_desc(skb);
unsigned long flags;
- u32 idx, i;
spin_lock_irqsave(&pool->cq_prod_lock, flags);
- idx = xskq_get_prod(pool->cq);
-
- if (unlikely(num_descs > 1)) {
- xsk_addr = (struct xsk_addrs *)skb_shinfo(skb)->destructor_arg;
-
- for (i = 0; i < num_descs; i++) {
- xskq_prod_write_addr(pool->cq, idx + descs_processed,
- xsk_addr->addrs[i]);
- descs_processed++;
- }
- kmem_cache_free(xsk_tx_generic_cache, xsk_addr);
- } else {
- xskq_prod_write_addr(pool->cq, idx,
- xsk_skb_destructor_get_addr(skb));
- descs_processed++;
- }
- xskq_prod_submit_n(pool->cq, descs_processed);
+ for (i = 0; i < num; i++)
+ xsk_cq_write_addr(skb, i);
+ xskq_prod_submit_n(pool->cq, num);
spin_unlock_irqrestore(&pool->cq_prod_lock, flags);
}
@@ -634,30 +638,23 @@ void xsk_destruct_skb(struct sk_buff *skb)
*compl->tx_timestamp = ktime_get_tai_fast_ns();
}
- xsk_cq_submit_addr_locked(xdp_sk(skb->sk)->pool, skb);
+ xsk_cq_submit_addr_locked(skb);
sock_wfree(skb);
}
-static void xsk_skb_init_misc(struct sk_buff *skb, struct xdp_sock *xs,
- u64 addr)
+static void xsk_skb_init_misc(struct sk_buff *skb, struct xdp_sock *xs)
{
skb->dev = xs->dev;
skb->priority = READ_ONCE(xs->sk.sk_priority);
skb->mark = READ_ONCE(xs->sk.sk_mark);
skb->destructor = xsk_destruct_skb;
- xsk_skb_destructor_set_addr(skb, addr);
+ xsk_skb_destructor_set_addr(skb, xs);
}
static void xsk_consume_skb(struct sk_buff *skb)
{
struct xdp_sock *xs = xdp_sk(skb->sk);
u32 num_descs = xsk_get_num_desc(skb);
- struct xsk_addrs *xsk_addr;
-
- if (unlikely(num_descs > 1)) {
- xsk_addr = (struct xsk_addrs *)skb_shinfo(skb)->destructor_arg;
- kmem_cache_free(xsk_tx_generic_cache, xsk_addr);
- }
skb->destructor = sock_wfree;
xsk_cq_cancel_locked(xs->pool, num_descs);
@@ -734,33 +731,12 @@ static struct sk_buff *xsk_build_skb_zerocopy(struct xdp_sock *xs,
skb_reserve(skb, hr);
- xsk_skb_init_misc(skb, xs, desc->addr);
+ xsk_skb_init_misc(skb, xs);
if (desc->options & XDP_TX_METADATA) {
err = xsk_skb_metadata(skb, buffer, desc, pool, hr);
if (unlikely(err))
return ERR_PTR(err);
}
- } else {
- struct xsk_addrs *xsk_addr;
-
- if (xsk_skb_destructor_is_addr(skb)) {
- xsk_addr = kmem_cache_zalloc(xsk_tx_generic_cache,
- GFP_KERNEL);
- if (!xsk_addr)
- return ERR_PTR(-ENOMEM);
-
- xsk_addr->num_descs = 1;
- xsk_addr->addrs[0] = xsk_skb_destructor_get_addr(skb);
- skb_shinfo(skb)->destructor_arg = (void *)xsk_addr;
- } else {
- xsk_addr = (struct xsk_addrs *)skb_shinfo(skb)->destructor_arg;
- }
-
- /* in case of -EOVERFLOW that could happen below,
- * xsk_consume_skb() will release this node as whole skb
- * would be dropped, which implies freeing all list elements
- */
- xsk_addr->addrs[xsk_addr->num_descs] = desc->addr;
}
len = desc->len;
@@ -828,7 +804,7 @@ static struct sk_buff *xsk_build_skb(struct xdp_sock *xs,
if (unlikely(err))
goto free_err;
- xsk_skb_init_misc(skb, xs, desc->addr);
+ xsk_skb_init_misc(skb, xs);
if (desc->options & XDP_TX_METADATA) {
err = xsk_skb_metadata(skb, buffer, desc,
xs->pool, hr);
@@ -837,25 +813,9 @@ static struct sk_buff *xsk_build_skb(struct xdp_sock *xs,
}
} else {
int nr_frags = skb_shinfo(skb)->nr_frags;
- struct xsk_addrs *xsk_addr;
struct page *page;
u8 *vaddr;
- if (xsk_skb_destructor_is_addr(skb)) {
- xsk_addr = kmem_cache_zalloc(xsk_tx_generic_cache,
- GFP_KERNEL);
- if (!xsk_addr) {
- err = -ENOMEM;
- goto free_err;
- }
-
- xsk_addr->num_descs = 1;
- xsk_addr->addrs[0] = xsk_skb_destructor_get_addr(skb);
- skb_shinfo(skb)->destructor_arg = (void *)xsk_addr;
- } else {
- xsk_addr = (struct xsk_addrs *)skb_shinfo(skb)->destructor_arg;
- }
-
if (unlikely(nr_frags == (MAX_SKB_FRAGS - 1) && xp_mb_desc(desc))) {
err = -EOVERFLOW;
goto free_err;
@@ -873,8 +833,6 @@ static struct sk_buff *xsk_build_skb(struct xdp_sock *xs,
skb_add_rx_frag(skb, nr_frags, page, 0, len, PAGE_SIZE);
refcount_add(PAGE_SIZE, &xs->sk.sk_wmem_alloc);
-
- xsk_addr->addrs[xsk_addr->num_descs] = desc->addr;
}
}
@@ -931,7 +889,7 @@ static int __xsk_generic_xmit(struct sock *sk)
* if there is space in it. This avoids having to implement
* any buffering in the Tx path.
*/
- err = xsk_cq_reserve_locked(xs->pool);
+ err = xsk_cq_reserve_addr_locked(xs, desc.addr);
if (err) {
err = -EAGAIN;
goto out;
@@ -1984,18 +1942,8 @@ static int __init xsk_init(void)
if (err)
goto out_pernet;
- xsk_tx_generic_cache = kmem_cache_create("xsk_generic_xmit_cache",
- sizeof(struct xsk_addrs),
- 0, SLAB_HWCACHE_ALIGN, NULL);
- if (!xsk_tx_generic_cache) {
- err = -ENOMEM;
- goto out_unreg_notif;
- }
-
return 0;
-out_unreg_notif:
- unregister_netdevice_notifier(&xsk_netdev_notifier);
out_pernet:
unregister_pernet_subsys(&xsk_net_ops);
out_sk:
--
2.41.3
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH bpf-next v2 1/2] xsk: introduce local_cq for each af_xdp socket
2025-12-16 5:26 ` [PATCH bpf-next v2 1/2] xsk: introduce local_cq for each af_xdp socket Jason Xing
@ 2025-12-16 5:46 ` bot+bpf-ci
2025-12-16 6:18 ` Jason Xing
0 siblings, 1 reply; 5+ messages in thread
From: bot+bpf-ci @ 2025-12-16 5:46 UTC (permalink / raw)
To: kerneljasonxing, davem, edumazet, kuba, pabeni, bjorn,
magnus.karlsson, maciej.fijalkowski, jonathan.lemon, sdf, ast,
daniel, hawk, john.fastabend
Cc: bpf, netdev, kernelxing, ast, andrii, daniel, martin.lau, eddyz87,
yonghong.song, clm, ihor.solodrai
[-- Attachment #1: Type: text/plain, Size: 3433 bytes --]
> diff --git a/include/net/xdp_sock.h b/include/net/xdp_sock.h
> index 23e8861e8b25..c53ab2609d8c 100644
> --- a/include/net/xdp_sock.h
> +++ b/include/net/xdp_sock.h
> @@ -45,6 +45,12 @@ struct xsk_map {
> struct xdp_sock __rcu *xsk_map[];
> };
>
> +struct local_cq {
> + u32 prod ____cacheline_aligned_in_smp;
> + u32 ring_mask ____cacheline_aligned_in_smp;
> + u64 desc[] ____cacheline_aligned_in_smp;
> +};
> +
> struct xdp_sock {
> /* struct sock must be the first member of struct xdp_sock */
> struct sock sk;
> @@ -89,6 +95,8 @@ struct xdp_sock {
> struct mutex mutex;
> struct xsk_queue *fq_tmp; /* Only as tmp storage before bind */
> struct xsk_queue *cq_tmp; /* Only as tmp storage before bind */
> + /* Maintain addr(s) of descriptors locally */
> + struct local_cq *lcq;
> };
[ ... ]
> diff --git a/net/xdp/xsk.c b/net/xdp/xsk.c
> index f093c3453f64..9b637d5e4528 100644
> --- a/net/xdp/xsk.c
> +++ b/net/xdp/xsk.c
> @@ -1212,6 +1212,30 @@ static void xsk_delete_from_maps(struct xdp_sock *xs)
> }
> }
>
> +/* Initialize local compeletion queue for each xsk */
> +static int xsk_init_local_cq(struct xdp_sock *xs)
> +{
> + struct xsk_queue *cq = xs->pool->cq;
> + size_t size;
> +
> + if (!cq || !cq->nentries)
> + return -EINVAL;
> +
> + size = struct_size_t(struct local_cq, desc, cq->nentries);
> + xs->lcq = vmalloc(size);
> + if (!xs->lcq)
> + return -ENOMEM;
> + xs->lcq->ring_mask = cq->nentries - 1;
> + xs->lcq->prod = 0;
> +
> + return 0;
> +}
> +
> +static void xsk_clear_local_cq(struct xdp_sock *xs)
> +{
> + vfree(xs->lcq);
Can this lead to a double-free? When xsk_bind() fails after
xsk_init_local_cq() succeeds, xsk_clear_local_cq() is called in the
error path, freeing xs->lcq. However, xs->lcq is not set to NULL after
the vfree(). Later when the socket is closed, xsk_release() calls
xsk_clear_local_cq() again, causing vfree() to be called on the
already-freed pointer.
The path would be: xsk_bind()->xsk_init_local_cq() succeeds, allocating
xs->lcq. Then xp_assign_dev_shared() fails, triggering the error path
that calls xsk_clear_local_cq(). The bind fails and returns to userspace.
User closes the socket, triggering xsk_release()->xsk_clear_local_cq(),
which calls vfree() on the dangling xs->lcq pointer.
Should xs->lcq be set to NULL after the vfree to prevent this double-free?
> +}
> +
> static int xsk_release(struct socket *sock)
> {
> struct sock *sk = sock->sk;
> @@ -1241,6 +1265,7 @@ static int xsk_release(struct socket *sock)
> xskq_destroy(xs->tx);
> xskq_destroy(xs->fq_tmp);
> xskq_destroy(xs->cq_tmp);
> + xsk_clear_local_cq(xs);
>
> sock_orphan(sk);
> sock->sk = NULL;
[ ... ]
> @@ -1360,9 +1385,18 @@ static int xsk_bind(struct socket *sock, struct sockaddr_unsized *addr, int addr
> goto out_unlock;
> }
>
> + err = xsk_init_local_cq(xs);
> + if (err) {
> + xp_destroy(xs->pool);
> + xs->pool = NULL;
> + sockfd_put(sock);
> + goto out_unlock;
> + }
> +
> err = xp_assign_dev_shared(xs->pool, umem_xs, dev,
> qid);
> if (err) {
> + xsk_clear_local_cq(xs);
> xp_destroy(xs->pool);
> xs->pool = NULL;
> sockfd_put(sock);
[ ... ]
---
AI reviewed your patch. Please fix the bug or email reply why it's not a bug.
See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md
CI run summary: https://github.com/kernel-patches/bpf/actions/runs/20257706446
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH bpf-next v2 1/2] xsk: introduce local_cq for each af_xdp socket
2025-12-16 5:46 ` bot+bpf-ci
@ 2025-12-16 6:18 ` Jason Xing
0 siblings, 0 replies; 5+ messages in thread
From: Jason Xing @ 2025-12-16 6:18 UTC (permalink / raw)
To: bot+bpf-ci
Cc: davem, edumazet, kuba, pabeni, bjorn, magnus.karlsson,
maciej.fijalkowski, jonathan.lemon, sdf, ast, daniel, hawk,
john.fastabend, bpf, netdev, kernelxing, andrii, martin.lau,
eddyz87, yonghong.song, clm, ihor.solodrai
On Tue, Dec 16, 2025 at 1:46 PM <bot+bpf-ci@kernel.org> wrote:
>
> > diff --git a/include/net/xdp_sock.h b/include/net/xdp_sock.h
> > index 23e8861e8b25..c53ab2609d8c 100644
> > --- a/include/net/xdp_sock.h
> > +++ b/include/net/xdp_sock.h
> > @@ -45,6 +45,12 @@ struct xsk_map {
> > struct xdp_sock __rcu *xsk_map[];
> > };
> >
> > +struct local_cq {
> > + u32 prod ____cacheline_aligned_in_smp;
> > + u32 ring_mask ____cacheline_aligned_in_smp;
> > + u64 desc[] ____cacheline_aligned_in_smp;
> > +};
> > +
> > struct xdp_sock {
> > /* struct sock must be the first member of struct xdp_sock */
> > struct sock sk;
> > @@ -89,6 +95,8 @@ struct xdp_sock {
> > struct mutex mutex;
> > struct xsk_queue *fq_tmp; /* Only as tmp storage before bind */
> > struct xsk_queue *cq_tmp; /* Only as tmp storage before bind */
> > + /* Maintain addr(s) of descriptors locally */
> > + struct local_cq *lcq;
> > };
>
> [ ... ]
>
> > diff --git a/net/xdp/xsk.c b/net/xdp/xsk.c
> > index f093c3453f64..9b637d5e4528 100644
> > --- a/net/xdp/xsk.c
> > +++ b/net/xdp/xsk.c
> > @@ -1212,6 +1212,30 @@ static void xsk_delete_from_maps(struct xdp_sock *xs)
> > }
> > }
> >
> > +/* Initialize local compeletion queue for each xsk */
> > +static int xsk_init_local_cq(struct xdp_sock *xs)
> > +{
> > + struct xsk_queue *cq = xs->pool->cq;
> > + size_t size;
> > +
> > + if (!cq || !cq->nentries)
> > + return -EINVAL;
> > +
> > + size = struct_size_t(struct local_cq, desc, cq->nentries);
> > + xs->lcq = vmalloc(size);
> > + if (!xs->lcq)
> > + return -ENOMEM;
> > + xs->lcq->ring_mask = cq->nentries - 1;
> > + xs->lcq->prod = 0;
> > +
> > + return 0;
> > +}
> > +
> > +static void xsk_clear_local_cq(struct xdp_sock *xs)
> > +{
> > + vfree(xs->lcq);
>
> Can this lead to a double-free? When xsk_bind() fails after
> xsk_init_local_cq() succeeds, xsk_clear_local_cq() is called in the
> error path, freeing xs->lcq. However, xs->lcq is not set to NULL after
> the vfree(). Later when the socket is closed, xsk_release() calls
> xsk_clear_local_cq() again, causing vfree() to be called on the
> already-freed pointer.
>
> The path would be: xsk_bind()->xsk_init_local_cq() succeeds, allocating
> xs->lcq. Then xp_assign_dev_shared() fails, triggering the error path
> that calls xsk_clear_local_cq(). The bind fails and returns to userspace.
> User closes the socket, triggering xsk_release()->xsk_clear_local_cq(),
> which calls vfree() on the dangling xs->lcq pointer.
>
> Should xs->lcq be set to NULL after the vfree to prevent this double-free?
Exactly. Thanks. Will fix it.
Now it's time, I think, to run the AI reviewer locally before posting
patches since it's quite useful to spot some corner cases...
Thanks,
Jason
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-12-16 6:19 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-16 5:26 [PATCH bpf-next v2 0/2] xsk: introduce pre-allocated memory per xsk CQ Jason Xing
2025-12-16 5:26 ` [PATCH bpf-next v2 1/2] xsk: introduce local_cq for each af_xdp socket Jason Xing
2025-12-16 5:46 ` bot+bpf-ci
2025-12-16 6:18 ` Jason Xing
2025-12-16 5:26 ` [PATCH bpf-next v2 2/2] xsk: introduce a dedicated local completion queue for each xsk Jason Xing
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).