From: Gal Pressman <gal@nvidia.com>
To: Michal Kubecek <mkubecek@suse.cz>,
"John W. Linville" <linville@tuxdriver.com>,
<netdev@vger.kernel.org>
Cc: Gal Pressman <gal@nvidia.com>, Tariq Toukan <tariqt@nvidia.com>
Subject: [PATCH ethtool] ethtool.spec: Add AppStream metainfo file to %files section
Date: Tue, 16 Dec 2025 16:02:38 +0200 [thread overview]
Message-ID: <20251216140238.3770737-1-gal@nvidia.com> (raw)
The cited commit added the metainfo file and configured it to be
installed via Makefile.am, but forgot to update ethtool.spec.in.
This causes RPM builds to fail with:
error: Installed (but unpackaged) file(s) found:
/usr/share/metainfo/org.kernel.software.network.ethtool.metainfo.xml
Add the missing file to the %files section.
Fixes: 02d505bba6fe ("Add AppStream metainfo XML with modalias documented supported hardware.")
Reviewed-by: Tariq Toukan <tariqt@nvidia.com>
Signed-off-by: Gal Pressman <gal@nvidia.com>
---
ethtool.spec.in | 1 +
1 file changed, 1 insertion(+)
diff --git a/ethtool.spec.in b/ethtool.spec.in
index 75f9be6aafa6..f5fadf26fa64 100644
--- a/ethtool.spec.in
+++ b/ethtool.spec.in
@@ -35,6 +35,7 @@ make install DESTDIR=${RPM_BUILD_ROOT}
%{_sbindir}/ethtool
%{_mandir}/man8/ethtool.8*
%{_datadir}/bash-completion/completions/ethtool
+%{_datadir}/metainfo/org.kernel.software.network.ethtool.metainfo.xml
%doc AUTHORS COPYING NEWS README
--
2.40.1
reply other threads:[~2025-12-16 14:02 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251216140238.3770737-1-gal@nvidia.com \
--to=gal@nvidia.com \
--cc=linville@tuxdriver.com \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).