netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH ethtool] ethtool.spec: Add AppStream metainfo file to %files section
@ 2025-12-16 14:02 Gal Pressman
  0 siblings, 0 replies; only message in thread
From: Gal Pressman @ 2025-12-16 14:02 UTC (permalink / raw)
  To: Michal Kubecek, John W. Linville, netdev; +Cc: Gal Pressman, Tariq Toukan

The cited commit added the metainfo file and configured it to be
installed via Makefile.am, but forgot to update ethtool.spec.in.
This causes RPM builds to fail with:

  error: Installed (but unpackaged) file(s) found:
     /usr/share/metainfo/org.kernel.software.network.ethtool.metainfo.xml

Add the missing file to the %files section.

Fixes: 02d505bba6fe ("Add AppStream metainfo XML with modalias documented supported hardware.")
Reviewed-by: Tariq Toukan <tariqt@nvidia.com>
Signed-off-by: Gal Pressman <gal@nvidia.com>
---
 ethtool.spec.in | 1 +
 1 file changed, 1 insertion(+)

diff --git a/ethtool.spec.in b/ethtool.spec.in
index 75f9be6aafa6..f5fadf26fa64 100644
--- a/ethtool.spec.in
+++ b/ethtool.spec.in
@@ -35,6 +35,7 @@ make install DESTDIR=${RPM_BUILD_ROOT}
 %{_sbindir}/ethtool
 %{_mandir}/man8/ethtool.8*
 %{_datadir}/bash-completion/completions/ethtool
+%{_datadir}/metainfo/org.kernel.software.network.ethtool.metainfo.xml
 %doc AUTHORS COPYING NEWS README
 
 
-- 
2.40.1


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2025-12-16 14:02 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-16 14:02 [PATCH ethtool] ethtool.spec: Add AppStream metainfo file to %files section Gal Pressman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).