From: Stephen Hemminger <stephen@networkplumber.org>
To: Manas Ghandat <ghandatmanas@gmail.com>
Cc: xiyou.wangcong@gmail.com, Jiri Pirko <jiri@resnulli.us>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
netdev@vger.kernel.org
Subject: Re: net/sched: Fix divide error in tabledist
Date: Sun, 21 Dec 2025 09:03:10 -0800 [thread overview]
Message-ID: <20251221090310.60bc803d@phoenix.local> (raw)
In-Reply-To: <166583a8-272f-4e93-890e-3dabfa0b2390@gmail.com>
On Wed, 17 Dec 2025 23:57:40 +0530
Manas Ghandat <ghandatmanas@gmail.com> wrote:
> Just a friendly reminder
>
> On 12/12/25 20:47, Manas Ghandat wrote:
> >
> > On 12/12/25 13:48, Stephen Hemminger wrote:
> >> The whole netem_in_tree check is problematic as well.
> > Can you mention the issues. Maybe I can include that in my patch as well.
> >> Your mail system is corrupting the patch.
> > I will resend the patch.
> >> Is this the same as earlier patch
> > I have just moved the check before the values in qdisc are changed.
> > This would prevent the values being affected in case we bail out
> > taking the error path.
The check_netem_in_tree code caused a regression where some valid configurations
using multiple queues are HTB stopped working. A better solution is needed
and Cong et al are working on it.
prev parent reply other threads:[~2025-12-21 17:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-11 18:06 net/sched: Fix divide error in tabledist Manas Ghandat
2025-12-12 8:18 ` Stephen Hemminger
2025-12-12 15:17 ` Manas Ghandat
2025-12-17 18:27 ` Manas Ghandat
2025-12-21 17:03 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251221090310.60bc803d@phoenix.local \
--to=stephen@networkplumber.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=ghandatmanas@gmail.com \
--cc=horms@kernel.org \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).