From: "Michael S. Tsirkin" <mst@redhat.com>
To: Bui Quang Minh <minhquangbui99@gmail.com>
Cc: netdev@vger.kernel.org, "Jason Wang" <jasowang@redhat.com>,
"Xuan Zhuo" <xuanzhuo@linux.alibaba.com>,
"Eugenio Pérez" <eperezma@redhat.com>,
"Andrew Lunn" <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Alexei Starovoitov" <ast@kernel.org>,
"Daniel Borkmann" <daniel@iogearbox.net>,
"Jesper Dangaard Brouer" <hawk@kernel.org>,
"John Fastabend" <john.fastabend@gmail.com>,
"Stanislav Fomichev" <sdf@fomichev.me>,
virtualization@lists.linux.dev, linux-kernel@vger.kernel.org,
bpf@vger.kernel.org
Subject: Re: [PATCH net 1/3] virtio-net: make refill work a per receive queue work
Date: Tue, 23 Dec 2025 20:34:54 -0500 [thread overview]
Message-ID: <20251223203310-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20251223152533.24364-2-minhquangbui99@gmail.com>
> static void virtnet_rx_pause(struct virtnet_info *vi, struct receive_queue *rq)
> @@ -3463,8 +3444,8 @@ static void virtnet_rx_pause(struct virtnet_info *vi, struct receive_queue *rq)
> * Make sure refill_work does not run concurrently to
> * avoid napi_disable race which leads to deadlock.
> */
> - disable_delayed_refill(vi);
> - cancel_delayed_work_sync(&vi->refill);
> + disable_delayed_refill(rq);
> + cancel_delayed_work_sync(&rq->refill);
> __virtnet_rx_pause(vi, rq);
> }
>
disable_delayed_refill is always followed by cancel_delayed_work_sync.
Just put cancel into disable, and reduce code duplication.
--
MST
next prev parent reply other threads:[~2025-12-24 1:35 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-23 15:25 [PATCH net 0/3] virtio-net: fix the deadlock when disabling rx NAPI Bui Quang Minh
2025-12-23 15:25 ` [PATCH net 1/3] virtio-net: make refill work a per receive queue work Bui Quang Minh
2025-12-24 0:52 ` Jason Wang
2025-12-24 1:37 ` Xuan Zhuo
2025-12-24 1:47 ` Michael S. Tsirkin
2025-12-24 16:49 ` Bui Quang Minh
2025-12-25 15:55 ` Bui Quang Minh
2025-12-25 16:27 ` Michael S. Tsirkin
2025-12-25 7:33 ` Jason Wang
2025-12-25 16:27 ` Michael S. Tsirkin
2025-12-26 1:31 ` Jason Wang
2025-12-26 7:37 ` Michael S. Tsirkin
2025-12-29 2:57 ` Jason Wang
2025-12-30 16:28 ` Bui Quang Minh
2025-12-30 16:44 ` Michael S. Tsirkin
2025-12-24 16:43 ` Bui Quang Minh
2025-12-24 1:34 ` Michael S. Tsirkin [this message]
2025-12-24 10:19 ` Michael S. Tsirkin
2025-12-24 17:03 ` Bui Quang Minh
2025-12-23 15:25 ` [PATCH net 2/3] virtio-net: ensure rx NAPI is enabled before enabling refill work Bui Quang Minh
2025-12-24 1:45 ` Michael S. Tsirkin
2025-12-24 17:49 ` Bui Quang Minh
2025-12-24 10:20 ` Michael S. Tsirkin
2025-12-23 15:25 ` [PATCH net 3/3] virtio-net: schedule the pending refill work after being enabled Bui Quang Minh
2025-12-24 10:17 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251223203310-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=andrew+netdev@lunn.ch \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eperezma@redhat.com \
--cc=hawk@kernel.org \
--cc=jasowang@redhat.com \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=minhquangbui99@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
--cc=virtualization@lists.linux.dev \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).