From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Robert Marko <robert.marko@sartura.hr>,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
nicolas.ferre@microchip.com, claudiu.beznea@tuxon.dev,
herbert@gondor.apana.org.au, davem@davemloft.net,
vkoul@kernel.org, andi.shyti@kernel.org, lee@kernel.org,
andrew+netdev@lunn.ch, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, linusw@kernel.org,
Steen.Hegelund@microchip.com, daniel.machon@microchip.com,
UNGLinuxDriver@microchip.com, olivia@selenic.com,
radu_nicolae.pirea@upb.ro, richard.genoud@bootlin.com,
gregkh@linuxfoundation.org, jirislaby@kernel.org,
broonie@kernel.org, mturquette@baylibre.com, sboyd@kernel.org,
lars.povlsen@microchip.com, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org,
dmaengine@vger.kernel.org, linux-i2c@vger.kernel.org,
netdev@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-spi@vger.kernel.org, linux-serial@vger.kernel.org,
linux-usb@vger.kernel.org, linux-clk@vger.kernel.org,
luka.perkov@sartura.hr
Subject: Re: [PATCH v3 01/15] include: dt-bindings: add LAN969x clock bindings
Date: Thu, 25 Dec 2025 17:24:55 +0100 [thread overview]
Message-ID: <2025122516245554f59e2e@mail.local> (raw)
In-Reply-To: <d210552f-c8bf-4084-9317-b743075d9946@kernel.org>
On 25/12/2025 09:47:34+0100, Krzysztof Kozlowski wrote:
> On 24/12/2025 15:01, Robert Marko wrote:
> > On Wed, Dec 24, 2025 at 2:05 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> >>
> >> On 24/12/2025 11:30, Robert Marko wrote:
> >>> On Wed, Dec 24, 2025 at 11:21 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> >>>>
> >>>> On Tue, Dec 23, 2025 at 09:16:12PM +0100, Robert Marko wrote:
> >>>>> Add the required LAN969x clock bindings.
> >>>>
> >>>> I do not see clock bindings actually here. Where is the actual binding?
> >>>> Commit msg does not help me at all to understand why you are doing this
> >>>> without actual required bindings.
> >>>
> >>> I guess it is a bit confusing, there is no schema here, these are the
> >>> clock indexes that
> >>> reside in dt-bindings and are used by the SoC DTSI.
> >>
> >> I understand as not used by drivers? Then no ABI and there is no point
> >> in putting them into bindings.
> >
> > It is not included by the driver directly, but it requires these exact
> > indexes to be passed
> > so its effectively ABI.
>
> How it requires the exact index? In what way? I do not see anything in
> the gck driver using/relying on these values. Nothing. Please point me
> to the line which directly uses these values.... or how many times I
> will need to write this is not ABI?
>
The index here is the exact id that needs to be set in the PMC_PCR
register and so it is dictated by the hardware.
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2025-12-25 16:25 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-23 20:16 [PATCH v3 00/15] Add support for Microchip LAN969x Robert Marko
2025-12-23 20:16 ` [PATCH v3 01/15] include: dt-bindings: add LAN969x clock bindings Robert Marko
2025-12-24 10:21 ` Krzysztof Kozlowski
2025-12-24 10:30 ` Robert Marko
2025-12-24 13:05 ` Krzysztof Kozlowski
2025-12-24 14:01 ` Robert Marko
2025-12-25 8:47 ` Krzysztof Kozlowski
2025-12-25 16:24 ` Alexandre Belloni [this message]
2025-12-25 16:45 ` Alexandre Belloni
2025-12-27 11:17 ` Krzysztof Kozlowski
2025-12-29 12:07 ` Robert Marko
2025-12-29 12:46 ` Krzysztof Kozlowski
2025-12-23 20:16 ` [PATCH v3 02/15] dt-bindings: usb: Add Microchip LAN969x support Robert Marko
2025-12-23 20:16 ` [PATCH v3 03/15] dt-bindings: mfd: atmel,sama5d2-flexcom: add microchip,lan9691-flexcom Robert Marko
2025-12-23 20:16 ` [PATCH v3 04/15] dt-bindings: serial: atmel,at91-usart: add microchip,lan9691-usart Robert Marko
2025-12-23 20:16 ` [PATCH v3 05/15] dt-bindings: spi: at91: add microchip,lan9691-spi Robert Marko
2025-12-23 20:16 ` [PATCH v3 06/15] dt-bindings: i2c: atmel,at91sam: add microchip,lan9691-i2c Robert Marko
2025-12-25 20:32 ` Andi Shyti
2025-12-23 20:16 ` [PATCH v3 07/15] dt-bindings: rng: atmel,at91-trng: add microchip,lan9691-trng Robert Marko
2025-12-23 20:16 ` [PATCH v3 08/15] dt-bindings: crypto: atmel,at91sam9g46-aes: add microchip,lan9691-aes Robert Marko
2025-12-23 20:16 ` [PATCH v3 09/15] dt-bindings: crypto: atmel,at91sam9g46-sha: add microchip,lan9691-sha Robert Marko
2025-12-23 20:16 ` [PATCH v3 10/15] dt-bindings: dma: atmel: add microchip,lan9691-dma Robert Marko
2025-12-23 20:16 ` [PATCH v3 11/15] dt-bindings: net: mscc-miim: add microchip,lan9691-miim Robert Marko
2025-12-23 20:16 ` [PATCH v3 12/15] dt-bindings: pinctrl: pinctrl-microchip-sgpio: add LAN969x Robert Marko
2025-12-23 20:16 ` [PATCH v3 13/15] arm64: dts: microchip: add LAN969x support Robert Marko
2025-12-23 20:16 ` [PATCH v3 14/15] dt-bindings: arm: AT91: document EV23X71A board Robert Marko
2025-12-23 20:16 ` [PATCH v3 15/15] arm64: dts: microchip: add " Robert Marko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025122516245554f59e2e@mail.local \
--to=alexandre.belloni@bootlin.com \
--cc=Steen.Hegelund@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andi.shyti@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=broonie@kernel.org \
--cc=claudiu.beznea@tuxon.dev \
--cc=conor+dt@kernel.org \
--cc=daniel.machon@microchip.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=edumazet@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=herbert@gondor.apana.org.au \
--cc=jirislaby@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=kuba@kernel.org \
--cc=lars.povlsen@microchip.com \
--cc=lee@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=luka.perkov@sartura.hr \
--cc=mturquette@baylibre.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=olivia@selenic.com \
--cc=pabeni@redhat.com \
--cc=radu_nicolae.pirea@upb.ro \
--cc=richard.genoud@bootlin.com \
--cc=robert.marko@sartura.hr \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).