From: Cong Wang <xiyou.wangcong@gmail.com>
To: netdev@vger.kernel.org
Cc: Cong Wang <xiyou.wangcong@gmail.com>
Subject: [Patch net v6 0/8] netem: Fix skb duplication logic and prevent infinite loops
Date: Sat, 27 Dec 2025 11:41:27 -0800 [thread overview]
Message-ID: <20251227194135.1111972-1-xiyou.wangcong@gmail.com> (raw)
This patchset fixes the infinite loops due to duplication in netem, the
real root cause of this problem is enqueuing to the root qdisc, which is
now changed to enqueuing to the same qdisc. This is more reasonable,
more intuitive from users' perspective, less error-prone and more elegant
from kernel developers' perspective.
Please see more details in patch 4/8 which contains two pages of detailed
explanation including why it is safe and better.
This reverts the offending commits from William which clearly broke
mq+netem use cases, as reported by two users.
All the TC test cases pass with this patchset.
---
v6: Dropped the init_user_ns check patch
Reordered the qfq patch
Rebased to the latest -net branch
v5: Reverted the offending commits
Added a init_user_ns check (4/9)
Rebased to the latest -net branch
v4: Added a fix for qfq qdisc (2/6)
Updated 1/6 patch description
Added a patch to update the enqueue reentrant behaviour tests
v3: Fixed the root cause of enqueuing to root
Switched back to netem_skb_cb safely
Added two more test cases
v2: Fixed a typo
Improved tdc selftest to check sent bytes
Cong Wang (8):
net_sched: Check the return value of qfq_choose_next_agg()
Revert "net/sched: Restrict conditions for adding duplicating netems
to qdisc tree"
Revert "selftests/tc-testing: Add tests for restrictions on netem
duplication"
net_sched: Implement the right netem duplication behavior
selftests/tc-testing: Add a nested netem duplicate test
selftests/tc-testing: Add a test case for piro with netem duplicate
selftests/tc-testing: Add a test case for mq with netem duplicate
selftests/tc-testing: Update test cases with netem duplicate
net/sched/sch_netem.c | 66 +++-------
net/sched/sch_qfq.c | 2 +
.../tc-testing/tc-tests/infra/qdiscs.json | 115 +++++++++++++-----
.../tc-testing/tc-tests/qdiscs/netem.json | 90 +++-----------
4 files changed, 120 insertions(+), 153 deletions(-)
--
2.34.1
next reply other threads:[~2025-12-27 19:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-27 19:41 Cong Wang [this message]
2025-12-27 19:41 ` [Patch net v6 1/8] net_sched: Check the return value of qfq_choose_next_agg() Cong Wang
2025-12-27 19:41 ` [Patch net v6 2/8] Revert "net/sched: Restrict conditions for adding duplicating netems to qdisc tree" Cong Wang
2025-12-27 19:41 ` [Patch net v6 3/8] Revert "selftests/tc-testing: Add tests for restrictions on netem duplication" Cong Wang
2025-12-27 19:41 ` [Patch net v6 4/8] net_sched: Implement the right netem duplication behavior Cong Wang
2025-12-27 19:41 ` [Patch net v6 5/8] selftests/tc-testing: Add a nested netem duplicate test Cong Wang
2025-12-27 19:41 ` [Patch net v6 6/8] selftests/tc-testing: Add a test case for piro with netem duplicate Cong Wang
2025-12-27 19:41 ` [Patch net v6 7/8] selftests/tc-testing: Add a test case for mq " Cong Wang
2025-12-27 19:41 ` [Patch net v6 8/8] selftests/tc-testing: Update test cases " Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251227194135.1111972-1-xiyou.wangcong@gmail.com \
--to=xiyou.wangcong@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).