From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Jerry Wu <w.7erry@foxmail.com>
Cc: UNGLinuxDriver@microchip.com, alexandre.belloni@bootlin.com,
andrew+netdev@lunn.ch, christophe.jaillet@wanadoo.fr,
claudiu.manoil@nxp.com, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, pabeni@redhat.com
Subject: Re: [PATCH net v3] net: mscc: ocelot: Fix crash when adding interface under a lag
Date: Sun, 28 Dec 2025 21:40:57 +0200 [thread overview]
Message-ID: <20251228194057.pct2a4n7pnpmmcfr@skbuf> (raw)
In-Reply-To: <tencent_75EF812B305E26B0869C673DD1160866C90A@qq.com> <tencent_75EF812B305E26B0869C673DD1160866C90A@qq.com>
On Thu, Dec 25, 2025 at 08:36:17PM +0000, Jerry Wu wrote:
> Commit 15faa1f67ab4 ("lan966x: Fix crash when adding interface under a lag")
> fixed a similar issue in the lan966x driver caused by a NULL pointer dereference.
> The ocelot_set_aggr_pgids() function in the ocelot driver has similar logic
> and is susceptible to the same crash.
>
> This issue specifically affects the ocelot_vsc7514.c frontend, which leaves
> unused ports as NULL pointers. The felix_vsc9959.c frontend is unaffected as
> it uses the DSA framework which registers all ports.
>
> Fix this by checking if the port pointer is valid before accessing it.
>
> Fixes: 528d3f190c98 ("net: mscc: ocelot: drop the use of the "lags" array")
> Signed-off-by: Jerry Wu <w.7erry@foxmail.com>
> ---
Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Thanks!
prev parent reply other threads:[~2025-12-28 19:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-20 19:01 [PATCH net v2] net: mscc: ocelot: Fix crash when adding interface under a lag Jerry Wu
2025-12-20 19:56 ` Vladimir Oltean
2025-12-20 20:00 ` Christophe JAILLET
2025-12-20 20:36 ` Jerry Wu
2025-12-20 21:08 ` Vladimir Oltean
2025-12-25 20:36 ` [PATCH net v3] " Jerry Wu
2025-12-28 19:40 ` Vladimir Oltean [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251228194057.pct2a4n7pnpmmcfr@skbuf \
--to=vladimir.oltean@nxp.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andrew+netdev@lunn.ch \
--cc=christophe.jaillet@wanadoo.fr \
--cc=claudiu.manoil@nxp.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=w.7erry@foxmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).