From: Jakub Kicinski <kuba@kernel.org>
To: Junjie Cao <junjie.cao@intel.com>
Cc: pabeni@redhat.com, davem@davemloft.net, edumazet@google.com,
syzbot+14afda08dc3484d5db82@syzkaller.appspotmail.com,
horms@kernel.org, linux-hams@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
syzkaller-bugs@googlegroups.com, stable@vger.kernel.org
Subject: Re: [PATCH 1/2] netrom: fix possible deadlock in nr_rt_device_down
Date: Fri, 2 Jan 2026 12:46:46 -0800 [thread overview]
Message-ID: <20260102124646.04dd56af@kernel.org> (raw)
In-Reply-To: <20251204090905.28663-2-junjie.cao@intel.com>
On Thu, 4 Dec 2025 17:09:04 +0800 Junjie Cao wrote:
> - struct nr_node *t = NULL;
> + struct nr_node *t = NULL;
AFAICT your fixes were archived before any reviewer had a chance to
take a look (perhaps due to LPC / Maintainer Summit). Could you repost,
and when you do drop the whitespace cleanups from this patch? There
should be no whitespace cleanups in fixes..
Have you written a test to exercise these code paths by any chance?
Adding one would be great.
next prev parent reply other threads:[~2026-01-02 20:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-04 9:09 [PATCH v2 0/2] netrom: fix deadlock and refcount leak in nr_rt_device_down Junjie Cao
2025-12-04 9:09 ` [PATCH 1/2] netrom: fix possible deadlock " Junjie Cao
2026-01-02 20:46 ` Jakub Kicinski [this message]
2025-12-04 9:09 ` [PATCH 2/2] netrom: fix reference count leak " Junjie Cao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260102124646.04dd56af@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=junjie.cao@intel.com \
--cc=linux-hams@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stable@vger.kernel.org \
--cc=syzbot+14afda08dc3484d5db82@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).