* [PATCH net] atm: idt77252: Use sb_pool_remove()
@ 2025-12-29 11:42 Thomas Fourier
2026-01-04 17:42 ` Jakub Kicinski
0 siblings, 1 reply; 2+ messages in thread
From: Thomas Fourier @ 2025-12-29 11:42 UTC (permalink / raw)
Cc: Thomas Fourier, Chas Williams, linux-atm-general, netdev,
linux-kernel
Replacing the manual pool remove with the dedicated function.
Signed-off-by: Thomas Fourier <fourier.thomas@gmail.com>
---
drivers/atm/idt77252.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/atm/idt77252.c b/drivers/atm/idt77252.c
index f2e91b7d79f0..888695ccc2a7 100644
--- a/drivers/atm/idt77252.c
+++ b/drivers/atm/idt77252.c
@@ -1844,7 +1844,6 @@ add_rx_skb(struct idt77252_dev *card, int queue,
{
struct sk_buff *skb;
dma_addr_t paddr;
- u32 handle;
while (count--) {
skb = dev_alloc_skb(size);
@@ -1876,8 +1875,7 @@ add_rx_skb(struct idt77252_dev *card, int queue,
skb_end_pointer(skb) - skb->data, DMA_FROM_DEVICE);
outpoolrm:
- handle = IDT77252_PRV_POOL(skb);
- card->sbpool[POOL_QUEUE(handle)].skb[POOL_INDEX(handle)] = NULL;
+ sb_pool_remove(card, skb);
outfree:
dev_kfree_skb(skb);
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net] atm: idt77252: Use sb_pool_remove()
2025-12-29 11:42 [PATCH net] atm: idt77252: Use sb_pool_remove() Thomas Fourier
@ 2026-01-04 17:42 ` Jakub Kicinski
0 siblings, 0 replies; 2+ messages in thread
From: Jakub Kicinski @ 2026-01-04 17:42 UTC (permalink / raw)
To: Thomas Fourier; +Cc: Chas Williams, linux-atm-general, netdev, linux-kernel
On Mon, 29 Dec 2025 12:42:01 +0100 Thomas Fourier wrote:
> Subject: [PATCH net] atm: idt77252: Use sb_pool_remove()
>
> Replacing the manual pool remove with the dedicated function.
You need to explain the motivation for the patch.
If this is a pure code cleanup it may be not worth it as ATM is
on its deathbed, anyway.
Otherwise:
If this is a fix please add a Fixes tag
If this is not a fix please use net-next rather than net as subject tag.
--
pw-bot: cr
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-01-04 17:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-29 11:42 [PATCH net] atm: idt77252: Use sb_pool_remove() Thomas Fourier
2026-01-04 17:42 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).