From: Jakub Kicinski <kuba@kernel.org>
To: Eric Dumazet <edumazet@google.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Florian Westphal <fw@strlen.de>,
netdev@vger.kernel.org, eric.dumazet@gmail.com,
syzbot+6023ea32e206eef7920a@syzkaller.appspotmail.com,
Mazin Al Haddad <mazin@getstate.dev>
Subject: Re: [PATCH net] ip6_gre: use skb_vlan_inet_prepare() instead of pskb_inet_may_pull()
Date: Mon, 5 Jan 2026 12:40:06 -0800 [thread overview]
Message-ID: <20260105124006.299e6b86@kernel.org> (raw)
In-Reply-To: <20260105100330.2258612-1-edumazet@google.com>
On Mon, 5 Jan 2026 10:03:30 +0000 Eric Dumazet wrote:
> I added skb_vlan_inet_prepare() helper in the cited commit, hinting
> that we would need to use it more broadly.
This appears to break all GRE tests, unfortunately.
Conditions need to be inverted?
--
pw-bot: cr
next prev parent reply other threads:[~2026-01-05 20:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-05 10:03 [PATCH net] ip6_gre: use skb_vlan_inet_prepare() instead of pskb_inet_may_pull() Eric Dumazet
2026-01-05 20:40 ` Jakub Kicinski [this message]
2026-01-05 20:50 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260105124006.299e6b86@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=fw@strlen.de \
--cc=horms@kernel.org \
--cc=mazin@getstate.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=syzbot+6023ea32e206eef7920a@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox