From: Jakub Kicinski <kuba@kernel.org>
To: Eric Dumazet <edumazet@google.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Florian Westphal <fw@strlen.de>,
netdev@vger.kernel.org, eric.dumazet@gmail.com,
syzbot+6023ea32e206eef7920a@syzkaller.appspotmail.com,
Mazin Al Haddad <mazin@getstate.dev>
Subject: Re: [PATCH v2 net] ip6_gre: use skb_vlan_inet_prepare() instead of pskb_inet_may_pull()
Date: Tue, 6 Jan 2026 09:56:48 -0800 [thread overview]
Message-ID: <20260106095648.07a870f1@kernel.org> (raw)
In-Reply-To: <20260106144529.1424886-1-edumazet@google.com>
On Tue, 6 Jan 2026 14:45:29 +0000 Eric Dumazet wrote:
> v2: invert the conditions (Jakub)
Thanks! Much better now, but still failing
tools/testing/selftests/net/gre_gso.sh
TAP version 13
1..1
# timeout set to 3600
# selftests: net: gre_gso.sh
# 2.16 [+2.16] TEST: GREv6/v4 - copy file w/ TSO [ OK ]
# 3.16 [+1.01] 2026/01/06 10:32:57 socat[20546] W exiting on signal 15
# 3.17 [+0.01] 2026/01/06 10:32:57 socat[20546] W exiting on signal 15
# 3.17 [+0.00] TEST: GREv6/v4 - copy file w/ GSO [FAIL]
# 3.18 [+0.01] 2026/01/06 10:32:57 socat[20533] W exiting on signal 15
# 3.19 [+0.00] TEST: GREv6/v6 - copy file w/ TSO [ OK ]
# 4.19 [+1.00] 2026/01/06 10:32:59 socat[20559] W exiting on signal 15
# 4.19 [+0.01] TEST: GREv6/v6 - copy file w/ GSO [FAIL]
# 4.20 [+0.01] 2026/01/06 10:32:59 socat[20549] W exiting on signal 15
# 4.22 [+0.02] 2026/01/06 10:32:59 socat[20560] W exiting on signal 15
# 4.23 [+0.01]
# 4.23 [+0.00] Tests passed: 2
# 4.23 [+0.00] Tests failed: 2
not ok 1 selftests: net: gre_gso.sh # exit=1
https://netdev-ctrl.bots.linux.dev/logs/vmksft/net/results/461862/65-gre-gso-sh/stdout
next prev parent reply other threads:[~2026-01-06 17:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-06 14:45 [PATCH v2 net] ip6_gre: use skb_vlan_inet_prepare() instead of pskb_inet_may_pull() Eric Dumazet
2026-01-06 17:56 ` Jakub Kicinski [this message]
2026-01-06 19:33 ` Eric Dumazet
2026-01-06 20:31 ` Jakub Kicinski
2026-01-06 21:25 ` Eric Dumazet
2026-01-06 21:33 ` Eric Dumazet
2026-01-06 22:28 ` Jakub Kicinski
2026-01-07 8:46 ` Florian Westphal
2026-01-07 9:01 ` Eric Dumazet
2026-01-12 13:58 ` Simon Horman
2026-01-12 15:24 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260106095648.07a870f1@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=fw@strlen.de \
--cc=horms@kernel.org \
--cc=mazin@getstate.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=syzbot+6023ea32e206eef7920a@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox