From: Jakub Kicinski <kuba@kernel.org>
To: Gal Pressman <gal@nvidia.com>, Paolo Abeni <pabeni@redhat.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Andrew Lunn <andrew+netdev@lunn.ch>, <netdev@vger.kernel.org>,
Andrew Lunn <andrew@lunn.ch>, Simon Horman <horms@kernel.org>,
Dragos Tatulea <dtatulea@nvidia.com>
Subject: Re: [PATCH net-next] ethtool: Clarify len/n_stats fields in/out semantics
Date: Tue, 6 Jan 2026 17:48:16 -0800 [thread overview]
Message-ID: <20260106174816.0476e043@kernel.org> (raw)
In-Reply-To: <20260105163923.49104-1-gal@nvidia.com>
On Mon, 5 Jan 2026 18:39:23 +0200 Gal Pressman wrote:
> - * @n_stats: On return, the number of statistics
> + * @n_stats: On entry, the number of stats requested.
> + On return, the number of stats returned.
> * @data: Array of statistics
Missing a '*'
But stepping back we should rephrase the comment to cover both
directions instead of mechanically adding the corresponding "On entry"
FTR my recollection was that we never validated these field on entry and
if that's the case 7b07be1ff1cb6 is quite questionable, uAPI-breakage
wise.
--
pw-bot: cr
next prev parent reply other threads:[~2026-01-07 1:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-05 16:39 [PATCH net-next] ethtool: Clarify len/n_stats fields in/out semantics Gal Pressman
2026-01-07 1:48 ` Jakub Kicinski [this message]
2026-01-07 8:51 ` Gal Pressman
2026-01-08 2:39 ` Jakub Kicinski
2026-01-08 8:14 ` Gal Pressman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260106174816.0476e043@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=dtatulea@nvidia.com \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=horms@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox