From: Ethan Nelson-Moore <enelsonmoore@gmail.com>
To: netdev@vger.kernel.org
Cc: Ethan Nelson-Moore <enelsonmoore@gmail.com>
Subject: [PATCH net-next] net: usb: smsc95xx: use phy_do_ioctl_running function
Date: Tue, 6 Jan 2026 22:57:49 -0800 [thread overview]
Message-ID: <20260107065749.21800-2-enelsonmoore@gmail.com> (raw)
In-Reply-To: <20260107065749.21800-1-enelsonmoore@gmail.com>
The smsc95xx_ioctl function behaves identically to the
phy_do_ioctl_running function. Remove it and use the
phy_do_ioctl_running function directly instead.
Signed-off-by: Ethan Nelson-Moore <enelsonmoore@gmail.com>
---
drivers/net/usb/smsc95xx.c | 10 +---------
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/drivers/net/usb/smsc95xx.c b/drivers/net/usb/smsc95xx.c
index de733e0488bf..c65402d850c9 100644
--- a/drivers/net/usb/smsc95xx.c
+++ b/drivers/net/usb/smsc95xx.c
@@ -854,14 +854,6 @@ static const struct ethtool_ops smsc95xx_ethtool_ops = {
.set_pauseparam = smsc95xx_set_pauseparam,
};
-static int smsc95xx_ioctl(struct net_device *netdev, struct ifreq *rq, int cmd)
-{
- if (!netif_running(netdev))
- return -EINVAL;
-
- return phy_mii_ioctl(netdev->phydev, rq, cmd);
-}
-
static void smsc95xx_init_mac_address(struct usbnet *dev)
{
u8 addr[ETH_ALEN];
@@ -1139,7 +1131,7 @@ static const struct net_device_ops smsc95xx_netdev_ops = {
.ndo_get_stats64 = dev_get_tstats64,
.ndo_set_mac_address = eth_mac_addr,
.ndo_validate_addr = eth_validate_addr,
- .ndo_eth_ioctl = smsc95xx_ioctl,
+ .ndo_eth_ioctl = phy_do_ioctl_running,
.ndo_set_rx_mode = smsc95xx_set_multicast,
.ndo_set_features = smsc95xx_set_features,
};
--
2.43.0
next prev parent reply other threads:[~2026-01-07 6:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-07 6:57 [PATCH net-next] net: usb: introduce usbnet_mii_ioctl helper function Ethan Nelson-Moore
2026-01-07 6:57 ` Ethan Nelson-Moore [this message]
2026-01-07 17:39 ` [PATCH net-next] net: usb: smsc95xx: use phy_do_ioctl_running function Andrew Lunn
2026-01-07 17:00 ` [PATCH net-next] net: usb: introduce usbnet_mii_ioctl helper function Vadim Fedorenko
2026-01-08 2:59 ` Jakub Kicinski
-- strict thread matches above, loose matches on Subject: below --
2026-01-24 8:07 [PATCH net-next] net: usb: smsc95xx: use phy_do_ioctl_running function Ethan Nelson-Moore
2026-01-24 18:49 ` Andrew Lunn
2026-01-27 3:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260107065749.21800-2-enelsonmoore@gmail.com \
--to=enelsonmoore@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox