From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CB8E3314A65 for ; Wed, 7 Jan 2026 12:22:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767788526; cv=none; b=SezO6LLGxNcTV+9lwFA//jaFRfQlSIG1+LpQ1V9kjaZ9aBfjbErrUZclUuwJwdCmy8Z3PBxl+yv0U2oIb7KkPAoI3Opb4zDb3lSgTW7t23Ay/tcxViJAoGmh3olaVJ4A3AWOVfRsw3M1tPDMOL5ll0e8oHGYg8oAnINrpeWU2VE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767788526; c=relaxed/simple; bh=c+iz89dQ9u/g+Mi3Sy4KxY5gCEephLk7UN+j3FVY1pI=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=TWlqyDYwKhCjltWP1Kb6ZdhaHjiREVm43Ps5Pyytee6Ld2AxpWWacpRppmaBg0SdwUlUJKETFasHfFJ9OviPj2kwmqBIQRzrFsbkGZBldY9AxS/cIsbdo/cJ2lCE9NKqE3uGiIUhFiVRml9xJxmvMhXvtL3yZdlUv07Hi/Dw3f8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gu/hx+9S; arc=none smtp.client-ip=209.85.221.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gu/hx+9S" Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-43284ed32a0so972186f8f.3 for ; Wed, 07 Jan 2026 04:22:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767788522; x=1768393322; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=HYUkIIbKAWCx8zII6J6O7Hf6OJVquFHOvxvfWKIMyVg=; b=gu/hx+9Sn24bPGyN65e3nHMdAh+oIt7KUa3Qg/En1DLfGQxDvbSbWEYXGZj3/l4/r/ 3NNvqudj4rK6TSN9voLF0QgK2AsOITEG5pLOPdVP/PYp0xCCs4QrM+dKKFNYEmE/pCjS IZeVT2X1Yvw0RhHPUf6ib25rEBzhFHqwlzans7D/acyW3tzgNDX4HQQ0Ho756OmVvIAP xAFL5XvLIuoPSN3LPq9/0oIrVo7orF7A25lyhlEmxpDHgdHqu8JQQZ0Z3/9yKP1D+6el S8r5Np6si4Q78Jo7xHq9Sov3BUMnP2yH2yDJpAmms9Y/a07E2UUVvCIxz4LoL54DID6H mE6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767788522; x=1768393322; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=HYUkIIbKAWCx8zII6J6O7Hf6OJVquFHOvxvfWKIMyVg=; b=BKPCJYQwjozQYqpr7UmEYT6qi+QZuoEnL/NoQ0ZT7rK+Qs85LpmDOFzV/ilx3Innk+ 5py/GNtMIPTcpoW4jdzMRkwZc4k1Mf+XqD71V9lDULzbJOQqWgdYhoh/DRNCpxxcq//d LjlC5K4opOyeO9pJBJ0R/HiGQpuQdsU3wugY005UrVvLIxqm47PD6pwicftd3zfFJIQk opUFXPBHHBgxYg7zqveAVNRCcehLjTGRH6YQq+PqVELdcUxKFlxMKvzJ1UZ14lsxydTe SalZxInR2AlmZGczFl6Ik5Kp4n+8DAik4uUvohxSLrSfaIqs91vUR1FruHNRlS2FX6Yp lPWQ== X-Forwarded-Encrypted: i=1; AJvYcCV3jCQWkN3CZaQYHtiMEyYml00RUnOmKrTJDIA/dPMCaP1+EQFKdbftw0Wd2kXdezOi4/+oCkA=@vger.kernel.org X-Gm-Message-State: AOJu0YyjTBu1Qdci50GEETH0gxlM7aP1Ojf/NKiG4N9PB8Ep+cRy3vd7 WI3N/Ih1Pi25Gq3fQONIN0TstjrwaN3HIyCL21qyrbcjFJrb1v9c2Xr5 X-Gm-Gg: AY/fxX6hJpFKGSNktnAv7b9suKP5S+sbEcDqaoa3QVTMA7I7pp9mvAs8iEoOnzZMx4Z 8dVnc4+BVFEPdidIKYxQhB9PlXnx1Rzp5W2opXrHhmXWcPk6nbuAti7Nwh0Gg62r1LzI4rtTiFV 2kwu52yUcBhvjltUGMM6CrA43xi3TV0330CwjrEgNA6/9sMfrLo6c4kPbKRNZCSy3oFytSLHMVB VHAh3/gP8gustVILi/iWPTUvNLH21l3SD9U7KmhkeT4x0hSgEUk+m3wNpGAw1mU4BTn5dvUJeXQ hxIBSzh5kNZa7iVH6L6vkPMvNqKJIWsSHK2b3kPo63TS3MGHPI/n1dn0+8dAPgzI3WPbOJVrFG4 CdRiE7otdzKpxXC/Fv3fPbBBQWjDDDUwl+b6C/3DMR+BE8SuxC1aImS8a2+7/JGhqYL1yh1qz4z 8UREtefpBj6pxtgFGgSGoSGJJi2P5hOSoj+iTABro= X-Google-Smtp-Source: AGHT+IGQNbTjHR0E7DNfPP8RF5ekeryRTwB6i2JVxTh+kt/lodaZ5gwD4qoONHfCKGH1Jj2gq/pP0A== X-Received: by 2002:a05:6000:18a5:b0:431:8f8:7f17 with SMTP id ffacd0b85a97d-432c362830dmr3049879f8f.10.1767788521787; Wed, 07 Jan 2026 04:22:01 -0800 (PST) Received: from imac.lan ([2a02:8010:60a0:0:bc70:fb0c:12b6:3a41]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-432bd0e16f4sm10417107f8f.11.2026.01.07.04.22.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Jan 2026 04:22:01 -0800 (PST) From: Donald Hunter To: Donald Hunter , Jakub Kicinski , "David S. Miller" , Eric Dumazet , Paolo Abeni , Simon Horman , "Matthieu Baerts (NGI0)" , Gal Pressman , Jan Stancek , Hangbin Liu , Nimrod Oren , netdev@vger.kernel.org, Jonathan Corbet , =?UTF-8?q?Asbj=C3=B8rn=20Sloth=20T=C3=B8nnesen?= , Mauro Carvalho Chehab , Jacob Keller , Ruben Wauters , linux-doc@vger.kernel.org Subject: [PATCH net-next v1 00/13] tools: ynl: clean up pylint issues Date: Wed, 7 Jan 2026 12:21:30 +0000 Message-ID: <20260107122143.93810-1-donald.hunter@gmail.com> X-Mailer: git-send-email 2.52.0 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit pylint tools/net/ynl/pyynl reports >850 issues, with a rating of 8.59/10. It's hard to spot new issues or genuine code smells in all that noise. Fix the easily fixable issues and suppress the noisy warnings. pylint tools/net/ynl/pyynl ************* Module pyynl.ethtool tools/net/ynl/pyynl/ethtool.py:159:5: W0511: TODO: --show-tunnels tunnel-info-get (fixme) tools/net/ynl/pyynl/ethtool.py:160:5: W0511: TODO: --show-module module-get (fixme) tools/net/ynl/pyynl/ethtool.py:161:5: W0511: TODO: --get-plca-cfg plca-get (fixme) tools/net/ynl/pyynl/ethtool.py:162:5: W0511: TODO: --get-plca-status plca-get-status (fixme) tools/net/ynl/pyynl/ethtool.py:163:5: W0511: TODO: --show-mm mm-get (fixme) tools/net/ynl/pyynl/ethtool.py:164:5: W0511: TODO: --show-fec fec-get (fixme) tools/net/ynl/pyynl/ethtool.py:165:5: W0511: TODO: --dump-module-eerpom module-eeprom-get (fixme) tools/net/ynl/pyynl/ethtool.py:166:5: W0511: TODO: pse-get (fixme) tools/net/ynl/pyynl/ethtool.py:167:5: W0511: TODO: rss-get (fixme) tools/net/ynl/pyynl/ethtool.py:179:9: W0511: TODO: parse the bitmask (fixme) tools/net/ynl/pyynl/ethtool.py:196:9: W0511: TODO: parse the bitmask (fixme) tools/net/ynl/pyynl/ethtool.py:321:9: W0511: TODO: pass id? (fixme) tools/net/ynl/pyynl/ethtool.py:330:17: W0511: TODO: support passing the bitmask (fixme) tools/net/ynl/pyynl/ethtool.py:459:5: W0511: TODO: wol-get (fixme) ------------------------------------------------------------------ Your code has been rated at 9.97/10 (previous run: 8.59/10, +1.38) Donald Hunter (13): tools: ynl: pylint suppressions and docstrings tools: ynl: fix pylint redefinition, encoding errors tools: ynl: fix pylint exception warnings tools: ynl: fix pylint dict, indentation, long lines, uninitialised tools: ynl: fix pylint misc warnings tools: ynl: fix pylint global variable related warnings tools: ynl: fix logic errors reported by pylint tools: ynl: ethtool: fix pylint issues tools: ynl: fix pylint issues in ynl_gen_rst tools: ynl-gen-c: suppress unhelpful pylint messages tools: ynl-gen-c: fix pylint warnings for returns, unused, redefined tools: ynl-gen-c: fix pylint None, type, dict, generators, init tools: ynl-gen-c: Fix remaining pylint warnings tools/net/ynl/pyynl/cli.py | 67 +++++--- tools/net/ynl/pyynl/ethtool.py | 47 +++-- tools/net/ynl/pyynl/lib/__init__.py | 10 +- tools/net/ynl/pyynl/lib/doc_generator.py | 3 +- tools/net/ynl/pyynl/lib/nlspec.py | 77 +++++---- tools/net/ynl/pyynl/lib/ynl.py | 208 +++++++++++++---------- tools/net/ynl/pyynl/ynl_gen_c.py | 175 ++++++++++--------- tools/net/ynl/pyynl/ynl_gen_rst.py | 2 + 8 files changed, 341 insertions(+), 248 deletions(-) -- 2.52.0