* [PATCH net-next] selftests: forwarding: update PTP tcpdump patterns
@ 2026-01-07 14:53 Jakub Kicinski
2026-01-07 14:59 ` Alexander Sverdlin
2026-01-10 1:40 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Jakub Kicinski @ 2026-01-07 14:53 UTC (permalink / raw)
To: davem
Cc: netdev, edumazet, pabeni, andrew+netdev, horms, Jakub Kicinski,
shuah, vladimir.oltean, alexander.sverdlin, linux-kselftest
Recent version of tcpdump (tcpdump-4.99.6-1.fc43.x86_64) seems to have
removed the spurious space after msg type in PTP info, e.g.:
before: PTPv2, majorSdoId: 0x0, msg type : sync msg, length: 44
after: PTPv2, majorSdoId: 0x0, msg type: sync msg, length: 44
Update our patterns to match both.
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
CC: shuah@kernel.org
CC: vladimir.oltean@nxp.com
CC: alexander.sverdlin@gmail.com
CC: linux-kselftest@vger.kernel.org
---
.../net/forwarding/local_termination.sh | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/tools/testing/selftests/net/forwarding/local_termination.sh b/tools/testing/selftests/net/forwarding/local_termination.sh
index 892895659c7e..1f2bf6e81847 100755
--- a/tools/testing/selftests/net/forwarding/local_termination.sh
+++ b/tools/testing/selftests/net/forwarding/local_termination.sh
@@ -306,39 +306,39 @@ run_test()
if [ $skip_ptp = false ]; then
check_rcv $rcv_if_name "1588v2 over L2 transport, Sync" \
- "ethertype PTP (0x88f7).* PTPv2.* msg type : sync msg" \
+ "ethertype PTP (0x88f7).* PTPv2.* msg type *: sync msg" \
true "$test_name"
check_rcv $rcv_if_name "1588v2 over L2 transport, Follow-Up" \
- "ethertype PTP (0x88f7).* PTPv2.* msg type : follow up msg" \
+ "ethertype PTP (0x88f7).* PTPv2.* msg type *: follow up msg" \
true "$test_name"
check_rcv $rcv_if_name "1588v2 over L2 transport, Peer Delay Request" \
- "ethertype PTP (0x88f7).* PTPv2.* msg type : peer delay req msg" \
+ "ethertype PTP (0x88f7).* PTPv2.* msg type *: peer delay req msg" \
true "$test_name"
check_rcv $rcv_if_name "1588v2 over IPv4, Sync" \
- "ethertype IPv4 (0x0800).* PTPv2.* msg type : sync msg" \
+ "ethertype IPv4 (0x0800).* PTPv2.* msg type *: sync msg" \
true "$test_name"
check_rcv $rcv_if_name "1588v2 over IPv4, Follow-Up" \
- "ethertype IPv4 (0x0800).* PTPv2.* msg type : follow up msg" \
+ "ethertype IPv4 (0x0800).* PTPv2.* msg type *: follow up msg" \
true "$test_name"
check_rcv $rcv_if_name "1588v2 over IPv4, Peer Delay Request" \
- "ethertype IPv4 (0x0800).* PTPv2.* msg type : peer delay req msg" \
+ "ethertype IPv4 (0x0800).* PTPv2.* msg type *: peer delay req msg" \
true "$test_name"
check_rcv $rcv_if_name "1588v2 over IPv6, Sync" \
- "ethertype IPv6 (0x86dd).* PTPv2.* msg type : sync msg" \
+ "ethertype IPv6 (0x86dd).* PTPv2.* msg type *: sync msg" \
true "$test_name"
check_rcv $rcv_if_name "1588v2 over IPv6, Follow-Up" \
- "ethertype IPv6 (0x86dd).* PTPv2.* msg type : follow up msg" \
+ "ethertype IPv6 (0x86dd).* PTPv2.* msg type *: follow up msg" \
true "$test_name"
check_rcv $rcv_if_name "1588v2 over IPv6, Peer Delay Request" \
- "ethertype IPv6 (0x86dd).* PTPv2.* msg type : peer delay req msg" \
+ "ethertype IPv6 (0x86dd).* PTPv2.* msg type *: peer delay req msg" \
true "$test_name"
fi
--
2.52.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] selftests: forwarding: update PTP tcpdump patterns
2026-01-07 14:53 [PATCH net-next] selftests: forwarding: update PTP tcpdump patterns Jakub Kicinski
@ 2026-01-07 14:59 ` Alexander Sverdlin
2026-01-10 1:40 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Alexander Sverdlin @ 2026-01-07 14:59 UTC (permalink / raw)
To: Jakub Kicinski; +Cc: netdev, linux-kselftest
Hi Jakub,
On Wed, 2026-01-07 at 06:53 -0800, Jakub Kicinski wrote:
> Recent version of tcpdump (tcpdump-4.99.6-1.fc43.x86_64) seems to have
> removed the spurious space after msg type in PTP info, e.g.:
>
> before: PTPv2, majorSdoId: 0x0, msg type : sync msg, length: 44
> after: PTPv2, majorSdoId: 0x0, msg type: sync msg, length: 44
>
> Update our patterns to match both.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: Alexander Sverdlin <alexander.sverdlin@gmail.com>
> ---
> CC: shuah@kernel.org
> CC: vladimir.oltean@nxp.com
> CC: alexander.sverdlin@gmail.com
> CC: linux-kselftest@vger.kernel.org
> ---
> .../net/forwarding/local_termination.sh | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/tools/testing/selftests/net/forwarding/local_termination.sh b/tools/testing/selftests/net/forwarding/local_termination.sh
> index 892895659c7e..1f2bf6e81847 100755
> --- a/tools/testing/selftests/net/forwarding/local_termination.sh
> +++ b/tools/testing/selftests/net/forwarding/local_termination.sh
> @@ -306,39 +306,39 @@ run_test()
>
> if [ $skip_ptp = false ]; then
> check_rcv $rcv_if_name "1588v2 over L2 transport, Sync" \
> - "ethertype PTP (0x88f7).* PTPv2.* msg type : sync msg" \
> + "ethertype PTP (0x88f7).* PTPv2.* msg type *: sync msg" \
> true "$test_name"
>
> check_rcv $rcv_if_name "1588v2 over L2 transport, Follow-Up" \
> - "ethertype PTP (0x88f7).* PTPv2.* msg type : follow up msg" \
> + "ethertype PTP (0x88f7).* PTPv2.* msg type *: follow up msg" \
> true "$test_name"
>
> check_rcv $rcv_if_name "1588v2 over L2 transport, Peer Delay Request" \
> - "ethertype PTP (0x88f7).* PTPv2.* msg type : peer delay req msg" \
> + "ethertype PTP (0x88f7).* PTPv2.* msg type *: peer delay req msg" \
> true "$test_name"
>
> check_rcv $rcv_if_name "1588v2 over IPv4, Sync" \
> - "ethertype IPv4 (0x0800).* PTPv2.* msg type : sync msg" \
> + "ethertype IPv4 (0x0800).* PTPv2.* msg type *: sync msg" \
> true "$test_name"
>
> check_rcv $rcv_if_name "1588v2 over IPv4, Follow-Up" \
> - "ethertype IPv4 (0x0800).* PTPv2.* msg type : follow up msg" \
> + "ethertype IPv4 (0x0800).* PTPv2.* msg type *: follow up msg" \
> true "$test_name"
>
> check_rcv $rcv_if_name "1588v2 over IPv4, Peer Delay Request" \
> - "ethertype IPv4 (0x0800).* PTPv2.* msg type : peer delay req msg" \
> + "ethertype IPv4 (0x0800).* PTPv2.* msg type *: peer delay req msg" \
> true "$test_name"
>
> check_rcv $rcv_if_name "1588v2 over IPv6, Sync" \
> - "ethertype IPv6 (0x86dd).* PTPv2.* msg type : sync msg" \
> + "ethertype IPv6 (0x86dd).* PTPv2.* msg type *: sync msg" \
> true "$test_name"
>
> check_rcv $rcv_if_name "1588v2 over IPv6, Follow-Up" \
> - "ethertype IPv6 (0x86dd).* PTPv2.* msg type : follow up msg" \
> + "ethertype IPv6 (0x86dd).* PTPv2.* msg type *: follow up msg" \
> true "$test_name"
>
> check_rcv $rcv_if_name "1588v2 over IPv6, Peer Delay Request" \
> - "ethertype IPv6 (0x86dd).* PTPv2.* msg type : peer delay req msg" \
> + "ethertype IPv6 (0x86dd).* PTPv2.* msg type *: peer delay req msg" \
> true "$test_name"
> fi
>
--
Alexander Sverdlin.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] selftests: forwarding: update PTP tcpdump patterns
2026-01-07 14:53 [PATCH net-next] selftests: forwarding: update PTP tcpdump patterns Jakub Kicinski
2026-01-07 14:59 ` Alexander Sverdlin
@ 2026-01-10 1:40 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2026-01-10 1:40 UTC (permalink / raw)
To: Jakub Kicinski
Cc: davem, netdev, edumazet, pabeni, andrew+netdev, horms, shuah,
vladimir.oltean, alexander.sverdlin, linux-kselftest
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Wed, 7 Jan 2026 06:53:19 -0800 you wrote:
> Recent version of tcpdump (tcpdump-4.99.6-1.fc43.x86_64) seems to have
> removed the spurious space after msg type in PTP info, e.g.:
>
> before: PTPv2, majorSdoId: 0x0, msg type : sync msg, length: 44
> after: PTPv2, majorSdoId: 0x0, msg type: sync msg, length: 44
>
> Update our patterns to match both.
>
> [...]
Here is the summary with links:
- [net-next] selftests: forwarding: update PTP tcpdump patterns
https://git.kernel.org/netdev/net-next/c/68ec2b9fc59e
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-01-10 1:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-07 14:53 [PATCH net-next] selftests: forwarding: update PTP tcpdump patterns Jakub Kicinski
2026-01-07 14:59 ` Alexander Sverdlin
2026-01-10 1:40 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox