From: Jakub Kicinski <kuba@kernel.org>
To: Raju Rangoju <Raju.Rangoju@amd.com>
Cc: <netdev@vger.kernel.org>, <pabeni@redhat.com>,
<edumazet@google.com>, <davem@davemloft.net>,
<andrew+netdev@lunn.ch>, <Shyam-sundar.S-k@amd.com>,
Vishal Badole <Vishal.Badole@amd.com>
Subject: Re: [PATCH net-next] xgbe: Use netlink extack to report errors to ethtool
Date: Fri, 9 Jan 2026 06:25:21 -0800 [thread overview]
Message-ID: <20260109062521.625088cc@kernel.org> (raw)
In-Reply-To: <20260109074746.3350059-1-Raju.Rangoju@amd.com>
On Fri, 9 Jan 2026 13:17:46 +0530 Raju Rangoju wrote:
> if (ringparam->rx_mini_pending || ringparam->rx_jumbo_pending) {
> - netdev_err(netdev, "unsupported ring parameter\n");
> + NL_SET_ERR_MSG_FMT_MOD(extack, "unsupported ring parameter\n");
> return -EINVAL;
> }
There should be no \n at the end of the extack string.
Please don't use _FMT if there's no formatting going on.
--
pw-bot: cr
prev parent reply other threads:[~2026-01-09 14:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-09 7:47 [PATCH net-next] xgbe: Use netlink extack to report errors to ethtool Raju Rangoju
2026-01-09 14:25 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260109062521.625088cc@kernel.org \
--to=kuba@kernel.org \
--cc=Raju.Rangoju@amd.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=Vishal.Badole@amd.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox