From: Jakub Kicinski <kuba@kernel.org>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com,
andrew+netdev@lunn.ch, horms@kernel.org, shuah@kernel.org,
linux-kselftest@vger.kernel.org, sdf@fomichev.me,
willemb@google.com, petrm@nvidia.com,
willemdebruijn.kernel@gmail.com
Subject: Re: [PATCH net-next v2 4/6] selftests: drv-net: gro: improve feature config
Date: Sat, 10 Jan 2026 09:43:57 -0800 [thread overview]
Message-ID: <20260110094357.28921354@kernel.org> (raw)
In-Reply-To: <20260110005121.3561437-5-kuba@kernel.org>
On Fri, 9 Jan 2026 16:51:19 -0800 Jakub Kicinski wrote:
> try:
> # Disable TSO for local tests
> cfg.require_nsim() # will raise KsftXfailEx if not running on nsim
>
> - cmd(f"ethtool -K {cfg.ifname} gro on tso off")
> - cmd(f"ethtool -K {cfg.remote_ifname} gro on tso off", host=cfg.remote)
> + _set_ethtool_feat(cfg.remote_ifname, cfg.remote_feat, {"tso": False},
> + host=cfg.remote)
> except KsftXfailEx:
> pass
Looks like I haven't re-tested on netdevsim, this needs to spell out
tcp-segmentation-offload :S
--
pw-bot: cr
next prev parent reply other threads:[~2026-01-10 17:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-10 0:51 [PATCH net-next v2 0/6] selftests: drv-net: gro: enable HW GRO and LRO testing Jakub Kicinski
2026-01-10 0:51 ` [PATCH net-next v2 1/6] selftests: net: py: teach ksft_pr() multi-line safety Jakub Kicinski
2026-01-12 10:37 ` Petr Machata
2026-01-10 0:51 ` [PATCH net-next v2 2/6] selftests: net: py: teach cmd() how to print itself Jakub Kicinski
2026-01-12 10:37 ` Petr Machata
2026-01-10 0:51 ` [PATCH net-next v2 3/6] selftests: drv-net: gro: use cmd print Jakub Kicinski
2026-01-12 10:37 ` Petr Machata
2026-01-10 0:51 ` [PATCH net-next v2 4/6] selftests: drv-net: gro: improve feature config Jakub Kicinski
2026-01-10 17:43 ` Jakub Kicinski [this message]
2026-01-11 17:08 ` Willem de Bruijn
2026-01-10 0:51 ` [PATCH net-next v2 5/6] selftests: drv-net: gro: run the test against HW GRO and LRO Jakub Kicinski
2026-01-11 17:08 ` Willem de Bruijn
2026-01-10 0:51 ` [PATCH net-next v2 6/6] selftests: drv-net: gro: break out all individual test cases Jakub Kicinski
2026-01-11 17:12 ` Willem de Bruijn
2026-01-13 0:16 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260110094357.28921354@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=sdf@fomichev.me \
--cc=shuah@kernel.org \
--cc=willemb@google.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox