From: Jakub Kicinski <kuba@kernel.org>
To: Vimlesh Kumar <vimleshk@marvell.com>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<sedara@marvell.com>, <srasheed@marvell.com>, <hgani@marvell.com>,
Veerasenareddy Burru <vburru@marvell.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
"Paolo Abeni" <pabeni@redhat.com>
Subject: Re: [PATCH net-next v3] octeon_ep: reset firmware ready status
Date: Sat, 10 Jan 2026 12:13:49 -0800 [thread overview]
Message-ID: <20260110121349.25eb40ce@kernel.org> (raw)
In-Reply-To: <20260107134503.3437226-1-vimleshk@marvell.com>
On Wed, 7 Jan 2026 13:45:02 +0000 Vimlesh Kumar wrote:
> +#define CN9K_PEMX_PFX_CSX_PFCFGX(pem, pf, offset)\
> + ({ typeof(offset) _off = (offset);\
> + ((CN9K_PFX_CSX_PFCFGX_BASE_ADDR\
> + | (uint64_t)FIELD_PREP(CN9K_PEM_GENMASK, pem)\
> + | FIELD_PREP(CN9K_PF_GENMASK, pf)\
> + | (CN9K_PFX_CSX_PFCFGX_SHADOW_BIT & (_off))\
> + | (rounddown((_off), 8)))\
> + + (CN9K_4BYTE_ALIGNED_ADDRESS_OFFSET(_off)));\
> + })
This macro is completely unreadable. Maybe add a static inline to
perform the CN9K_PEMX_PFX_CSX_PFCFGX() writes.
--
pw-bot: cr
prev parent reply other threads:[~2026-01-10 20:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-07 13:45 [PATCH net-next v3] octeon_ep: reset firmware ready status Vimlesh Kumar
2026-01-10 20:13 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260110121349.25eb40ce@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hgani@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sedara@marvell.com \
--cc=srasheed@marvell.com \
--cc=vburru@marvell.com \
--cc=vimleshk@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox