From: Jakub Kicinski <kuba@kernel.org>
To: Raju Rangoju <Raju.Rangoju@amd.com>
Cc: <netdev@vger.kernel.org>, <pabeni@redhat.com>,
<edumazet@google.com>, <davem@davemloft.net>,
<andrew+netdev@lunn.ch>, <Thomas.Lendacky@amd.com>,
<Shyam-sundar.S-k@amd.com>
Subject: Re: [PATCH net] amd-xgbe: avoid misleading per-packet error log
Date: Mon, 12 Jan 2026 19:28:12 -0800 [thread overview]
Message-ID: <20260112192812.5b0aad55@kernel.org> (raw)
In-Reply-To: <20260110170422.3996690-1-Raju.Rangoju@amd.com>
On Sat, 10 Jan 2026 22:34:22 +0530 Raju Rangoju wrote:
> diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-ethtool.c b/drivers/net/ethernet/amd/xgbe/xgbe-ethtool.c
> index 0d19b09497a0..c8797a338542 100644
> --- a/drivers/net/ethernet/amd/xgbe/xgbe-ethtool.c
> +++ b/drivers/net/ethernet/amd/xgbe/xgbe-ethtool.c
> @@ -75,6 +75,8 @@ static const struct xgbe_stats xgbe_gstring_stats[] = {
> XGMAC_MMC_STAT("rx_pause_frames", rxpauseframes),
> XGMAC_EXT_STAT("rx_split_header_packets", rx_split_header_packets),
> XGMAC_EXT_STAT("rx_buffer_unavailable", rx_buffer_unavailable),
> + XGMAC_EXT_STAT("rx_buffer_overflow", rx_buffer_overflow),
"rx_buffer_overflow" sounds like something that should be categorized
to one of the struct rtnl_link_stats64 stats. See the kdoc in if_link.h
> + XGMAC_EXT_STAT("rx_pkt_errors", rx_pkt_errors),
Are these counted to standard rx_errors somewhere?
--
pw-bot: cr
next prev parent reply other threads:[~2026-01-13 3:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-10 17:04 [PATCH net] amd-xgbe: avoid misleading per-packet error log Raju Rangoju
2026-01-13 3:28 ` Jakub Kicinski [this message]
2026-01-14 15:12 ` Rangoju, Raju
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260112192812.5b0aad55@kernel.org \
--to=kuba@kernel.org \
--cc=Raju.Rangoju@amd.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=Thomas.Lendacky@amd.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox