Re: [Intel-wired-lan] [PATCH net-next 10/12] dpll: Add reference count tracking support

[kernel test robot <lkp@intel.com>]

Hi Ivan,

kernel test robot noticed the following build errors:

[auto build test ERROR on net-next/main]

url:    https://github.com/intel-lab-lkp/linux/commits/Ivan-Vecera/dt-bindings-dpll-add-common-dpll-pin-consumer-schema/20260109-022618
base:   net-next/main
patch link:    https://lore.kernel.org/r/20260108182318.20935-11-ivecera%40redhat.com
patch subject: [Intel-wired-lan] [PATCH net-next 10/12] dpll: Add reference count tracking support
config: m68k-allmodconfig (https://download.01.org/0day-ci/archive/20260112/202601122334.64RmoU1u-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 15.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260112/202601122334.64RmoU1u-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202601122334.64RmoU1u-lkp@intel.com/

All errors (new ones prefixed by >>):

   lib/ref_tracker.c: In function 'ref_tracker_alloc':
>> lib/ref_tracker.c:277:22: error: implicit declaration of function 'stack_trace_save'; did you mean 'stack_depot_save'? [-Wimplicit-function-declaration]
     277 |         nr_entries = stack_trace_save(entries, ARRAY_SIZE(entries), 1);
         |                      ^~~~~~~~~~~~~~~~
         |                      stack_depot_save

Kconfig warnings: (for reference only)
   WARNING: unmet direct dependencies detected for REF_TRACKER
   Depends on [n]: STACKTRACE_SUPPORT
   Selected by [y]:
   - DPLL_REFCNT_TRACKER [=y] && DPLL [=y]


vim +277 lib/ref_tracker.c

4e66934eaadc83b Eric Dumazet  2021-12-04  252  
4e66934eaadc83b Eric Dumazet  2021-12-04  253  int ref_tracker_alloc(struct ref_tracker_dir *dir,
4e66934eaadc83b Eric Dumazet  2021-12-04  254  		      struct ref_tracker **trackerp,
4e66934eaadc83b Eric Dumazet  2021-12-04  255  		      gfp_t gfp)
4e66934eaadc83b Eric Dumazet  2021-12-04  256  {
4e66934eaadc83b Eric Dumazet  2021-12-04  257  	unsigned long entries[REF_TRACKER_STACK_ENTRIES];
4e66934eaadc83b Eric Dumazet  2021-12-04  258  	struct ref_tracker *tracker;
4e66934eaadc83b Eric Dumazet  2021-12-04  259  	unsigned int nr_entries;
acd8f0e5d72741b Andrzej Hajda 2023-06-02  260  	gfp_t gfp_mask = gfp | __GFP_NOWARN;
4e66934eaadc83b Eric Dumazet  2021-12-04  261  	unsigned long flags;
4e66934eaadc83b Eric Dumazet  2021-12-04  262  
e3ececfe668facd Eric Dumazet  2022-02-04  263  	WARN_ON_ONCE(dir->dead);
e3ececfe668facd Eric Dumazet  2022-02-04  264  
8fd5522f44dcd7f Eric Dumazet  2022-02-04  265  	if (!trackerp) {
8fd5522f44dcd7f Eric Dumazet  2022-02-04  266  		refcount_inc(&dir->no_tracker);
8fd5522f44dcd7f Eric Dumazet  2022-02-04  267  		return 0;
8fd5522f44dcd7f Eric Dumazet  2022-02-04  268  	}
c12837d1bb31032 Eric Dumazet  2022-01-12  269  	if (gfp & __GFP_DIRECT_RECLAIM)
c12837d1bb31032 Eric Dumazet  2022-01-12  270  		gfp_mask |= __GFP_NOFAIL;
c12837d1bb31032 Eric Dumazet  2022-01-12  271  	*trackerp = tracker = kzalloc(sizeof(*tracker), gfp_mask);
4e66934eaadc83b Eric Dumazet  2021-12-04  272  	if (unlikely(!tracker)) {
4e66934eaadc83b Eric Dumazet  2021-12-04  273  		pr_err_once("memory allocation failure, unreliable refcount tracker.\n");
4e66934eaadc83b Eric Dumazet  2021-12-04  274  		refcount_inc(&dir->untracked);
4e66934eaadc83b Eric Dumazet  2021-12-04  275  		return -ENOMEM;
4e66934eaadc83b Eric Dumazet  2021-12-04  276  	}
4e66934eaadc83b Eric Dumazet  2021-12-04 @277  	nr_entries = stack_trace_save(entries, ARRAY_SIZE(entries), 1);
4e66934eaadc83b Eric Dumazet  2021-12-04  278  	tracker->alloc_stack_handle = stack_depot_save(entries, nr_entries, gfp);
4e66934eaadc83b Eric Dumazet  2021-12-04  279  
4e66934eaadc83b Eric Dumazet  2021-12-04  280  	spin_lock_irqsave(&dir->lock, flags);
4e66934eaadc83b Eric Dumazet  2021-12-04  281  	list_add(&tracker->head, &dir->list);
4e66934eaadc83b Eric Dumazet  2021-12-04  282  	spin_unlock_irqrestore(&dir->lock, flags);
4e66934eaadc83b Eric Dumazet  2021-12-04  283  	return 0;
4e66934eaadc83b Eric Dumazet  2021-12-04  284  }
4e66934eaadc83b Eric Dumazet  2021-12-04  285  EXPORT_SYMBOL_GPL(ref_tracker_alloc);
4e66934eaadc83b Eric Dumazet  2021-12-04  286  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki