public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: "A. Sverdlin" <alexander.sverdlin@siemens.com>
Cc: netdev@vger.kernel.org, Hauke Mehrtens <hauke@hauke-m.de>,
	Andrew Lunn <andrew@lunn.ch>, Vladimir Oltean <olteanv@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Daniel Golle <daniel@makrotopia.org>
Subject: Re: [PATCH net-next v4 1/2] dt-bindings: net: dsa: lantiq,gswip: add MaxLinear R(G)MII slew rate
Date: Tue, 13 Jan 2026 10:41:28 -0600	[thread overview]
Message-ID: <20260113164128.GA3919887-robh@kernel.org> (raw)
In-Reply-To: <20260107090019.2257867-2-alexander.sverdlin@siemens.com>

On Wed, Jan 07, 2026 at 10:00:16AM +0100, A. Sverdlin wrote:
> From: Alexander Sverdlin <alexander.sverdlin@siemens.com>
> 
> Add new maxlinear,slew-rate-txc and maxlinear,slew-rate-txd uint32
> properties. The properties are only applicable for ports in R(G)MII mode
> and allow for slew rate reduction in comparison to "normal" default
> configuration with the purpose to reduce radiated emissions.
> 
> Signed-off-by: Alexander Sverdlin <alexander.sverdlin@siemens.com>
> ---
> Changelog:
> v4:
> - separate properties for TXD and TXC pads ("maxlinear," prefix re-appears)
> v3:
> - use [pinctrl] standard "slew-rate" property as suggested by Rob
>   https://lore.kernel.org/all/20251219204324.GA3881969-robh@kernel.org/
> v2:
> - unchanged
> 
>  .../devicetree/bindings/net/dsa/lantiq,gswip.yaml  | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/dsa/lantiq,gswip.yaml b/Documentation/devicetree/bindings/net/dsa/lantiq,gswip.yaml
> index 205b683849a53..747106810cc17 100644
> --- a/Documentation/devicetree/bindings/net/dsa/lantiq,gswip.yaml
> +++ b/Documentation/devicetree/bindings/net/dsa/lantiq,gswip.yaml
> @@ -106,6 +106,20 @@ patternProperties:
>          unevaluatedProperties: false
>  
>          properties:
> +          maxlinear,slew-rate-txc:
> +            $ref: /schemas/types.yaml#/definitions/uint32
> +            enum: [0, 1]

default: 0

> +            description: |
> +              RMII/RGMII TX Clock Slew Rate:

blank line
> +              0: "Normal"
> +              1: "Slow"

Indent lists by 2 more spaces. Drop the quotes.

> +          maxlinear,slew-rate-txd:
> +            $ref: /schemas/types.yaml#/definitions/uint32
> +            enum: [0, 1]
> +            description: |
> +              RMII/RGMII TX Non-Clock PAD Slew Rate:
> +              0: "Normal"
> +              1: "Slow"
>            maxlinear,rmii-refclk-out:
>              type: boolean
>              description:
> -- 
> 2.52.0
> 

  reply	other threads:[~2026-01-13 16:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-07  9:00 [PATCH net-next v4 0/2] dsa: mxl-gsw1xx: Support R(G)MII slew rate configuration A. Sverdlin
2026-01-07  9:00 ` [PATCH net-next v4 1/2] dt-bindings: net: dsa: lantiq,gswip: add MaxLinear R(G)MII slew rate A. Sverdlin
2026-01-13 16:41   ` Rob Herring [this message]
2026-01-13 16:59     ` Daniel Golle
2026-01-14  2:04       ` Rob Herring
2026-01-07  9:00 ` [PATCH net-next v4 2/2] net: dsa: mxl-gsw1xx: Support R(G)MII slew rate configuration A. Sverdlin
2026-01-12 12:18   ` Daniel Golle
2026-01-12 15:24     ` Daniel Golle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260113164128.GA3919887-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=alexander.sverdlin@siemens.com \
    --cc=andrew@lunn.ch \
    --cc=conor+dt@kernel.org \
    --cc=daniel@makrotopia.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=hauke@hauke-m.de \
    --cc=krzk+dt@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=olteanv@gmail.com \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox